Handle 4CC format for opaque fb when TestPageFlip

When TestPageFlip, choose the FourCC format that takes opacity into
consideration.

BUG=983937
TEST=GPU doesn't crash anymore on Kefka

Change-Id: I72af7f1755c9cd9c4464246fc73d38adbec57b25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724558Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/master@{#682848}

components/viz/service/display_embedder/overlay_candidate_validator_ozone.cc

@@ -85,6 +85,7 @@ void OverlayCandidateValidatorOzone::CheckOverlaySupport(
     ozone_surface_list.at(i).crop_rect = surfaces->at(i).uv_rect;
     ozone_surface_list.at(i).clip_rect = surfaces->at(i).clip_rect;
     ozone_surface_list.at(i).is_clipped = surfaces->at(i).is_clipped;
+    ozone_surface_list.at(i).is_opaque = surfaces->at(i).is_opaque;
     ozone_surface_list.at(i).plane_z_order = surfaces->at(i).plane_z_order;
     ozone_surface_list.at(i).buffer_size =
         surfaces->at(i).resource_size_in_pixels;

ui/ozone/common/gpu/ozone_gpu_message_params.cc

@@ -31,6 +31,7 @@ OverlayCheck_Params::OverlayCheck_Params(
       format(candidate.format),
       display_rect(gfx::ToNearestRect(candidate.display_rect)),
       crop_rect(candidate.crop_rect),
+      is_opaque(candidate.is_opaque),
       plane_z_order(candidate.plane_z_order),
       is_overlay_candidate(candidate.overlay_handled) {}
 

ui/ozone/common/gpu/ozone_gpu_message_params.h

@@ -65,12 +65,12 @@ struct OverlayCheck_Params {
   OverlayCheck_Params(const OverlayCheck_Params& other);
   ~OverlayCheck_Params();
 
-
   gfx::Size buffer_size;
   gfx::OverlayTransform transform = gfx::OVERLAY_TRANSFORM_NONE;
   gfx::BufferFormat format = gfx::BufferFormat::BGRA_8888;
   gfx::Rect display_rect;
   gfx::RectF crop_rect;
+  bool is_opaque = false;
   int plane_z_order = 0;
   // By default we mark this configuration valid for promoting it to an overlay.
   bool is_overlay_candidate = true;

ui/ozone/common/gpu/ozone_gpu_messages.h

@@ -81,6 +81,7 @@ IPC_STRUCT_TRAITS_BEGIN(ui::OverlayCheck_Params)
   IPC_STRUCT_TRAITS_MEMBER(format)
   IPC_STRUCT_TRAITS_MEMBER(display_rect)
   IPC_STRUCT_TRAITS_MEMBER(crop_rect)
+  IPC_STRUCT_TRAITS_MEMBER(is_opaque)
   IPC_STRUCT_TRAITS_MEMBER(plane_z_order)
   IPC_STRUCT_TRAITS_MEMBER(is_overlay_candidate)
 IPC_STRUCT_TRAITS_END()

ui/ozone/platform/drm/common/drm_util.cc

@@ -10,6 +10,7 @@
 #include <sys/mman.h>
 #include <xf86drm.h>
 #include <xf86drmMode.h>
+
 #include <algorithm>
 #include <memory>
 #include <utility>
@@ -288,8 +289,7 @@ HardwareDisplayControllerInfo::HardwareDisplayControllerInfo(
     size_t index)
     : connector_(std::move(connector)), crtc_(std::move(crtc)), index_(index) {}
 
-HardwareDisplayControllerInfo::~HardwareDisplayControllerInfo() {
-}
+HardwareDisplayControllerInfo::~HardwareDisplayControllerInfo() = default;
 
 std::vector<std::unique_ptr<HardwareDisplayControllerInfo>>
 GetAvailableDisplayControllerInfos(int fd) {
@@ -587,6 +587,7 @@ OverlaySurfaceCandidateList CreateOverlaySurfaceCandidateListFrom(
     osc.format = p.format;
     osc.display_rect = gfx::RectF(p.display_rect);
     osc.crop_rect = p.crop_rect;
+    osc.is_opaque = p.is_opaque;
     osc.plane_z_order = p.plane_z_order;
     osc.overlay_handled = p.is_overlay_candidate;
     candidates.push_back(osc);

ui/ozone/platform/drm/gpu/drm_overlay_validator.cc

@@ -5,6 +5,7 @@
 #include "ui/ozone/platform/drm/gpu/drm_overlay_validator.h"
 
 #include <drm_fourcc.h>
+
 #include <memory>
 #include <utility>
 
@@ -85,7 +86,10 @@ std::vector<OverlayCheckReturn_Params> DrmOverlayValidator::TestPageFlip(
 
     scoped_refptr<DrmFramebuffer> buffer = GetBufferForPageFlipTest(
         drm, params[i].buffer_size,
-        GetFourCCFormatFromBufferFormat(params[i].format), &reusable_buffers);
+        params[i].is_opaque
+            ? GetFourCCFormatForOpaqueFramebuffer(params[i].format)
+            : GetFourCCFormatFromBufferFormat(params[i].format),
+        &reusable_buffers);
 
     DrmOverlayPlane plane(buffer, params[i].plane_z_order, params[i].transform,
                           params[i].display_rect, params[i].crop_rect,

ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc

@@ -5,6 +5,7 @@
 #include "ui/ozone/platform/drm/gpu/drm_overlay_validator.h"
 
 #include <drm_fourcc.h>
+
 #include <memory>
 #include <utility>
 
@@ -143,6 +144,7 @@ void DrmOverlayValidatorTest::SetUp() {
   ui::OverlayCheck_Params primary_candidate;
   primary_candidate.buffer_size = primary_rect_.size();
   primary_candidate.display_rect = primary_rect_;
+  primary_candidate.is_opaque = true;
   primary_candidate.format = gfx::BufferFormat::BGRX_8888;
   overlay_params_.push_back(primary_candidate);
   AddPlane(primary_candidate);
@@ -151,6 +153,7 @@ void DrmOverlayValidatorTest::SetUp() {
   overlay_candidate.buffer_size = overlay_rect_.size();
   overlay_candidate.display_rect = overlay_rect_;
   overlay_candidate.plane_z_order = 1;
+  primary_candidate.is_opaque = true;
   overlay_candidate.format = gfx::BufferFormat::BGRX_8888;
   overlay_params_.push_back(overlay_candidate);
   AddPlane(overlay_candidate);
@@ -224,7 +227,7 @@ void DrmOverlayValidatorTest::AddPlane(const ui::OverlayCheck_Params& params) {
       ui::GetFourCCFormatFromBufferFormat(params.format), params.buffer_size);
   plane_list_.push_back(ui::DrmOverlayPlane(
       std::move(drm_framebuffer), params.plane_z_order, params.transform,
-      params.display_rect, params.crop_rect, true, nullptr));
+      params.display_rect, params.crop_rect, !params.is_opaque, nullptr));
 }
 
 void DrmOverlayValidatorTest::TearDown() {
@@ -302,6 +305,7 @@ TEST_F(DrmOverlayValidatorTest, OverlayFormat_YUV) {
   overlay_params_.back().buffer_size = overlay_rect_.size();
   overlay_params_.back().display_rect = overlay_rect_;
   overlay_params_.back().crop_rect = crop_rect;
+  overlay_params_.back().is_opaque = false;
   overlay_params_.back().format = gfx::BufferFormat::UYVY_422;
   plane_list_.pop_back();
   AddPlane(overlay_params_.back());

ui/ozone/public/mojom/overlay_surface_candidate.mojom

@@ -32,6 +32,8 @@ struct OverlaySurfaceCandidate {
   gfx.mojom.Rect clip_rect;
   // If the quad is clipped after composition.
   bool is_clipped;
+  // If the quad doesn't require blending.
+  bool is_opaque;
   // Stacking order of the overlay plane relative to the main surface,
   // which is 0. Signed to allow for "underlays".
  int32 plane_z_order = 0;

ui/ozone/public/mojom/overlay_surface_candidate_mojom_traits.h

@@ -80,6 +80,10 @@ struct StructTraits<ui::ozone::mojom::OverlaySurfaceCandidateDataView,
     return osc.is_clipped;
   }
 
+  static bool is_opaque(const ui::OverlaySurfaceCandidate& osc) {
+    return osc.is_opaque;
+  }
+
   static int plane_z_order(const ui::OverlaySurfaceCandidate& osc) {
     return osc.plane_z_order;
   }
@@ -91,6 +95,7 @@ struct StructTraits<ui::ozone::mojom::OverlaySurfaceCandidateDataView,
   static bool Read(ui::ozone::mojom::OverlaySurfaceCandidateDataView data,
                    ui::OverlaySurfaceCandidate* out) {
     out->is_clipped = data.is_clipped();
+    out->is_opaque = data.is_opaque();
     out->plane_z_order = data.plane_z_order();
     out->overlay_handled = data.overlay_handled();
     return data.ReadTransform(&out->transform) &&

ui/ozone/public/mojom/overlay_surface_candidate_mojom_traits_unittest.cc

@@ -2,12 +2,13 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "ui/ozone/public/mojom/overlay_surface_candidate_mojom_traits.h"
+
 #include <utility>
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/ozone/public/mojom/overlay_surface_candidate.mojom.h"
-#include "ui/ozone/public/mojom/overlay_surface_candidate_mojom_traits.h"
 #include "ui/ozone/public/overlay_surface_candidate.h"
 
 namespace ui {
@@ -22,6 +23,7 @@ TEST(OverlaySurfaceCandidateStructTraitsTest, FieldsEqual) {
   input.crop_rect = gfx::RectF(10., 20., 30., 40.);
   input.clip_rect = gfx::Rect(11, 21, 31, 41);
   input.is_clipped = true;
+  input.is_opaque = true;
   input.plane_z_order = 42;
   input.overlay_handled = true;
 
@@ -39,6 +41,7 @@ TEST(OverlaySurfaceCandidateStructTraitsTest, FieldsEqual) {
   EXPECT_EQ(input.crop_rect, output.crop_rect);
   EXPECT_EQ(input.clip_rect, output.clip_rect);
   EXPECT_EQ(input.is_clipped, output.is_clipped);
+  EXPECT_EQ(input.is_opaque, output.is_opaque);
   EXPECT_EQ(input.plane_z_order, output.plane_z_order);
   EXPECT_EQ(input.overlay_handled, output.overlay_handled);
 }
@@ -47,6 +50,7 @@ TEST(OverlaySurfaceCandidateStructTraitsTest, FalseBools) {
   ui::OverlaySurfaceCandidate input;
 
   input.is_clipped = false;
+  input.is_opaque = false;
   input.overlay_handled = false;
 
   ui::OverlaySurfaceCandidate output;
@@ -56,6 +60,7 @@ TEST(OverlaySurfaceCandidateStructTraitsTest, FalseBools) {
 
   EXPECT_TRUE(success);
   EXPECT_EQ(input.is_clipped, output.is_clipped);
+  EXPECT_EQ(input.is_opaque, output.is_opaque);
   EXPECT_EQ(input.overlay_handled, output.overlay_handled);
 }
 

ui/ozone/public/overlay_surface_candidate.h

@@ -30,7 +30,7 @@ class COMPONENT_EXPORT(OZONE_BASE) OverlaySurfaceCandidate {
   ~OverlaySurfaceCandidate();
   OverlaySurfaceCandidate& operator=(const OverlaySurfaceCandidate& other);
 
-  // Note that |clip_rect|, |is_clipped| and |overlay_handled| are
+  // Note that |clip_rect|, |is_clipped|, |is_opaque| and |overlay_handled| are
   // *not* used as part of the comparison.
   bool operator<(const OverlaySurfaceCandidate& other) const;
 
@@ -53,6 +53,8 @@ class COMPONENT_EXPORT(OZONE_BASE) OverlaySurfaceCandidate {
   gfx::Rect clip_rect;
   // If the quad is clipped after composition.
   bool is_clipped = false;
+  // If the quad doesn't require blending.
+  bool is_opaque = false;
 
   // To be modified by the implementer if this candidate can go into
   // an overlay.