Settings page: Do not grey out the "Ok Google" checkbox on errors.

Previously, if a mic is not plugged in or some other error occurs (e.g.,
NaCl is disabled), the checkbox is disabled. Now, the checkbox is always
available to turn on or off (with the yellow triangle showing you
whether there is an error).

BUG=396993

Review URL: https://codereview.chromium.org/463823002

Cr-Commit-Position: refs/heads/master@{#290201}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290201 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/resources/options/browser_options.js

@@ -210,7 +210,6 @@ cr.define('options', function() {
 
       var hotwordIndicator = $('hotword-search-setting-indicator');
       HotwordSearchSettingIndicator.decorate(hotwordIndicator);
-      hotwordIndicator.disabledOnErrorSection = $('hotword-search-enable');
       chrome.send('requestHotwordAvailable');
 
       if ($('set-wallpaper')) {

chrome/browser/resources/options/hotword_confirm_dialog.js

@@ -49,12 +49,12 @@ cr.define('options', function() {
         return;
 
       if (event.value.value && !this.confirmed_) {
-        if (!this.indicator.errorText) {
-          PageManager.showPageByName(this.name, false);
-        } else {
+        // If there is an error, show the indicator icon with more information.
+        if (this.indicator.errorText)
           this.indicator.updateBasedOnError();
-          this.handleCancel();
-        }
+
+        // Show confirmation dialog (regardless of whether there is an error).
+        PageManager.showPageByName(this.name, false);
       } else {
         Preferences.getInstance().commitPref(this.pref, this.metric);
       }

chrome/browser/resources/options/hotword_search_setting_indicator.js

@@ -36,15 +36,6 @@ cr.define('options', function() {
       PageManager.hideBubble();
     },
 
-    /**
-     * Sets the variable tracking thesection which becomes disabled if an
-     * error exists.
-     * @param {HTMLElement} section The section to disable.
-     */
-    set disabledOnErrorSection(section) {
-      this.disabledOnErrorSection_ = section;
-    },
-
     /**
      * Returns the current error.
      * @return {string} The error message to be displayed. May be undefined if
@@ -71,8 +62,6 @@ cr.define('options', function() {
     updateBasedOnError: function() {
       if (this.errorText_)
         this.hidden = false;
-      if (this.disabledOnErrorSection_)
-        this.disabledOnErrorSection_.disabled = !!this.errorText_;
     },
 
     /**