Commit 5ecebfe7 authored by Nicolas Dossou-gbete's avatar Nicolas Dossou-gbete Committed by Commit Bot

📰 Report suggestions surface opened on every home sheet impression

Bug: 762549
Change-Id: Iebd5c5dc7d3c3d3d46c4acb8bb03142413e82515
Reviewed-on: https://chromium-review.googlesource.com/663341Reviewed-by: default avatarBernhard Bauer <bauerb@chromium.org>
Reviewed-by: default avatarJan Krcal <jkrcal@chromium.org>
Reviewed-by: default avatarvitaliii <vitaliii@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501322}
parent 27826164
......@@ -128,7 +128,6 @@ public class SuggestionsBottomSheetContent implements BottomSheet.BottomSheetCon
public void onContentShown(boolean isFirstShown) {
if (isFirstShown) {
adapter.refreshSuggestions();
mSuggestionsUiDelegate.getEventReporter().onSurfaceOpened();
maybeUpdateContextualSuggestions();
......@@ -140,6 +139,12 @@ public class SuggestionsBottomSheetContent implements BottomSheet.BottomSheetCon
mRecyclerView.getScrollEventReporter().reset();
}
// TODO(dgn): Temporary workaround to trigger an event in the backend when the
// sheet is opened following inactivity. See https://crbug.com/760974. Should be
// moved back to the "new opening of the sheet" path once we are able to trigger it
// in that case.
mSuggestionsUiDelegate.getEventReporter().onSurfaceOpened();
SuggestionsMetrics.recordSurfaceVisible();
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment