Commit 5ed7fca2 authored by Eric Willigers's avatar Eric Willigers Committed by Commit Bot

Direct Sockets: Count openTCPSocket openUDPSocket

Add feature use counters for calls of Navigator
methods openTCPSocket, openUDPSocket

Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md

Bug: 1119681
Change-Id: I5570c87d73985429e0475cc9e97bea355c926176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367253
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: default avatarGlen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802278}
parent e472e120
...@@ -2787,6 +2787,8 @@ enum WebFeature { ...@@ -2787,6 +2787,8 @@ enum WebFeature {
kWebCodecsVideoTrackReader= 3459, kWebCodecsVideoTrackReader= 3459,
kWebCodecsImageDecoder = 3460, kWebCodecsImageDecoder = 3460,
kBackForwardCacheExperimentHTTPHeader = 3461, kBackForwardCacheExperimentHTTPHeader = 3461,
kV8Navigator_OpenTCPSocket_Method = 3462,
kV8Navigator_OpenUDPSocket_Method = 3463,
// Add new features immediately above this line. Don't change assigned // Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots. // numbers of any item, and don't reuse removed slots.
......
...@@ -9,13 +9,11 @@ ...@@ -9,13 +9,11 @@
ImplementedAs=NavigatorSocket, ImplementedAs=NavigatorSocket,
RuntimeEnabled=DirectSockets RuntimeEnabled=DirectSockets
] partial interface Navigator { ] partial interface Navigator {
// TODO(crbug.com/1119681): Add Measure annotation to each method.
// TODO(crbug.com/905818): Return Promise<TCPSocket> // TODO(crbug.com/905818): Return Promise<TCPSocket>
[SecureContext, RaisesException, CallWith=ScriptState] [SecureContext, RaisesException, CallWith=ScriptState, Measure]
Promise<void> openTCPSocket(optional SocketOptions options = {}); Promise<void> openTCPSocket(optional SocketOptions options = {});
// TODO(crbug.com/1119620): Return Promise<UDPSocket> // TODO(crbug.com/1119620): Return Promise<UDPSocket>
[SecureContext, RaisesException, CallWith=ScriptState] [SecureContext, RaisesException, CallWith=ScriptState, Measure]
Promise<void> openUDPSocket(optional SocketOptions options = {}); Promise<void> openUDPSocket(optional SocketOptions options = {});
}; };
...@@ -29010,6 +29010,8 @@ Called by update_use_counter_feature_enum.py.--> ...@@ -29010,6 +29010,8 @@ Called by update_use_counter_feature_enum.py.-->
<int value="3459" label="WebCodecsVideoTrackReader"/> <int value="3459" label="WebCodecsVideoTrackReader"/>
<int value="3460" label="WebCodecsImageDecoder"/> <int value="3460" label="WebCodecsImageDecoder"/>
<int value="3461" label="BackForwardCacheExperimentHTTPHeader"/> <int value="3461" label="BackForwardCacheExperimentHTTPHeader"/>
<int value="3462" label="V8Navigator_OpenTCPSocket_Method"/>
<int value="3463" label="V8Navigator_OpenUDPSocket_Method"/>
</enum> </enum>
<enum name="FeaturePolicyAllowlistType"> <enum name="FeaturePolicyAllowlistType">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment