Commit 5eda5641 authored by Khushal's avatar Khushal Committed by Commit Bot

Revert "android: Temporarily generate crash dumps for all renderer hangs on Q."

This reverts commit 77418db6.

Reason for revert: Temporary change landed for diagnostic purpose.

Original change's description:
> android: Temporarily generate crash dumps for all renderer hangs on Q.
> 
> R=​dtrainor@chromium.org
> 
> Bug: 983310
> Change-Id: I88d7a60b2938355fb1253707ebf45ab8bffe1c82
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699422
> Auto-Submit: Khushal <khushalsagar@chromium.org>
> Commit-Queue: David Trainor <dtrainor@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#677090}

TBR=dtrainor@chromium.org,khushalsagar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 983310
Change-Id: I705e5e3adc344d36fcb27c0e7e06163ef3d0b397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756393Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687342}
parent b55d4da6
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include <memory> #include <memory>
#include "base/android/build_info.h"
#include "base/android/jni_android.h" #include "base/android/jni_android.h"
#include "base/android/jni_string.h" #include "base/android/jni_string.h"
#include "base/bind.h" #include "base/bind.h"
...@@ -552,14 +551,8 @@ void JNI_TabWebContentsDelegateAndroid_OnRendererUnresponsive( ...@@ -552,14 +551,8 @@ void JNI_TabWebContentsDelegateAndroid_OnRendererUnresponsive(
// reports. // reports.
content::WebContents* web_contents = content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(java_web_contents); content::WebContents::FromJavaWebContents(java_web_contents);
if (base::RandDouble() < 0.01)
// TODO(khushalsagar): Temporarily generate all crash dumps for devices
// running Q to debug a renderer hang. The number of devices running Q at the
// moment is low enough to not overwhelm the crash server.
if (base::RandDouble() < 0.01 ||
base::android::BuildInfo::GetInstance()->is_at_least_q()) {
web_contents->GetMainFrame()->GetProcess()->DumpProcessStack(); web_contents->GetMainFrame()->GetProcess()->DumpProcessStack();
}
if (!base::CommandLine::ForCurrentProcess()->HasSwitch( if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableHungRendererInfoBar)) { switches::kEnableHungRendererInfoBar)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment