Commit 5ee8a62a authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Revert deprecation of webkitURL on Window

Intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EEo3kba4h2g

Bug: 348985
Change-Id: Ia35a1075aca6a2a82de22bda737cb92885453d11
Reviewed-on: https://chromium-review.googlesource.com/c/1334987
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: default avatarPhilip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607968}
parent e2e107ca
CONSOLE WARNING: line 33: 'webkitURL' is deprecated. Please use 'URL' instead.
CONSOLE WARNING: line 33: 'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead.
Make sure prototypes are set up using the window a property came from, instead of the lexical global object.
......
CONSOLE WARNING: 'webkitURL' is deprecated. Please use 'URL' instead.
Test instanceof functions and properties of URL and webkitURL.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
CONSOLE WARNING: line 8: 'webkitURL' is deprecated. Please use 'URL' instead.
CONSOLE WARNING: line 8: 'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead.
This test documents our set of global constructors we expose on the window object (FF and Opera don't expose them on the window, btw). This also checks to make sure than any constructor attribute we expose has the expected constructor type.
......
CONSOLE WARNING: line 80: 'webkitURL' is deprecated. Please use 'URL' instead.
This test documents all interface attributes and methods on the global window object and element instances.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
CONSOLE WARNING: line 80: 'webkitURL' is deprecated. Please use 'URL' instead.
This test documents all interface attributes and methods on the global window object and element instances.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
CONSOLE WARNING: line 80: 'webkitURL' is deprecated. Please use 'URL' instead.
This test documents all interface attributes and methods on the global window object and element instances.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
......@@ -35,7 +35,7 @@ async_test(function(test) {
// is set to false by default.
assert_equals(reports.length, 1);
assert_equals(reports[0].type, "deprecation");
assert_equals(reports[0].body.id, "PrefixedWindowURL");
assert_equals(reports[0].body.id, "PrefixedRequestAnimationFrame");
});
test.done();
......@@ -45,7 +45,7 @@ async_test(function(test) {
// and one after calling observe().
causeIntervention();
observer2.observe();
window.webkitURL; // id = "PrefixedWindowURL"
webkitRequestAnimationFrame(() => {}); // id = "PrefixedCancelAnimationFrame"
observer2.disconnect();
}, "Buffered reports not observed");
</script>
......@@ -38,5 +38,5 @@ async_test(function(test) {
// Use two deprecated features to generate two deprecation reports.
window.webkitStorageInfo;
window.webkitURL;
window.webkitRequestAnimationFrame(() => {});
}, "Deprecation reports");
......@@ -15,7 +15,7 @@ async_test(function(test) {
// |types| option.
assert_equals(reports.length, 1);
assert_equals(reports[0].type, "deprecation");
assert_equals(reports[0].body.id, "PrefixedWindowURL");
assert_equals(reports[0].body.id, "PrefixedRequestAnimationFrame");
});
test.done();
......@@ -23,7 +23,8 @@ async_test(function(test) {
observer1.observe();
// Generate a deprecation report and an intervention report.
window.webkitURL; // id = "PrefixedWindowURL"
// id = "PrefixedRequestAnimationFrame"
webkitRequestAnimationFrame(() => {});
causeIntervention();
observer1.disconnect();
......
CONSOLE WARNING: line 80: 'webkitURL' is deprecated. Please use 'URL' instead.
This test documents all interface attributes and methods on the global window object and element instances.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
CONSOLE WARNING: line 80: 'webkitURL' is deprecated. Please use 'URL' instead.
This test documents all interface attributes and methods on the global window object and element instances.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
CONSOLE WARNING: line 80: 'webkitURL' is deprecated. Please use 'URL' instead.
This test documents all interface attributes and methods on the global window object and element instances.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
......@@ -187,6 +187,9 @@
// https://github.com/WICG/aom/blob/HEAD/explainer.md
[RuntimeEnabled=AccessibilityObjectModel, CallWith=ScriptState] Promise<ComputedAccessibleNode> getComputedAccessibleNode(Element element);
// TODO(yhirano): Move this to url.idl when LegacyWindowAlias is supported.
attribute URLConstructor webkitURL;
// Non-standard APIs
[MeasureAs=WindowClientInformation, Replaceable] readonly attribute Navigator clientInformation;
[Replaceable, MeasureAs=WindowEvent, Custom=Getter, NotEnumerable] readonly attribute Event event;
......@@ -205,7 +208,6 @@
[MeasureAs=StyleMedia] readonly attribute StyleMedia styleMedia;
[DeprecateAs=PrefixedRequestAnimationFrame] long webkitRequestAnimationFrame(FrameRequestCallback callback);
[DeprecateAs=PrefixedCancelAnimationFrame, ImplementedAs=cancelAnimationFrame] void webkitCancelAnimationFrame(long id);
[DeprecateAs=PrefixedWindowURL] attribute URLConstructor webkitURL;
[MeasureAs=PrefixedMutationObserverConstructor] attribute MutationObserverConstructor WebKitMutationObserver;
// Event handler attributes
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment