Commit 5ef1a556 authored by Mirko Bonadei's avatar Mirko Bonadei Committed by Commit Bot

Add missing libs.

While testing the WebRTC component build [1], lld-link started to
complain about undefined symbols from the MS SDK.

This is caused by the fact that different parts of Chromium were relying
on WebRTC to pass some libraries to the linker but since WebRTC is
going to support the component build soon, these libraries will not
reach the linker since they will be linked only in the WebRTC shared
library.

This CL addresses the errors detected here [2].

[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722
[2] - https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/436771

Bug: webrtc:9419
Change-Id: I7af507a13285f976b5545025e2181ae4e47eded2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913251
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714947}
parent a48859ad
...@@ -2214,6 +2214,10 @@ jumbo_static_library("browser") { ...@@ -2214,6 +2214,10 @@ jumbo_static_library("browser") {
"//ui/web_dialogs", "//ui/web_dialogs",
] ]
if (is_win) {
libs += [ "secur32.lib" ]
}
if (is_posix || is_fuchsia) { if (is_posix || is_fuchsia) {
sources += [ sources += [
"download/trusted_sources_manager_posix.cc", "download/trusted_sources_manager_posix.cc",
......
...@@ -29,6 +29,11 @@ source_set("music_manager_private") { ...@@ -29,6 +29,11 @@ source_set("music_manager_private") {
"//rlz/buildflags", "//rlz/buildflags",
] ]
libs = []
if (is_win) {
libs += [ "iphlpapi.lib" ]
}
if (is_chromeos) { if (is_chromeos) {
sources -= [ "device_id_linux.cc" ] sources -= [ "device_id_linux.cc" ]
......
...@@ -88,5 +88,6 @@ static_library("discovery") { ...@@ -88,5 +88,6 @@ static_library("discovery") {
if (is_win) { if (is_win) {
sources += [ "discovery_network_list_win.cc" ] sources += [ "discovery_network_list_win.cc" ]
libs = [ "iphlpapi.lib" ]
} }
} }
...@@ -2443,6 +2443,7 @@ jumbo_static_library("ui") { ...@@ -2443,6 +2443,7 @@ jumbo_static_library("ui") {
"//ui/base/ime", "//ui/base/ime",
"//ui/events:dom_keycode_converter", "//ui/events:dom_keycode_converter",
] ]
libs += [ "crypt32.lib" ]
if (is_chrome_branded) { if (is_chrome_branded) {
sources += [ sources += [
......
...@@ -33,6 +33,8 @@ source_set("module_info") { ...@@ -33,6 +33,8 @@ source_set("module_info") {
"//base:i18n", "//base:i18n",
"//chrome/common/safe_browsing:pe_image_reader", "//chrome/common/safe_browsing:pe_image_reader",
] ]
libs = [ "crypt32.lib" ]
} }
loadable_module("conflicts_dll") { loadable_module("conflicts_dll") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment