Commit 5f27c4c2 authored by David Bertoni's avatar David Bertoni Committed by Commit Bot

[Extensions] Re-enable some API tests.

These tests were disabled many years ago and it's unclear why
they weren't enabled when the underlying issue was fixed. There
was a CL that purported to do this:

https://codereview.chromium.org/9517002

Not sure what happened here, but I don't think it's worth
spending more time figuring it out.

Note: These were NOT disabled for being flaky.

Bug: 116490
Change-Id: I8f200b0f32a10ce1c02959f686e1319e069fd5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252606Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780075}
parent 4e4c54b3
...@@ -152,7 +152,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, MAYBE_TabOpener) { ...@@ -152,7 +152,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, MAYBE_TabOpener) {
ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "opener.html")) << message_; ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "opener.html")) << message_;
} }
IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, DISABLED_TabGetCurrent) { IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, TabGetCurrent) {
ASSERT_TRUE(RunExtensionTest("tabs/get_current")) << message_; ASSERT_TRUE(RunExtensionTest("tabs/get_current")) << message_;
} }
...@@ -165,7 +165,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, DISABLED_TabOnRemoved) { ...@@ -165,7 +165,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, DISABLED_TabOnRemoved) {
ASSERT_TRUE(RunExtensionTest("tabs/on_removed")) << message_; ASSERT_TRUE(RunExtensionTest("tabs/on_removed")) << message_;
} }
IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, DISABLED_TabReload) { IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, TabReload) {
ASSERT_TRUE(RunExtensionTest("tabs/reload")) << message_; ASSERT_TRUE(RunExtensionTest("tabs/reload")) << message_;
} }
...@@ -277,11 +277,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, IncognitoDisabledByPref) { ...@@ -277,11 +277,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, IncognitoDisabledByPref) {
ASSERT_TRUE(RunExtensionTest("tabs/incognito_disabled")) << message_; ASSERT_TRUE(RunExtensionTest("tabs/incognito_disabled")) << message_;
} }
IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, DISABLED_GetViewsOfCreatedPopup) { IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, GetViewsOfCreatedPopup) {
ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html")) ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))
<< message_; << message_;
} }
IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, DISABLED_GetViewsOfCreatedWindow) { IN_PROC_BROWSER_TEST_F(ExtensionApiTabTest, GetViewsOfCreatedWindow) {
ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html")) ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))
<< message_; << message_;
} }
......
...@@ -228,7 +228,7 @@ IN_PROC_BROWSER_TEST_F(WindowOpenApiTest, WindowArgumentsOverflow) { ...@@ -228,7 +228,7 @@ IN_PROC_BROWSER_TEST_F(WindowOpenApiTest, WindowArgumentsOverflow) {
ASSERT_TRUE(RunExtensionTest("window_open/argument_overflow")) << message_; ASSERT_TRUE(RunExtensionTest("window_open/argument_overflow")) << message_;
} }
IN_PROC_BROWSER_TEST_F(WindowOpenApiTest, DISABLED_WindowOpener) { IN_PROC_BROWSER_TEST_F(WindowOpenApiTest, WindowOpener) {
ASSERT_TRUE(RunExtensionTest("window_open/opener")) << message_; ASSERT_TRUE(RunExtensionTest("window_open/opener")) << message_;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment