Commit 5f3f4779 authored by Marc-Antoine Ruel's avatar Marc-Antoine Ruel Committed by Commit Bot

Revert "Reland "Add luci-go tool to be fetched via CIPD""

This reverts commit 4e4521b8.

Reason for revert: This broke the code search builder.

Reverting since everyone in the US is OOO, so this wouldn't be fixed for at least two days.

Bug: 860239

Original change's description:
> Reland "Add luci-go tool to be fetched via CIPD"
> 
> This is a reland of 3bcc71d8
> 
> Original change's description:
> > Add luci-go tool to be fetched via CIPD
> > 
> > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes
> > need to be updated.
> > 
> > Change analyze to not ignore changes to isolate.
> > 
> > R=tandrii@chromium.org
> > 
> > Bug: 851596
> > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5
> > Reviewed-on: https://chromium-review.googlesource.com/1097623
> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#569688}
> 
> Bug: 851596
> Change-Id: I27382d97370376dcca8110c9225c16dada182256
> Reviewed-on: https://chromium-review.googlesource.com/1125000
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572435}

TBR=maruel@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org

Change-Id: Ia95f851c24fab175827fc2a7d5d1472713b909af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851596
Reviewed-on: https://chromium-review.googlesource.com/1125900Reviewed-by: default avatarMarc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572546}
parent 8b0cc8b0
......@@ -346,16 +346,6 @@ deps = {
'condition': 'checkout_nacl',
},
'src/tools/luci-go': {
'packages': [
{
'package': 'infra/tools/luci/isolate/${{platform}}',
'version': 'git_revision:8b15ba47cbaf07a56f93326e39f0c8e5069c19e8',
},
],
'dep_type': 'cipd',
},
'src/third_party/SPIRV-Tools/src':
Var('chromium_git') + '/external/github.com/KhronosGroup/SPIRV-Tools.git' + '@' + '9166854ac93ef81b026e943ccd230fed6c8b8d3c',
......@@ -1718,7 +1708,6 @@ hooks = [
],
},
# Pull luci-go binaries (isolate, swarming) using checked-in hashes.
# TODO(maruel): Remove, https://crbug.com/851596
{
'name': 'luci-go_win',
'pattern': '.',
......
......@@ -32,7 +32,8 @@
"testing/scripts/.*",
"testing/test_env.py",
"third_party/android_platform/development/scripts/.*",
"tools/clang/blink_gc_plugin/CMakeLists.txt"
"tools/clang/blink_gc_plugin/CMakeLists.txt",
"tools/luci-go/.*"
],
"ignores": [
"infra/config/recipes.cfg",
......
/isolate
/isolate.exe
/linux64/isolate
/mac64/isolate
/win64/isolate.exe
djd@chromium.org
maruel@chromium.org
tandrii@chromium.org
tansell@chromium.org
vadimsh@chromium.org
......@@ -2,4 +2,9 @@
Contains executable built out of
https://chromium.googlesource.com/infra/luci/luci-go/+/master/client/cmd
Mapped through CIPD.
The binaries are retrieved from the following builders:
- mac64: http://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.10-64/
- linux64: http://build.chromium.org/p/chromium.infra/builders/infra-continuous-precise-64/
- win64: http://build.chromium.org/p/chromium.infra/builders/infra-continuous-win-64/
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment