Commit 5f63e7ad authored by Sami Kyostila's avatar Sami Kyostila Committed by Chromium LUCI CQ

chrome: Add missing semicolons to TRACE_EVENTs

Chrome is about to switch to the TRACE_EVENT macro implementation
provided by Perfetto. The new implementation requires trace event
statements to be terminated by semicolons, so this patch modifies the
codebase to add semicolons where they were previously left out.

No functional changes.

Bug: 1006541
Change-Id: If9e1397a58ef93f8dfe6f9302a87420837758e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628300
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844210}
parent 56617b0d
...@@ -348,7 +348,7 @@ Profile* CreatePrimaryProfile(const content::MainFunctionParams& parameters, ...@@ -348,7 +348,7 @@ Profile* CreatePrimaryProfile(const content::MainFunctionParams& parameters,
const base::FilePath& user_data_dir, const base::FilePath& user_data_dir,
const base::FilePath& cur_dir, const base::FilePath& cur_dir,
const base::CommandLine& parsed_command_line) { const base::CommandLine& parsed_command_line) {
TRACE_EVENT0("startup", "ChromeBrowserMainParts::CreateProfile") TRACE_EVENT0("startup", "ChromeBrowserMainParts::CreateProfile");
base::Time start = base::Time::Now(); base::Time start = base::Time::Now();
bool last_used_profile_set = false; bool last_used_profile_set = false;
...@@ -856,7 +856,7 @@ int ChromeBrowserMainParts::ApplyFirstRunPrefs() { ...@@ -856,7 +856,7 @@ int ChromeBrowserMainParts::ApplyFirstRunPrefs() {
} }
int ChromeBrowserMainParts::PreCreateThreadsImpl() { int ChromeBrowserMainParts::PreCreateThreadsImpl() {
TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreCreateThreadsImpl") TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreCreateThreadsImpl");
run_message_loop_ = false; run_message_loop_ = false;
if (browser_process_->GetApplicationLocale().empty()) { if (browser_process_->GetApplicationLocale().empty()) {
......
...@@ -37,7 +37,7 @@ ChromeBrowserMainPartsAndroid::~ChromeBrowserMainPartsAndroid() { ...@@ -37,7 +37,7 @@ ChromeBrowserMainPartsAndroid::~ChromeBrowserMainPartsAndroid() {
} }
int ChromeBrowserMainPartsAndroid::PreCreateThreads() { int ChromeBrowserMainPartsAndroid::PreCreateThreads() {
TRACE_EVENT0("startup", "ChromeBrowserMainPartsAndroid::PreCreateThreads") TRACE_EVENT0("startup", "ChromeBrowserMainPartsAndroid::PreCreateThreads");
int result_code = ChromeBrowserMainParts::PreCreateThreads(); int result_code = ChromeBrowserMainParts::PreCreateThreads();
...@@ -74,7 +74,7 @@ void ChromeBrowserMainPartsAndroid::PostProfileInit() { ...@@ -74,7 +74,7 @@ void ChromeBrowserMainPartsAndroid::PostProfileInit() {
int ChromeBrowserMainPartsAndroid::PreEarlyInitialization() { int ChromeBrowserMainPartsAndroid::PreEarlyInitialization() {
TRACE_EVENT0("startup", TRACE_EVENT0("startup",
"ChromeBrowserMainPartsAndroid::PreEarlyInitialization") "ChromeBrowserMainPartsAndroid::PreEarlyInitialization");
content::Compositor::Initialize(); content::Compositor::Initialize();
CHECK(base::CurrentThread::IsSet()); CHECK(base::CurrentThread::IsSet());
......
...@@ -98,7 +98,7 @@ void MaybeUnlocalizeFontName(std::string* font_name) { ...@@ -98,7 +98,7 @@ void MaybeUnlocalizeFontName(std::string* font_name) {
FontSettingsEventRouter::FontSettingsEventRouter(Profile* profile) FontSettingsEventRouter::FontSettingsEventRouter(Profile* profile)
: profile_(profile) { : profile_(profile) {
TRACE_EVENT0("browser,startup", "FontSettingsEventRouter::ctor") TRACE_EVENT0("browser,startup", "FontSettingsEventRouter::ctor");
registrar_.Init(profile_->GetPrefs()); registrar_.Init(profile_->GetPrefs());
......
...@@ -25,7 +25,7 @@ namespace prerender { ...@@ -25,7 +25,7 @@ namespace prerender {
// static // static
PrerenderManager* PrerenderManagerFactory::GetForBrowserContext( PrerenderManager* PrerenderManagerFactory::GetForBrowserContext(
content::BrowserContext* context) { content::BrowserContext* context) {
TRACE_EVENT0("browser", "PrerenderManagerFactory::GetForProfile") TRACE_EVENT0("browser", "PrerenderManagerFactory::GetForProfile");
return static_cast<PrerenderManager*>( return static_cast<PrerenderManager*>(
GetInstance()->GetServiceForBrowserContext(context, true)); GetInstance()->GetServiceForBrowserContext(context, true));
} }
......
...@@ -479,7 +479,7 @@ ProfileImpl::ProfileImpl( ...@@ -479,7 +479,7 @@ ProfileImpl::ProfileImpl(
delegate_(delegate), delegate_(delegate),
shared_cors_origin_access_list_( shared_cors_origin_access_list_(
content::SharedCorsOriginAccessList::Create()) { content::SharedCorsOriginAccessList::Create()) {
TRACE_EVENT0("browser,startup", "ProfileImpl::ctor") TRACE_EVENT0("browser,startup", "ProfileImpl::ctor");
DCHECK(!path.empty()) << "Using an empty path will attempt to write " DCHECK(!path.empty()) << "Using an empty path will attempt to write "
<< "profile files to the root directory!"; << "profile files to the root directory!";
...@@ -652,7 +652,7 @@ void ProfileImpl::LoadPrefsForNormalStartup(bool async_prefs) { ...@@ -652,7 +652,7 @@ void ProfileImpl::LoadPrefsForNormalStartup(bool async_prefs) {
} }
void ProfileImpl::DoFinalInit() { void ProfileImpl::DoFinalInit() {
TRACE_EVENT0("browser", "ProfileImpl::DoFinalInit") TRACE_EVENT0("browser", "ProfileImpl::DoFinalInit");
PrefService* prefs = GetPrefs(); PrefService* prefs = GetPrefs();
...@@ -1033,7 +1033,7 @@ bool ProfileImpl::AllowsBrowserWindows() const { ...@@ -1033,7 +1033,7 @@ bool ProfileImpl::AllowsBrowserWindows() const {
ExtensionSpecialStoragePolicy* ProfileImpl::GetExtensionSpecialStoragePolicy() { ExtensionSpecialStoragePolicy* ProfileImpl::GetExtensionSpecialStoragePolicy() {
#if BUILDFLAG(ENABLE_EXTENSIONS) #if BUILDFLAG(ENABLE_EXTENSIONS)
if (!extension_special_storage_policy_.get()) { if (!extension_special_storage_policy_.get()) {
TRACE_EVENT0("browser", "ProfileImpl::GetExtensionSpecialStoragePolicy") TRACE_EVENT0("browser", "ProfileImpl::GetExtensionSpecialStoragePolicy");
extension_special_storage_policy_ = new ExtensionSpecialStoragePolicy( extension_special_storage_policy_ = new ExtensionSpecialStoragePolicy(
CookieSettingsFactory::GetForProfile(this).get()); CookieSettingsFactory::GetForProfile(this).get());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment