Skip to content

GitLab

T
tangled
Commit 5f69aafb authored by Antonio Gomes's avatar Antonio Gomes Committed by Commit Bot
Browse files
Options

Simplify flexbox-lines-must-be-stretched-by-default.html JS logic 

In the early days, this test was written to accommodate the case where
CSS Grid was under development, and possible to be toggled on/off at
runtime.

Now that CSS is Grid in stable for years, we can simplify the test's
JS code, and rewrite most of the page in pure HTML.

BUG=1063749
R=jfernandez@igalia.com

Change-Id: I558ba15bddd252c2f5fefb236cf630f3d08533f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133918Reviewed-by: default avatarJavier Fernandez <jfernandez@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755902}
parent 05bb4ece
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 27 deletions
third_party/blink/web_tests/external/wpt/css/css-flexbox/flexbox-lines-must-be-stretched-by-default.html
View file @ 5f69aafb
<!DOCTYPE html> <!DOCTYPE html>
<title>CSS Flexbox: align-content initial value.</title> <title>CSS Flexbox: align-content initial value.</title>
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#align-content-property"> <link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#align-content-property">
<meta name="assert" content="This test ensures that 'align-content: initial' on flexbox container gets computed to 'stretch'."/> <meta name="assert" content="This test ensures that a flexbox container's align-content value default to 'stretch'."/>
<style> <style>
.flex-container { .flex-container {
display: flex; display: flex;
...@@ -24,30 +24,9 @@ ...@@ -24,30 +24,9 @@
<script src="/resources/testharness.js"></script> <script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script> <script src="/resources/testharnessreport.js"></script>
<script src="/resources/check-layout-th.js"></script> <script src="/resources/check-layout-th.js"></script>
<body> <body onload="checkLayout('.flex-container')">
<script> <div id="flexContainer" class="flex-container">
var flexContainer = document.createElement("div"); <div id="flexItem1" class="flex-item1" data-expected-height=51></div>
flexContainer.className = "flex-container"; <div id="flexItem2" class="flex-item2" data-expected-height=49></div>
document.body.appendChild(flexContainer); </div>
var flexItem1 = document.createElement("div");
flexItem1.id = "flexItem1";
flexItem1.className += "flex-item1";
flexItem1.setAttribute("data-expected-height", "51");
flexContainer.appendChild(flexItem1);
var flexItem2 = document.createElement("div");
flexItem2.id = "flexItem2";
flexItem2.className += "flex-item2";
flexItem2.setAttribute("data-expected-height", "49");
flexContainer.appendChild(flexItem2);
var br = document.createElement("br");
document.body.appendChild(br);
flexContainer.style.alignContent = "initial";
checkLayout('.flex-container');
</script>
<div id="log"></div>
</body> </body>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment