Commit 5f7d9989 authored by Philip Rogers's avatar Philip Rogers Committed by Commit Bot

Remove NeedsLayout check from TouchEventTargetRectsDidChange

This check is wrong because we cannot skip setting the dirty bits. This
check dates back to a time when the rects were synchronously calculated
which would have required layout information:
https://chromium.googlesource.com/chromium/src/+/3ab811935da94c0afc143978a4ca3721788c770f

Change-Id: Icc46b97b6fed64972d028676f43022f60935ae94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528483Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642327}
parent f3497a58
......@@ -650,12 +650,6 @@ void ScrollingCoordinator::TouchEventTargetRectsDidChange(LocalFrame* frame) {
if (!frame_view)
return;
// Wait until after layout to update.
// TODO(pdr): This check is wrong as we need to mark the rects as dirty
// regardless of whether the frame view needs layout. Remove this check.
if (frame_view->NeedsLayout())
return;
// FIXME: scheduleAnimation() is just a method of forcing the compositor to
// realize that it needs to commit here. We should expose a cleaner API for
// this.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment