Commit 5f9041e4 authored by sky@chromium.org's avatar sky@chromium.org

Fixes bug where ActiveInputMethodsChanged was being invoked with the

wrong InputMethodDescriptor. In this test case we end up in
MaybeChangeCurrentKeyboardLayout with value.string_list_value.size()
== 5 so that we don't  reset current_input_method_ and instead pass in
current_input_method_, which is empty. Another possible fix is to
change the if to be !value.string_list_value.empty(). Not sure if
that's the right fix though.

BUG=104674
TEST=none
R=yusukes@chromium.org


Review URL: http://codereview.chromium.org/8561025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110850 0039d316-1c4b-4281-b951-d872f2087c98
parent e5866060
......@@ -697,7 +697,7 @@ class InputMethodManagerImpl : public HotkeyManager::Observer,
const size_t num_active_input_methods = GetNumActiveInputMethods();
FOR_EACH_OBSERVER(InputMethodManager::Observer, observers_,
ActiveInputMethodsChanged(this,
current_input_method_,
current_input_method(),
num_active_input_methods));
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment