Commit 5f98d33d authored by dcheng's avatar dcheng Committed by Commit bot

Move override/final to the approved C++11 features section.

Discussion thread:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/VTNZzizN0zo

NOTRY=true

Review URL: https://codereview.chromium.org/596723003

Cr-Commit-Position: refs/heads/master@{#296541}
parent 4253aba6
...@@ -65,6 +65,14 @@ C++ Templates Angle Brackets Pitfall</a></td> ...@@ -65,6 +65,14 @@ C++ Templates Angle Brackets Pitfall</a></td>
<td>Recommended to increase readability. Approved without discussion.</td> <td>Recommended to increase readability. Approved without discussion.</td>
</tr> </tr>
<tr>
<td>Final Specifier</td>
<td><code>final</code></td>
<td> Indicates that a class or function is final and cannot be overridden</td>
<td><a href="http://en.cppreference.com/w/cpp/language/final">final Language Reference</a></td>
<td>Recommended for new code. Existing uses of the <code>FINAL</code> macro will be <a href="https://crbug.com/417463">replaced throughout the codebase</a>. <a href="https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/VTNZzizN0zo">Discussion</a></td>
</tr>
<tr> <tr>
<td>Local Types as Template Arguments</td> <td>Local Types as Template Arguments</td>
<td></td> <td></td>
...@@ -74,16 +82,6 @@ Local types, types without linkage and unnamed types as template arguments</a></ ...@@ -74,16 +82,6 @@ Local types, types without linkage and unnamed types as template arguments</a></
<td>Usage should be rare. Approved without discussion.</td> <td>Usage should be rare. Approved without discussion.</td>
</tr> </tr>
<tr>
<td>Standard Integers</td>
<td>Typedefs within <code>&lt;stdint.h&gt;</code>
and <code>&lt;inttypes&gt;</code></td>
<td>Provides fixed-size integers independent of platforms</td>
<td><a href="http://www.cplusplus.com/reference/cstdint/">
&lt;stdint.h&gt; (cstdint)</a></td>
<td>Already in common use in the codebase. Approved without discussion.</td>
</tr>
<tr> <tr>
<td>Null Pointer Constant</td> <td>Null Pointer Constant</td>
<td><code>nullptr</code></td> <td><code>nullptr</code></td>
...@@ -96,6 +94,24 @@ Note: <code>std::nullptr_t</code> is a library feature and not available. ...@@ -96,6 +94,24 @@ Note: <code>std::nullptr_t</code> is a library feature and not available.
</td> </td>
</tr> </tr>
<tr>
<td>Override Specifier</td>
<td><code>override</code></td>
<td>Indicates that a class or function overrides a base implementation</td>
<td><a href="http://en.cppreference.com/w/cpp/language/override">override Language Reference</a></td>
<td>Recommended for new code. Existing uses of the <code>OVERRIDE</code> macro will be <a href="https://crbug.com/417463">replaced throughout the codebase</a>. <a href="https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/VTNZzizN0zo">Discussion</a></td>
</tr>
<tr>
<td>Standard Integers</td>
<td>Typedefs within <code>&lt;stdint.h&gt;</code>
and <code>&lt;inttypes&gt;</code></td>
<td>Provides fixed-size integers independent of platforms</td>
<td><a href="http://www.cplusplus.com/reference/cstdint/">
&lt;stdint.h&gt; (cstdint)</a></td>
<td>Already in common use in the codebase. Approved without discussion.</td>
</tr>
</tbody> </tbody>
</table> </table>
...@@ -266,14 +282,6 @@ explicit specifier</a></td> ...@@ -266,14 +282,6 @@ explicit specifier</a></td>
<td></td> <td></td>
</tr> </tr>
<tr>
<td>Final Declarations</td>
<td><code>final</code></td>
<td>Indicates that a class or function is final and cannot be overridden</td>
<td>TODO: documentation link</td>
<td><code>FINAL</code> is already widely used in the codebase.</td>
</tr>
<tr> <tr>
<td>Function Local Variable</td> <td>Function Local Variable</td>
<td><code>__func__</code></td> <td><code>__func__</code></td>
...@@ -342,14 +350,6 @@ Non-static data members</a></td> ...@@ -342,14 +350,6 @@ Non-static data members</a></td>
<td></td> <td></td>
</tr> </tr>
<tr>
<td>Overrides</td>
<td><code>override</code></td>
<td>Indicates that a class or function overrides a base implementation</td>
<td>TODO: documentation link</td>
<td><code>OVERRIDE</code> is already widely used in the codebase.</td>
</tr>
<tr> <tr>
<td>Range-Based For Loops</td> <td>Range-Based For Loops</td>
<td><code>for (<i>type</i> <i>var</i> : <i>range</i>)</code></td> <td><code>for (<i>type</i> <i>var</i> : <i>range</i>)</code></td>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment