Commit 5fb6274c authored by brucedawson's avatar brucedawson Committed by Commit bot

Disable /analyze for the libexif and yasm projects to hack around internal compiler errors

VC++ hits internal compiler errors on a source file in each of yasm and
libexif. This halts the build and prevents full analysis. Therefore this
change disables /analyze for those two projects, to increase total
coverage.

Also fix a typo in libexif's README.chromium

BUG=427616

Review URL: https://codereview.chromium.org/657883003

Cr-Commit-Position: refs/heads/master@{#302381}
parent caf53360
...@@ -21,5 +21,5 @@ Local Modifications: ...@@ -21,5 +21,5 @@ Local Modifications:
INSTALL, install-sh, Makefile-files, *.sym, *.am, *.in, *.pc.in, *.spec, *.sh INSTALL, install-sh, Makefile-files, *.sym, *.am, *.in, *.pc.in, *.spec, *.sh
and *.txt files. and *.txt files.
- Removed "doc", "po", "NEWS", "mkinstalldirs", "missing", "nls" folders. - Removed "doc", "po", "NEWS", "mkinstalldirs", "missing", "nls" folders.
- Removed inline from exif_tag_table_count function in exif_tag.c, to build - Removed inline from exif_tag_table_count function in exif-tag.c, to build
cleanly with MSVC's non-standard inline rules. cleanly with MSVC's non-standard inline rules.
...@@ -91,6 +91,16 @@ ...@@ -91,6 +91,16 @@
4018, # size/unsigned mismatch 4018, # size/unsigned mismatch
4267, # size_t -> ExifLong truncation on amd64 4267, # size_t -> ExifLong truncation on amd64
], ],
# As of VS 2013 Update 3, building this project with /analyze hits
# an internal compiler error on exif-entry.c. This halts the build
# and prevents subsequent analysis. Therefore, /analyze is
# disabled for this project. See this bug for details:
# https://connect.microsoft.com/VisualStudio/feedback/details/1014689/internal-compiler-error
'msvs_settings': {
'VCCLCompilerTool': {
'AdditionalOptions!': [ '/analyze' ]
},
},
}], }],
], ],
}, },
......
...@@ -135,4 +135,7 @@ Instructions for recreating the yasm.gyp file. ...@@ -135,4 +135,7 @@ Instructions for recreating the yasm.gyp file.
default. The yasm.gyp build patches this file before invoking it to default. The yasm.gyp build patches this file before invoking it to
allow specifying an output directory. allow specifying an output directory.
10) If all that's is finished, attempt to build....and cross your fingers. 10) Recreate the 'AdditionalOptions!': [ '/analyze' ] block so that VC++
/analyze builds won't fail.
11) If all that's is finished, attempt to build....and cross your fingers.
...@@ -77,6 +77,21 @@ ...@@ -77,6 +77,21 @@
'-Wno-incompatible-pointer-types', '-Wno-incompatible-pointer-types',
], ],
}, },
'conditions': [
['OS=="win"', {
# As of VS 2013 Update 3, building this project with /analyze hits an
# internal compiler error on elf-x86-amd64.c in release builds with
# the amd64_x86 compiler. This halts the build and prevents subsequent
# analysis. Therefore, /analyze is disabled for this project. See this
# bug for details:
# https://connect.microsoft.com/VisualStudio/feedback/details/1014799/internal-compiler-error-when-using-analyze
'msvs_settings': {
'VCCLCompilerTool': {
'AdditionalOptions!': [ '/analyze' ]
},
},
}],
],
'sources': [ 'sources': [
'source/patched-yasm/frontends/yasm/yasm-options.c', 'source/patched-yasm/frontends/yasm/yasm-options.c',
'source/patched-yasm/frontends/yasm/yasm.c', 'source/patched-yasm/frontends/yasm/yasm.c',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment