settings: fix search

don't reference an element that doesn't exist. A button was removed in r160703, but it was still listed as an "associated control" for search, so that during search NULL was derefed.

BUG=155364

Review URL: https://codereview.chromium.org/11193013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162307 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/resources/options/options.js

@@ -84,8 +84,7 @@ function load() {
                                $('show-cookies-button')]);
   OptionsPage.registerOverlay(CookiesViewApp.getInstance(),
                               ContentSettings.getInstance(),
-                              [$('privacyContentSettingsButton'),
-                               $('show-app-cookies-button')]);
+                              [$('privacyContentSettingsButton')]);
   OptionsPage.registerOverlay(DoNotTrackConfirmOverlay.getInstance(),
                               BrowserOptions.getInstance());
   OptionsPage.registerOverlay(FontSettings.getInstance(),

chrome/browser/resources/options/options_page.js

@@ -500,6 +500,11 @@ cr.define('options', function() {
         overlay.associatedSection =
             this.findSectionForNode_(associatedControls[0]);
       }
+
+      // Sanity check.
+      for (var i = 0; i < associatedControls.length; ++i) {
+        assert(associatedControls[i], 'Invalid element passed.');
+      }
     }
 
     // Reverse the button strip for views. See the documentation of