DevTools: info-level, caught-promise-rejections should be verbose

A promise rejection produces an error log. Before, catching the
exception turned the log level from error > info. Now, it turns from
error > verbose.

Screenshot: https://imgur.com/a/hKiFzWg

Bug: 393913
Change-Id: Icd903cedfc7980789dcbbed93efbd63ea7210958
Reviewed-on: https://chromium-review.googlesource.com/c/1252381Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596486}

third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-expected.txt

@@ -10,7 +10,11 @@ console-message-wrapper console-error-level x3
 
 Handling promise
 1 error
-console-message-wrapper console-info-level
 console-message-wrapper console-error-level
-console-message-wrapper console-info-level
+
+Enable verbose filter
+1 error
+console-message-wrapper console-verbose-level
+console-message-wrapper console-error-level
+console-message-wrapper console-verbose-level
 

third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-in-worker-expected.txt

@@ -7,5 +7,7 @@ Message added: error log
 console-message-wrapper console-error-level
 
 Handling promise
-console-message-wrapper console-info-level
+
+Enable verbose filter
+console-message-wrapper console-verbose-level
 

third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error-in-worker.js

@@ -25,6 +25,7 @@
   SDK.consoleModel.addEventListener(
       SDK.ConsoleModel.Events.MessageUpdated, ConsoleTestRunner.wrapListener(messageUpdated));
 
+  Console.ConsoleView.instance()._setImmediatelyFilterMessagesForTest();
   TestRunner.addResult('Creating worker with promise');
   TestRunner.evaluateInPageWithTimeout('createPromise()');
 
@@ -42,6 +43,12 @@
 
   async function messageUpdated() {
     await ConsoleTestRunner.dumpConsoleCounters();
+
+    // Turn on verbose filter.
+    TestRunner.addResult(`\nEnable verbose filter`);
+    Console.ConsoleViewFilter.levelFilterSetting().set(Console.ConsoleFilter.allLevelsFilterValue());
+    await ConsoleTestRunner.dumpConsoleCounters();
+
     TestRunner.completeTest();
   }
 })();

third_party/WebKit/LayoutTests/http/tests/devtools/console/console-revoke-error.js

@@ -24,6 +24,7 @@
 
   var messageAddedListener = ConsoleTestRunner.wrapListener(messageAdded);
   SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, messageAddedListener);
+  Console.ConsoleView.instance()._setImmediatelyFilterMessagesForTest();
   Common.settings.moduleSetting('consoleGroupSimilar').set(false);
   TestRunner.addResult('Creating promise');
   TestRunner.evaluateInPageWithTimeout('createPromises()');
@@ -51,6 +52,12 @@
     if (++messageNumber < 2)
       return;
     await ConsoleTestRunner.dumpConsoleCounters();
+
+    // Turn on verbose filter.
+    TestRunner.addResult(`\nEnable verbose filter`);
+    Console.ConsoleViewFilter.levelFilterSetting().set(Console.ConsoleFilter.allLevelsFilterValue());
+    await ConsoleTestRunner.dumpConsoleCounters();
+
     TestRunner.completeTest();
   }
 })();

third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-promise-reject-and-handle-expected.txt

@@ -4,8 +4,14 @@ Tests that evt.preventDefault() in window.onunhandledrejection suppresses consol
 console-promise-reject-and-handle.html:8 onunhandledrejection1
 console-promise-reje…-and-handle.html:15 onrejectionhandled1
 console-promise-reje…-and-handle.html:24 onunhandledrejection2
+console-promise-reje…-and-handle.html:30 onrejectionhandled2
+----console messages end----
+
+Enable verbose filter
+console-promise-reject-and-handle.html:8 onunhandledrejection1
+console-promise-reje…-and-handle.html:15 onrejectionhandled1
+console-promise-reje…-and-handle.html:24 onunhandledrejection2
 console-promise-reje…-and-handle.html:22 Uncaught (in promise) Error: e
     at setupPromise2 (console-promise-reje…-and-handle.html:22)
 console-promise-reje…-and-handle.html:30 onrejectionhandled2
-----console messages end----
 

third_party/WebKit/LayoutTests/http/tests/devtools/startup/console-promise-reject-and-handle.js

@@ -6,10 +6,17 @@
   await TestRunner.setupStartupTest('resources/console-promise-reject-and-handle.html');
   TestRunner.addResult(`Tests that evt.preventDefault() in window.onunhandledrejection suppresses console output.\n`);
   await TestRunner.loadModule('console_test_runner');
+  Console.ConsoleView.instance()._setImmediatelyFilterMessagesForTest();
 
   ConsoleTestRunner.expandConsoleMessages();
   TestRunner.addResult('----console messages start----');
   ConsoleTestRunner.dumpConsoleMessages();
   TestRunner.addResult('----console messages end----');
+
+  // Turn on verbose filter.
+  TestRunner.addResult(`\nEnable verbose filter`);
+  Console.ConsoleViewFilter.levelFilterSetting().set(Console.ConsoleFilter.allLevelsFilterValue());
+  ConsoleTestRunner.dumpConsoleMessages();
+
   TestRunner.completeTest();
 })();

third_party/blink/renderer/devtools/front_end/console/ConsoleView.js

@@ -548,6 +548,7 @@ Console.ConsoleView = class extends UI.VBox {
     const viewMessage = message[this._viewMessageSymbol];
     if (viewMessage) {
       viewMessage.updateMessageElement();
+      this._computeShouldMessageBeVisible(viewMessage);
       this._updateMessageList();
     }
   }

third_party/blink/renderer/devtools/front_end/sdk/ConsoleModel.js

@@ -203,7 +203,7 @@ SDK.ConsoleModel = class extends Common.Object {
     if (!exceptionMessage)
       return;
     this._errors--;
-    exceptionMessage.level = SDK.ConsoleMessage.MessageLevel.Info;
+    exceptionMessage.level = SDK.ConsoleMessage.MessageLevel.Verbose;
     this.dispatchEventToListeners(SDK.ConsoleModel.Events.MessageUpdated, exceptionMessage);
   }