Commit 5fe3e1a2 authored by msw@chromium.org's avatar msw@chromium.org

Fix Windows XP and Vista taskbar activation issue.

On Windows XP and Vista, new windows don't indicate activation on the taskbar.
(the window buttons should look "pressed" on launch and new window)
This regression was introduced by http://crrev.com/104051

Limit the original fix for http://crbug.com/90386 to Windows > Vista.

BUG=90386,123473
TEST=New Chrome window appear "pressed" on the taskbar on Vista and XP. No regressions (especially not of crbug.com/90386)

Review URL: https://chromiumcodereview.appspot.com/10826058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149215 0039d316-1c4b-4281-b951-d872f2087c98
parent aab50a49
...@@ -1712,8 +1712,10 @@ LRESULT NativeWidgetWin::OnNCActivate(BOOL active) { ...@@ -1712,8 +1712,10 @@ LRESULT NativeWidgetWin::OnNCActivate(BOOL active) {
if (IsActive()) if (IsActive())
delegate_->EnableInactiveRendering(); delegate_->EnableInactiveRendering();
// Avoid DefWindowProc non-client rendering over our custom frame. // Avoid DefWindowProc non-client rendering over our custom frame on newer
if (!GetWidget()->ShouldUseNativeFrame()) { // Windows versions only (breaks taskbar activation indication on XP/Vista).
if (!GetWidget()->ShouldUseNativeFrame() &&
base::win::GetVersion() > base::win::VERSION_VISTA) {
SetMsgHandled(TRUE); SetMsgHandled(TRUE);
return TRUE; return TRUE;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment