Plugin VM installer UI to accommodate DLC Failures - Phase 2

Display to the users specific actions to take when PluginVM DLC runs
into errors.

BUG=chromium:1041311
TEST=./out/Default/unit_tests --gtest_filter=PluginVm*

Change-Id: Ib0a649f79dc07e15f38d0d950f9574442109c4d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063731
Commit-Queue: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Julian Watson <juwa@google.com>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745733}

chrome/app/chromeos_strings.grdp

@@ -4274,7 +4274,7 @@
     Couldn't install the virtual machine. Please try again, or contact your organization's device administrator. Error code: <ph name="ERROR_CODE">$1<ex>7</ex></ph>.
   </message>
   <message name="IDS_PLUGIN_VM_INSTALLER_NOT_ALLOWED_MESSAGE" desc="Error message to be shown if a setup/launch is attempted although Plugin VM is disallowed.">
-    Plugin VM isn't allowed on this device. Contact your organization's device administrator.
+    Plugin VM isn't allowed on this device. Contact your organization's device administrator. Error code: <ph name="ERROR_CODE">$1<ex>7</ex></ph>.
   </message>
   <message name="IDS_PLUGIN_VM_INSTALLER_DOWNLOAD_PROGRESS_MESSAGE" desc="Text of the Plugin VM installer during downloading Plugin VM image, showing download progress.">
     <ph name="DOWNLOADED_SIZE">$1<ex>1.2</ex></ph>/<ph name="DOWNLOAD_SIZE">$2<ex>3.4 GB</ex></ph>
@@ -4309,6 +4309,18 @@
   <message name="IDS_PLUGIN_VM_REMOVING_NOTIFICATION_FAILED_MESSAGE" desc="Message in the notification shown when removing the 'Plugin VM' app failed.">
     Couldn't uninstall Plugin VM
   </message>
+  <message name="IDS_PLUGIN_VM_DLC_INTERNAL_FAILED_MESSAGE" desc="Error message shown if Plugin VM installation fails because an internal error indicates the device needs to be updated.">
+    Your device needs to be updated before you can use Plugin VM.
+  </message>
+  <message name="IDS_PLUGIN_VM_DLC_BUSY_FAILED_MESSAGE" desc="Error message shown if Plugin VM installation fails because dlcservice and update_engine are busy.">
+    Something went wrong. Please wait a few minutes and run Plugin VM again.
+  </message>
+  <message name="IDS_PLUGIN_VM_DLC_NEED_REBOOT_FAILED_MESSAGE" desc="Error message shown if Plugin VM installation fails because a pending update requires the device to be restarted.">
+    Please restart your device to use Plugin VM.
+  </message>
+  <message name="IDS_PLUGIN_VM_DLC_NEED_SPACE_FAILED_MESSAGE" desc="Error message shown if Plugin VM installation fails because there is not enough free space on the device.">
+    Your device is low on storage space. Please free up space to use Plugin VM.
+  </message>
 
   <!-- Strings for Account Manager error screen -->
   <message name="IDS_ACCOUNT_MANAGER_SECONDARY_ACCOUNTS_DISABLED_TITLE" desc="Title for the Chrome OS Account Manager error screen when addition of secondary Google Accounts is disabled.">

chrome/app/chromeos_strings_grdp/IDS_PLUGIN_VM_DLC_BUSY_FAILED_MESSAGE.png.sha1

+791a00410763595c111806e6e55d051e684325c8
\ No newline at end of file

chrome/app/chromeos_strings_grdp/IDS_PLUGIN_VM_DLC_INTERNAL_FAILED_MESSAGE.png.sha1

+f0ec9081a558a1e820565ebeab7f06fcc7c18fea
\ No newline at end of file

chrome/app/chromeos_strings_grdp/IDS_PLUGIN_VM_DLC_NEED_REBOOT_FAILED_MESSAGE.png.sha1

+6db80c623be35908c38d1c91c3b8a47d0380f3a0
\ No newline at end of file

chrome/app/chromeos_strings_grdp/IDS_PLUGIN_VM_DLC_NEED_SPACE_FAILED_MESSAGE.png.sha1

+ab2aaafa34246f7a3c88c095348306050c987c4e
\ No newline at end of file

chrome/app/chromeos_strings_grdp/IDS_PLUGIN_VM_INSTALLER_NOT_ALLOWED_MESSAGE.png.sha1

-c2812c4f692dc0568d1353b5c4c58eced1b4a5ce
+972e7c0020f0ed930ca4707875f23f9675400862
\ No newline at end of file

chrome/browser/chromeos/plugin_vm/plugin_vm_installer.cc

@@ -190,38 +190,45 @@ void PluginVmInstaller::OnDlcDownloadCompleted(
   }
   DCHECK_EQ(state_, State::DOWNLOADING_DLC);
 
-  if (err == dlcservice::kErrorInvalidDlc) {
-    LOG(ERROR) << "PluginVM DLC is not supported, need to enable PluginVM DLC.";
-    state_ = State::DOWNLOAD_DLC_FAILED;
+  // If success, continue to the next state.
+  if (err == dlcservice::kErrorNone) {
+    RecordPluginVmDlcUseResultHistogram(PluginVmDlcUseResult::kDlcSuccess);
     if (observer_)
-      observer_->OnDownloadFailed(FailureReason::DLC_DOWNLOAD_FAILED);
-    RecordPluginVmDlcUseResultHistogram(
-        PluginVmDlcUseResult::kFallbackToRootFsInvalidDlcError);
+      observer_->OnDlcDownloadCompleted();
+    StartDownload();
     return;
   }
 
-  if (err != dlcservice::kErrorNone) {
-    // TODO(b/148470849): Remove this log once PluginVM is converted to DLC and
-    // invoke |OnDownloadFailed()|. The temporary passthrough is safe as
-    // PluginVM will be rootfs resident as a fallback.
-    LOG(ERROR) << "PluginVM DLC installation failed, falling back to rootfs "
-                  "resident PluginVM. Reason being dlcservice error: "
-               << err;
-    PluginVmDlcUseResult dlc_use_result =
-        PluginVmDlcUseResult::kFallbackToRootFsInternalDlcError;
-    if (err == dlcservice::kErrorBusy)
-      dlc_use_result = PluginVmDlcUseResult::kFallbackToRootFsBusyDlcError;
-    else if (err == dlcservice::kErrorNeedReboot)
-      dlc_use_result =
-          PluginVmDlcUseResult::kFallbackToRootFsNeedRebootDlcError;
-    RecordPluginVmDlcUseResultHistogram(dlc_use_result);
+  // At this point, PluginVM DLC download failed.
+  state_ = State::DOWNLOAD_DLC_FAILED;
+  PluginVmDlcUseResult result = PluginVmDlcUseResult::kInternalDlcError;
+  FailureReason reason = FailureReason::DLC_INTERNAL;
+
+  if (err == dlcservice::kErrorInvalidDlc) {
+    LOG(ERROR) << "PluginVM DLC is not supported, need to enable PluginVM DLC.";
+    result = PluginVmDlcUseResult::kInvalidDlcError;
+    reason = FailureReason::DLC_UNSUPPORTED;
+  } else if (err == dlcservice::kErrorBusy) {
+    LOG(ERROR)
+        << "PluginVM DLC is not able to be downloaded as dlcservice is busy.";
+    result = PluginVmDlcUseResult::kBusyDlcError;
+    reason = FailureReason::DLC_BUSY;
+  } else if (err == dlcservice::kErrorNeedReboot) {
+    LOG(ERROR)
+        << "Device has pending update and needs a reboot to use PluginVM DLC.";
+    result = PluginVmDlcUseResult::kNeedRebootDlcError;
+    reason = FailureReason::DLC_NEED_REBOOT;
+  } else if (err == dlcservice::kErrorAllocation) {
+    LOG(ERROR) << "Device needs to free space to use PluginVM DLC.";
+    result = PluginVmDlcUseResult::kNeedSpaceDlcError;
+    reason = FailureReason::DLC_NEED_SPACE;
   } else {
-    RecordPluginVmDlcUseResultHistogram(PluginVmDlcUseResult::kDlcSuccess);
+    LOG(ERROR) << "Failed to download PluginVM DLC: " << err;
   }
 
+  RecordPluginVmDlcUseResultHistogram(result);
   if (observer_)
-    observer_->OnDlcDownloadCompleted();
-  StartDownload();
+    observer_->OnDownloadFailed(reason);
 }
 
 void PluginVmInstaller::OnDownloadStarted() {

chrome/browser/chromeos/plugin_vm/plugin_vm_installer.h

@@ -58,8 +58,13 @@ class PluginVmInstaller : public KeyedService,
     COULD_NOT_OPEN_IMAGE = 13,
     INVALID_IMPORT_RESPONSE = 14,
     IMAGE_IMPORT_FAILED = 15,
-    DLC_DOWNLOAD_FAILED = 16,
+    // DLC_DOWNLOAD_FAILED = 16,
     // DLC_DOWNLOAD_NOT_STARTED = 17,
+    DLC_INTERNAL = 18,
+    DLC_UNSUPPORTED = 19,
+    DLC_BUSY = 20,
+    DLC_NEED_REBOOT = 21,
+    DLC_NEED_SPACE = 22,
   };
 
   // Observer class for the PluginVm image related events.

chrome/browser/chromeos/plugin_vm/plugin_vm_installer_unittest.cc

@@ -49,6 +49,7 @@ namespace {
 using ::testing::_;
 using ::testing::AtLeast;
 using ::testing::Invoke;
+using ::testing::StrictMock;
 
 const char kProfileName[] = "p1";
 const char kUrl[] = "http://example.com";
@@ -165,7 +166,7 @@ class PluginVmInstallerTestBase : public testing::Test {
 
     fake_downloaded_plugin_vm_image_archive_ = CreateZipFile();
     installer_ = PluginVmInstallerFactory::GetForProfile(profile_.get());
-    observer_ = std::make_unique<MockObserver>();
+    observer_ = std::make_unique<StrictMock<MockObserver>>();
     installer_->SetObserver(observer_.get());
 
     // These actions are required to make the RunUntil* functions work, so tests
@@ -391,7 +392,6 @@ TEST_F(PluginVmInstallerDownloadServiceTest, VmExists) {
       ->set_list_vms_response(list_vms_response);
 
   EXPECT_CALL(*observer_, OnVmExists());
-  EXPECT_CALL(*observer_, OnDlcDownloadCompleted()).Times(0);
   StartAndRunToCompletion();
 }
 
@@ -445,6 +445,7 @@ TEST_F(PluginVmInstallerDownloadServiceTest,
        CanProceedWithANewImageWhenSucceededTest) {
   SetupConciergeForSuccessfulDiskImageImport(fake_concierge_client_);
 
+  EXPECT_CALL(*observer_, OnDlcDownloadCompleted()).Times(2);
   EXPECT_CALL(*observer_, OnDownloadCompleted()).Times(2);
   EXPECT_CALL(*observer_, OnImportProgressUpdated(50.0, _)).Times(2);
   EXPECT_CALL(*observer_, OnImported()).Times(2);
@@ -487,8 +488,7 @@ TEST_F(PluginVmInstallerDownloadServiceTest,
 }
 
 TEST_F(PluginVmInstallerDownloadServiceTest, CancelledDownloadTest) {
-  EXPECT_CALL(*observer_, OnDownloadCompleted()).Times(0);
-  EXPECT_CALL(*observer_, OnDownloadFailed(_)).Times(0);
+  EXPECT_CALL(*observer_, OnDlcDownloadCompleted());
   EXPECT_CALL(*observer_, OnDownloadCancelled());
 
   StartAndRunUntilDownloading();
@@ -503,6 +503,7 @@ TEST_F(PluginVmInstallerDownloadServiceTest, CancelledDownloadTest) {
 TEST_F(PluginVmInstallerDownloadServiceTest, ImportNonExistingImageTest) {
   SetupConciergeForSuccessfulDiskImageImport(fake_concierge_client_);
 
+  EXPECT_CALL(*observer_, OnDlcDownloadCompleted());
   EXPECT_CALL(*observer_, OnDownloadCompleted());
   EXPECT_CALL(
       *observer_,
@@ -520,9 +521,8 @@ TEST_F(PluginVmInstallerDownloadServiceTest, CancelledImportTest) {
   SetupConciergeForCancelDiskImageOperation(fake_concierge_client_,
                                             true /* success */);
 
+  EXPECT_CALL(*observer_, OnDlcDownloadCompleted());
   EXPECT_CALL(*observer_, OnDownloadCompleted());
-  EXPECT_CALL(*observer_, OnImported()).Times(0);
-  EXPECT_CALL(*observer_, OnImportFailed(_)).Times(0);
   EXPECT_CALL(*observer_, OnImportCancelled());
 
   StartAndRunUntilImporting();
@@ -535,7 +535,6 @@ TEST_F(PluginVmInstallerDownloadServiceTest, EmptyPluginVmImageUrlTest) {
   EXPECT_CALL(
       *observer_,
       OnDownloadFailed(PluginVmInstaller::FailureReason::INVALID_IMAGE_URL));
-  EXPECT_CALL(*observer_, OnDlcDownloadCompleted()).Times(0);
   StartAndRunToCompletion();
 
   histogram_tester_->ExpectTotalCount(kPluginVmImageDownloadedSizeHistogram, 0);
@@ -553,7 +552,6 @@ TEST_F(PluginVmInstallerDownloadServiceTest, CannotStartIfPluginVmIsDisabled) {
       chromeos::kPluginVmAllowed, false);
   EXPECT_CALL(*observer_,
               OnDownloadFailed(PluginVmInstaller::FailureReason::NOT_ALLOWED));
-  EXPECT_CALL(*observer_, OnDlcDownloadCompleted()).Times(0);
   installer_->Start();
   task_environment_.RunUntilIdle();
 }
@@ -583,6 +581,7 @@ TEST_F(PluginVmInstallerDriveTest, WrongHashDriveTest) {
   SetPluginVmImagePref(kDriveUrl, kHash2);
 
   EXPECT_CALL(*observer_, OnDlcDownloadCompleted());
+  EXPECT_CALL(*observer_, OnDownloadProgressUpdated(_, _, _)).Times(2);
   EXPECT_CALL(*observer_, OnDownloadFailed(
                               PluginVmInstaller::FailureReason::HASH_MISMATCH));
 
@@ -599,7 +598,6 @@ TEST_F(PluginVmInstallerDriveTest, DriveDownloadFailedAfterStartingTest) {
   EXPECT_CALL(*observer_,
               OnDownloadFailed(
                   PluginVmInstaller::FailureReason::DOWNLOAD_FAILED_NETWORK));
-  EXPECT_CALL(*observer_, OnDownloadCompleted()).Times(0);
 
   StartAndRunToCompletion();
 
@@ -619,7 +617,6 @@ TEST_F(PluginVmInstallerDriveTest, CancelledDriveDownloadTest) {
 
   EXPECT_CALL(*observer_, OnDlcDownloadCompleted());
   EXPECT_CALL(*observer_, OnDownloadProgressUpdated(5, 100, _));
-  EXPECT_CALL(*observer_, OnDownloadCompleted()).Times(0);
 
   StartAndRunToCompletion();
 
@@ -640,71 +637,70 @@ TEST_F(PluginVmInstallerDriveTest, SuccessfulDriveDownloadTest) {
   EXPECT_CALL(*observer_,
               OnDownloadProgressUpdated(_, std::strlen(kContent), _))
       .Times(AtLeast(1));
+  EXPECT_CALL(*observer_, OnImportFailed(_));
 
   StartAndRunToCompletion();
   histogram_tester_->ExpectUniqueSample(kPluginVmDlcUseResultHistogram,
                                         PluginVmDlcUseResult::kDlcSuccess, 1);
 }
 
-// TODO(b/148470849): Modify test to block once PluginVM DLC is stable and
-// rootfs PluginVM is no longer resident.
-TEST_F(PluginVmInstallerDriveTest,
-       InstallingPluingVmDlcInternalFailureAllowsPassthrough) {
+TEST_F(PluginVmInstallerDriveTest, InstallingPluingVmDlcInternal) {
   SetPluginVmImagePref(kDriveUrl, kHash);
   fake_dlcservice_client_->SetInstallError(dlcservice::kErrorInternal);
 
-  EXPECT_CALL(*observer_, OnDlcDownloadCompleted());
-  EXPECT_CALL(*observer_, OnDownloadCompleted());
+  EXPECT_CALL(*observer_, OnDownloadFailed(_)).Times(1);
 
   StartAndRunToCompletion();
-  histogram_tester_->ExpectUniqueSample(
-      kPluginVmDlcUseResultHistogram,
-      PluginVmDlcUseResult::kFallbackToRootFsInternalDlcError, 1);
+  histogram_tester_->ExpectUniqueSample(kPluginVmDlcUseResultHistogram,
+                                        PluginVmDlcUseResult::kInternalDlcError,
+                                        1);
 }
 
-// TODO(b/148470849): Modify test to block once PluginVM DLC is stable and
-// rootfs PluginVM is no longer resident.
-TEST_F(PluginVmInstallerDriveTest,
-       InstallingPluingVmDlcBusyFailureAllowsPassthrough) {
+TEST_F(PluginVmInstallerDriveTest, InstallingPluingVmDlcBusy) {
   SetPluginVmImagePref(kDriveUrl, kHash);
   fake_dlcservice_client_->SetInstallError(dlcservice::kErrorBusy);
 
-  EXPECT_CALL(*observer_, OnDlcDownloadCompleted());
-  EXPECT_CALL(*observer_, OnDownloadCompleted());
+  EXPECT_CALL(*observer_, OnDownloadFailed(_)).Times(1);
 
   StartAndRunToCompletion();
-  histogram_tester_->ExpectUniqueSample(
-      kPluginVmDlcUseResultHistogram,
-      PluginVmDlcUseResult::kFallbackToRootFsBusyDlcError, 1);
+  histogram_tester_->ExpectUniqueSample(kPluginVmDlcUseResultHistogram,
+                                        PluginVmDlcUseResult::kBusyDlcError, 1);
 }
 
-// TODO(b/148470849): Modify test to block once PluginVM DLC is stable and
-// rootfs PluginVM is no longer resident.
-TEST_F(PluginVmInstallerDriveTest,
-       InstallingPluingVmDlcNeedRebootFailureAllowsPassthrough) {
+TEST_F(PluginVmInstallerDriveTest, InstallingPluginVmDlcNeedReboot) {
   SetPluginVmImagePref(kDriveUrl, kHash);
   fake_dlcservice_client_->SetInstallError(dlcservice::kErrorNeedReboot);
 
-  EXPECT_CALL(*observer_, OnDlcDownloadCompleted());
-  EXPECT_CALL(*observer_, OnDownloadCompleted());
+  EXPECT_CALL(*observer_, OnDownloadFailed(_)).Times(1);
 
   StartAndRunToCompletion();
   histogram_tester_->ExpectUniqueSample(
-      kPluginVmDlcUseResultHistogram,
-      PluginVmDlcUseResult::kFallbackToRootFsNeedRebootDlcError, 1);
+      kPluginVmDlcUseResultHistogram, PluginVmDlcUseResult::kNeedRebootDlcError,
+      1);
+}
+
+TEST_F(PluginVmInstallerDriveTest, InstallingPluginVmDlcNeedSpace) {
+  SetPluginVmImagePref(kDriveUrl, kHash);
+  fake_dlcservice_client_->SetInstallError(dlcservice::kErrorAllocation);
+
+  EXPECT_CALL(*observer_, OnDownloadFailed(_)).Times(1);
+
+  StartAndRunToCompletion();
+  histogram_tester_->ExpectUniqueSample(
+      kPluginVmDlcUseResultHistogram, PluginVmDlcUseResult::kNeedSpaceDlcError,
+      1);
 }
 
 TEST_F(PluginVmInstallerDriveTest, InstallingPluginVmDlcWhenUnsupported) {
   SetPluginVmImagePref(kDriveUrl, kHash);
   fake_dlcservice_client_->SetInstallError(dlcservice::kErrorInvalidDlc);
 
-  EXPECT_CALL(*observer_, OnDlcDownloadCompleted()).Times(0);
   EXPECT_CALL(*observer_, OnDownloadFailed(_)).Times(1);
 
   StartAndRunToCompletion();
-  histogram_tester_->ExpectUniqueSample(
-      kPluginVmDlcUseResultHistogram,
-      PluginVmDlcUseResult::kFallbackToRootFsInvalidDlcError, 1);
+  histogram_tester_->ExpectUniqueSample(kPluginVmDlcUseResultHistogram,
+                                        PluginVmDlcUseResult::kInvalidDlcError,
+                                        1);
 }
 
 }  // namespace plugin_vm

chrome/browser/chromeos/plugin_vm/plugin_vm_metrics_util.h

@@ -51,11 +51,12 @@ enum class PluginVmSetupResult {
 
 enum class PluginVmDlcUseResult {
   kDlcSuccess = 0,
-  kFallbackToRootFsInvalidDlcError = 1,
-  kFallbackToRootFsInternalDlcError = 2,
-  kFallbackToRootFsBusyDlcError = 3,
-  kFallbackToRootFsNeedRebootDlcError = 4,
-  kMaxValue = kFallbackToRootFsNeedRebootDlcError,
+  kInvalidDlcError = 1,
+  kInternalDlcError = 2,
+  kBusyDlcError = 3,
+  kNeedRebootDlcError = 4,
+  kNeedSpaceDlcError = 5,
+  kMaxValue = kNeedSpaceDlcError,
 };
 
 void RecordPluginVmImageDownloadedSizeHistogram(uint64_t bytes_downloaded);

chrome/browser/ui/views/plugin_vm/plugin_vm_installer_view.cc

@@ -395,8 +395,11 @@ base::string16 PluginVmInstallerView::GetMessage() const {
               base::NumberToString16(
                   static_cast<std::underlying_type_t<Reason>>(*reason_)));
         case Reason::NOT_ALLOWED:
-          return l10n_util::GetStringUTF16(
-              IDS_PLUGIN_VM_INSTALLER_NOT_ALLOWED_MESSAGE);
+        case Reason::DLC_UNSUPPORTED:
+          return l10n_util::GetStringFUTF16(
+              IDS_PLUGIN_VM_INSTALLER_NOT_ALLOWED_MESSAGE,
+              base::NumberToString16(
+                  static_cast<std::underlying_type_t<Reason>>(*reason_)));
         case Reason::INVALID_IMAGE_URL:
         case Reason::HASH_MISMATCH:
           return l10n_util::GetStringFUTF16(
@@ -417,6 +420,19 @@ base::string16 PluginVmInstallerView::GetMessage() const {
               IDS_PLUGIN_VM_INSTALLER_ERROR_MESSAGE_INSTALLING_FAILED,
               base::NumberToString16(
                   static_cast<std::underlying_type_t<Reason>>(*reason_)));
+        // DLC Failure Reasons.
+        case Reason::DLC_INTERNAL:
+          return l10n_util::GetStringUTF16(
+              IDS_PLUGIN_VM_DLC_INTERNAL_FAILED_MESSAGE);
+        case Reason::DLC_BUSY:
+          return l10n_util::GetStringUTF16(
+              IDS_PLUGIN_VM_DLC_BUSY_FAILED_MESSAGE);
+        case Reason::DLC_NEED_REBOOT:
+          return l10n_util::GetStringUTF16(
+              IDS_PLUGIN_VM_DLC_NEED_REBOOT_FAILED_MESSAGE);
+        case Reason::DLC_NEED_SPACE:
+          return l10n_util::GetStringUTF16(
+              IDS_PLUGIN_VM_DLC_NEED_SPACE_FAILED_MESSAGE);
       }
   }
 }

chrome/browser/ui/views/plugin_vm/plugin_vm_installer_view_browsertest.cc

@@ -92,7 +92,8 @@ class PluginVmInstallerViewBrowserTest : public DialogBrowserTest {
     plugin_vm_image->SetKey("hash", base::Value(hash));
   }
 
-  void CheckSetupNotAllowed() {
+  void CheckSetupNotAllowed(
+      plugin_vm::PluginVmInstaller::FailureReason reason) {
     EXPECT_FALSE(HasAcceptButton());
     EXPECT_TRUE(HasCancelButton());
     EXPECT_EQ(
@@ -100,7 +101,11 @@ class PluginVmInstallerViewBrowserTest : public DialogBrowserTest {
         l10n_util::GetStringUTF16(IDS_PLUGIN_VM_INSTALLER_NOT_ALLOWED_TITLE));
     EXPECT_EQ(
         view_->GetMessage(),
-        l10n_util::GetStringUTF16(IDS_PLUGIN_VM_INSTALLER_NOT_ALLOWED_MESSAGE));
+        l10n_util::GetStringFUTF16(
+            IDS_PLUGIN_VM_INSTALLER_NOT_ALLOWED_MESSAGE,
+            base::NumberToString16(
+                static_cast<std::underlying_type_t<
+                    plugin_vm::PluginVmInstaller::FailureReason>>(reason))));
   }
 
   void WaitForSetupToFinish() {
@@ -284,7 +289,8 @@ IN_PROC_BROWSER_TEST_F(
 
   // We do not have to wait for setup to finish since the NOT_ALLOWED state
   // is set during dialogue construction.
-  CheckSetupNotAllowed();
+  CheckSetupNotAllowed(
+      plugin_vm::PluginVmInstaller::FailureReason::NOT_ALLOWED);
 
   histogram_tester_->ExpectUniqueSample(
       plugin_vm::kPluginVmSetupResultHistogram,