Commit 5fef627c authored by Yunke Zhou's avatar Yunke Zhou Committed by Commit Bot

Oobe: fix failing OobeZeroTouchInteractiveUITest tests

Bug: 1135512
Change-Id: I96d28c6817b8661e9a201d759ee6d6ef620cb1f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455749Reviewed-by: default avatarDenis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Yunke Zhou <yunkez@google.com>
Cr-Commit-Position: refs/heads/master@{#814723}
parent 2578b6b2
...@@ -352,11 +352,11 @@ void HandleAssistantOptInScreen() { ...@@ -352,11 +352,11 @@ void HandleAssistantOptInScreen() {
EXPECT_FALSE(ash::LoginScreenTestApi::IsAddUserButtonShown()); EXPECT_FALSE(ash::LoginScreenTestApi::IsAddUserButtonShown());
test::OobeJS() test::OobeJS()
.CreateVisibilityWaiter(true, {"assistant-optin-flow-card", "loading"}) .CreateVisibilityWaiter(true, {"assistant-optin-flow", "card", "loading"})
->Wait(); ->Wait();
std::initializer_list<base::StringPiece> skip_button_path = { std::initializer_list<base::StringPiece> skip_button_path = {
"assistant-optin-flow-card", "loading", "skip-button"}; "assistant-optin-flow", "card", "loading", "skip-button"};
test::OobeJS().CreateEnabledWaiter(true, skip_button_path)->Wait(); test::OobeJS().CreateEnabledWaiter(true, skip_button_path)->Wait();
test::OobeJS().TapOnPath(skip_button_path); test::OobeJS().TapOnPath(skip_button_path);
...@@ -794,15 +794,12 @@ void OobeInteractiveUITest::SimpleEndToEnd() { ...@@ -794,15 +794,12 @@ void OobeInteractiveUITest::SimpleEndToEnd() {
} }
// Disabled on *San bots since they time out. // Disabled on *San bots since they time out.
//#if defined(MEMORY_SANITIZER) || defined(ADDRESS_SANITIZER) || \ #if defined(MEMORY_SANITIZER) || defined(ADDRESS_SANITIZER) || \
// defined(LEAK_SANITIZER) defined(LEAK_SANITIZER)
//#define MAYBE_SimpleEndToEnd DISABLED_SimpleEndToEnd #define MAYBE_SimpleEndToEnd DISABLED_SimpleEndToEnd
//#else #else
//#define MAYBE_SimpleEndToEnd SimpleEndToEnd #define MAYBE_SimpleEndToEnd SimpleEndToEnd
//#endif #endif
// crbug.com/1135512: Fails on linux-chromeos-chrome, uncomment above section
// once this bug is fixed.
// Note that this probably the largest test that is run on ChromeOS, and it // Note that this probably the largest test that is run on ChromeOS, and it
// might be running close to time limits especially on instrumented builds. // might be running close to time limits especially on instrumented builds.
...@@ -810,7 +807,7 @@ void OobeInteractiveUITest::SimpleEndToEnd() { ...@@ -810,7 +807,7 @@ void OobeInteractiveUITest::SimpleEndToEnd() {
// Please do not disable it for whole ChromeOS, only for specific instrumented // Please do not disable it for whole ChromeOS, only for specific instrumented
// bots. Another alternative is to increase respective multiplier in // bots. Another alternative is to increase respective multiplier in
// base/test/test_timeouts.h. // base/test/test_timeouts.h.
IN_PROC_BROWSER_TEST_P(OobeInteractiveUITest, DISABLED_SimpleEndToEnd) { IN_PROC_BROWSER_TEST_P(OobeInteractiveUITest, SimpleEndToEnd) {
SimpleEndToEnd(); SimpleEndToEnd();
} }
...@@ -875,15 +872,12 @@ void OobeZeroTouchInteractiveUITest::ZeroTouchEndToEnd() { ...@@ -875,15 +872,12 @@ void OobeZeroTouchInteractiveUITest::ZeroTouchEndToEnd() {
// crbug.com/997987. Disabled on MSAN since they time out. // crbug.com/997987. Disabled on MSAN since they time out.
// crbug.com/1055853: EndToEnd is flaky on Linux Chromium OS ASan LSan // crbug.com/1055853: EndToEnd is flaky on Linux Chromium OS ASan LSan
//#if defined(MEMORY_SANITIZER) || defined(ADDRESS_SANITIZER) || \ #if defined(MEMORY_SANITIZER) || defined(ADDRESS_SANITIZER) || \
// defined(LEAK_SANITIZER) defined(LEAK_SANITIZER)
//#define MAYBE_EndToEnd DISABLED_EndToEnd #define MAYBE_EndToEnd DISABLED_EndToEnd
//#else #else
//#define MAYBE_EndToEnd EndToEnd #define MAYBE_EndToEnd EndToEnd
//#endif #endif
// crbug.com/1135512: Fails on linux-chromeos-chrome, uncomment above section
// once this bug is fixed.
// Note that this probably the largest test that is run on ChromeOS, and it // Note that this probably the largest test that is run on ChromeOS, and it
// might be running close to time limits especially on instrumented builds. // might be running close to time limits especially on instrumented builds.
...@@ -891,7 +885,7 @@ void OobeZeroTouchInteractiveUITest::ZeroTouchEndToEnd() { ...@@ -891,7 +885,7 @@ void OobeZeroTouchInteractiveUITest::ZeroTouchEndToEnd() {
// Please do not disable it for whole ChromeOS, only for specific instrumented // Please do not disable it for whole ChromeOS, only for specific instrumented
// bots. Another alternative is to increase respective multiplier in // bots. Another alternative is to increase respective multiplier in
// base/test/test_timeouts.h. // base/test/test_timeouts.h.
IN_PROC_BROWSER_TEST_P(OobeZeroTouchInteractiveUITest, DISABLED_EndToEnd) { IN_PROC_BROWSER_TEST_P(OobeZeroTouchInteractiveUITest, EndToEnd) {
ZeroTouchEndToEnd(); ZeroTouchEndToEnd();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment