Commit 601c5f93 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Remove set_sources_assignment_filter from //components/autofill

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: Iba8ac41c84bf091bbf8c87a5d129364f1e38d76a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409938
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: default avatarParastoo Geranmayeh <parastoog@google.com>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807073}
parent e32dbaa4
...@@ -7,6 +7,12 @@ import("//build/util/version.gni") ...@@ -7,6 +7,12 @@ import("//build/util/version.gni")
import("//testing/libfuzzer/fuzzer_test.gni") import("//testing/libfuzzer/fuzzer_test.gni")
import("//tools/grit/grit_rule.gni") import("//tools/grit/grit_rule.gni")
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
grit("autofill_address_rewriter_resources") { grit("autofill_address_rewriter_resources") {
source = "autofill_address_rewriter_resources.grd" source = "autofill_address_rewriter_resources.grd"
outputs = [ outputs = [
...@@ -56,8 +62,6 @@ static_library("browser") { ...@@ -56,8 +62,6 @@ static_library("browser") {
"autofill_handler.h", "autofill_handler.h",
"autofill_handler_proxy.cc", "autofill_handler_proxy.cc",
"autofill_handler_proxy.h", "autofill_handler_proxy.h",
"autofill_ie_toolbar_import_win.cc",
"autofill_ie_toolbar_import_win.h",
"autofill_manager.cc", "autofill_manager.cc",
"autofill_manager.h", "autofill_manager.h",
"autofill_manager_test_delegate.h", "autofill_manager_test_delegate.h",
...@@ -300,6 +304,13 @@ static_library("browser") { ...@@ -300,6 +304,13 @@ static_library("browser") {
"webdata/system_encryptor.h", "webdata/system_encryptor.h",
] ]
if (is_win) {
sources += [
"autofill_ie_toolbar_import_win.cc",
"autofill_ie_toolbar_import_win.h",
]
}
if (is_ios) { if (is_ios) {
sources += [ sources += [
"keyboard_accessory_metrics_logger.h", "keyboard_accessory_metrics_logger.h",
...@@ -579,7 +590,6 @@ source_set("unit_tests") { ...@@ -579,7 +590,6 @@ source_set("unit_tests") {
"autofill_driver_factory_unittest.cc", "autofill_driver_factory_unittest.cc",
"autofill_experiments_unittest.cc", "autofill_experiments_unittest.cc",
"autofill_external_delegate_unittest.cc", "autofill_external_delegate_unittest.cc",
"autofill_ie_toolbar_import_win_unittest.cc",
"autofill_manager_unittest.cc", "autofill_manager_unittest.cc",
"autofill_merge_unittest.cc", "autofill_merge_unittest.cc",
"autofill_metrics_unittest.cc", "autofill_metrics_unittest.cc",
...@@ -654,6 +664,10 @@ source_set("unit_tests") { ...@@ -654,6 +664,10 @@ source_set("unit_tests") {
"webdata/web_data_service_unittest.cc", "webdata/web_data_service_unittest.cc",
] ]
if (is_win) {
sources += [ "autofill_ie_toolbar_import_win_unittest.cc" ]
}
if (is_ios || is_android) { if (is_ios || is_android) {
sources += [ sources += [
"autofill_assistant_unittest.cc", "autofill_assistant_unittest.cc",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment