Commit 603862c5 authored by Johann's avatar Johann Committed by Commit Bot

heap mojo: add mode to color chooser receiver_

The new wrapper changed the behavior slightly during the migration. The
wrapper defines a default ContextDestroyed method. If some other cleanup
method tries to access the receiver_ it may crash. This change reverts
to the pre-migration behavior.

BUG=chromium:1049056

Change-Id: Id6e5d9fd7405b490afe13764f340dbcccc5e3210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131797Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#755316}
parent 7bb4923c
...@@ -33,6 +33,7 @@ ...@@ -33,6 +33,7 @@
#include "third_party/blink/renderer/core/html/forms/color_chooser.h" #include "third_party/blink/renderer/core/html/forms/color_chooser.h"
#include "third_party/blink/renderer/platform/heap/handle.h" #include "third_party/blink/renderer/platform/heap/handle.h"
#include "third_party/blink/renderer/platform/mojo/heap_mojo_receiver.h" #include "third_party/blink/renderer/platform/mojo/heap_mojo_receiver.h"
#include "third_party/blink/renderer/platform/mojo/heap_mojo_wrapper_mode.h"
#include "third_party/blink/renderer/platform/text/platform_locale.h" #include "third_party/blink/renderer/platform/text/platform_locale.h"
namespace blink { namespace blink {
...@@ -72,7 +73,9 @@ class CORE_EXPORT ColorChooserUIController ...@@ -72,7 +73,9 @@ class CORE_EXPORT ColorChooserUIController
private: private:
mojo::Remote<mojom::blink::ColorChooserFactory> color_chooser_factory_; mojo::Remote<mojom::blink::ColorChooserFactory> color_chooser_factory_;
HeapMojoReceiver<mojom::blink::ColorChooserClient> receiver_; HeapMojoReceiver<mojom::blink::ColorChooserClient,
HeapMojoWrapperMode::kWithoutContextObserver>
receiver_;
}; };
} // namespace blink } // namespace blink
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment