Commit 605c27d0 authored by yurys@chromium.org's avatar yurys@chromium.org

2010-01-31 Yury Semikhatsky <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Make ScriptState destructor protected since all non-empty
        ScriptStates are managed by GC. Remove obsolete constructor.

        https://bugs.webkit.org/show_bug.cgi?id=34266

        * bindings/v8/ScriptState.cpp:
        * bindings/v8/ScriptState.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@54108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 90d7d68c
2010-01-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Make ScriptState destructor protected since all non-empty
ScriptStates are managed by GC. Remove obsolete constructor.
https://bugs.webkit.org/show_bug.cgi?id=34266
* bindings/v8/ScriptState.cpp:
* bindings/v8/ScriptState.h:
2010-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
......
......@@ -42,11 +42,6 @@
namespace WebCore {
ScriptState::ScriptState(Frame*, v8::Handle<v8::Context> context)
: m_context(v8::Persistent<v8::Context>::New(context))
{
}
ScriptState::ScriptState(v8::Handle<v8::Context> context)
: m_context(v8::Persistent<v8::Context>::New(context))
{
......
......@@ -44,11 +44,6 @@ namespace WebCore {
class ScriptState : public Noncopyable {
public:
// FIXME: This destructor will become private shortly.
~ScriptState();
// FIXME: This constructor will go away shortly.
ScriptState(Frame*, v8::Handle<v8::Context>);
bool hadException() { return !m_exception.IsEmpty(); }
void setException(v8::Local<v8::Value> exception)
{
......@@ -66,6 +61,7 @@ namespace WebCore {
protected:
ScriptState() { }
~ScriptState();
private:
friend ScriptState* mainWorldScriptState(Frame*);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment