Commit 607e6500 authored by Monica Basta's avatar Monica Basta Committed by Chromium LUCI CQ

[Settings]: Rename the label that leads to the manage profile subpage.

Rename the label from 'Chrome name and picture' to 'Customize your
Chrome profile' if the spaces experiment is on.

Bug: 1147088
Change-Id: I717c4b403bdb3452b13ba170ad5a251219370a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612887Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840626}
parent 01f93289
...@@ -155,6 +155,9 @@ ...@@ -155,6 +155,9 @@
<message name="IDS_SETTINGS_PROFILE_NAME_AND_PICTURE" desc="Label of the link that takes you to the page to edit your name and picture for your chrome profile."> <message name="IDS_SETTINGS_PROFILE_NAME_AND_PICTURE" desc="Label of the link that takes you to the page to edit your name and picture for your chrome profile.">
Chromium name and picture Chromium name and picture
</message> </message>
<message name="IDS_SETTINGS_CUSTOMIZE_YOUR_CHROME_PROFILE" desc="Label of the link that takes you to the page to customize your chrome profile.">
Customize your Chromium profile
</message>
</if> </if>
<message name="IDS_SETTINGS_PEOPLE_SIGN_IN_PROMPT_SECONDARY_WITH_ACCOUNT" desc="The secondary text displayed to prompt users to enable sync for an account that is alredy present in Chromium."> <message name="IDS_SETTINGS_PEOPLE_SIGN_IN_PROMPT_SECONDARY_WITH_ACCOUNT" desc="The secondary text displayed to prompt users to enable sync for an account that is alredy present in Chromium.">
Sync and personalize Chromium across your devices Sync and personalize Chromium across your devices
......
11312f09bbd821796ac51582dba05630517708dc
\ No newline at end of file
...@@ -156,6 +156,9 @@ ...@@ -156,6 +156,9 @@
<message name="IDS_SETTINGS_PROFILE_NAME_AND_PICTURE" desc="Label of the link that takes you to the page to edit your name and picture for your chrome profile."> <message name="IDS_SETTINGS_PROFILE_NAME_AND_PICTURE" desc="Label of the link that takes you to the page to edit your name and picture for your chrome profile.">
Chrome name and picture Chrome name and picture
</message> </message>
<message name="IDS_SETTINGS_CUSTOMIZE_YOUR_CHROME_PROFILE" desc="Label of the link that takes you to the page to customize your chrome profile.">
Customize your Chrome profile
</message>
</if> </if>
<message name="IDS_SETTINGS_PEOPLE_SIGN_IN_PROMPT_SECONDARY_WITH_ACCOUNT" desc="The secondary text displayed to prompt users to enable sync for an account that is alredy present in Chrome."> <message name="IDS_SETTINGS_PEOPLE_SIGN_IN_PROMPT_SECONDARY_WITH_ACCOUNT" desc="The secondary text displayed to prompt users to enable sync for an account that is alredy present in Chrome.">
Sync and personalize Chrome across your devices Sync and personalize Chrome across your devices
......
11312f09bbd821796ac51582dba05630517708dc
\ No newline at end of file
...@@ -1202,8 +1202,6 @@ void AddPeopleStrings(content::WebUIDataSource* html_source, Profile* profile) { ...@@ -1202,8 +1202,6 @@ void AddPeopleStrings(content::WebUIDataSource* html_source, Profile* profile) {
IDS_SETTINGS_SYNC_SYNC_AND_NON_PERSONALIZED_SERVICES}, IDS_SETTINGS_SYNC_SYNC_AND_NON_PERSONALIZED_SERVICES},
#if BUILDFLAG(IS_CHROMEOS_ASH) #if BUILDFLAG(IS_CHROMEOS_ASH)
{"accountManagerSubMenuLabel", IDS_SETTINGS_ACCOUNT_MANAGER_SUBMENU_LABEL}, {"accountManagerSubMenuLabel", IDS_SETTINGS_ACCOUNT_MANAGER_SUBMENU_LABEL},
#else
{"profileNameAndPicture", IDS_SETTINGS_PROFILE_NAME_AND_PICTURE},
#endif #endif
// Manage profile strings: // Manage profile strings:
...@@ -1243,6 +1241,11 @@ void AddPeopleStrings(content::WebUIDataSource* html_source, Profile* profile) { ...@@ -1243,6 +1241,11 @@ void AddPeopleStrings(content::WebUIDataSource* html_source, Profile* profile) {
html_source->AddBoolean("profileShortcutsEnabled", html_source->AddBoolean("profileShortcutsEnabled",
ProfileShortcutManager::IsFeatureEnabled()); ProfileShortcutManager::IsFeatureEnabled());
#if !BUILDFLAG(IS_CHROMEOS_ASH) #if !BUILDFLAG(IS_CHROMEOS_ASH)
html_source->AddLocalizedString(
"profileNameAndPicture",
base::FeatureList::IsEnabled(features::kNewProfilePicker)
? IDS_SETTINGS_CUSTOMIZE_YOUR_CHROME_PROFILE
: IDS_SETTINGS_PROFILE_NAME_AND_PICTURE);
html_source->AddLocalizedString( html_source->AddLocalizedString(
"editPerson", base::FeatureList::IsEnabled(features::kNewProfilePicker) "editPerson", base::FeatureList::IsEnabled(features::kNewProfilePicker)
? IDS_SETTINGS_CUSTOMIZE_PROFILE ? IDS_SETTINGS_CUSTOMIZE_PROFILE
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment