Commit 608e364e authored by Kenichi Ishibashi's avatar Kenichi Ishibashi Committed by Commit Bot

Cleanup ServiceWorkerCacheWriter

Service worker code base no longer use net::HttpResponseInfo directly.
Update comments and remove an unused method.

Bug: N/A

Change-Id: I151b758fe0555af7c6a204e15c440a6ca2a8e038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537500Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827216}
parent 69512b1e
...@@ -65,9 +65,9 @@ class ServiceWorkerCacheWriter::ReadResponseHeadCallbackAdapter ...@@ -65,9 +65,9 @@ class ServiceWorkerCacheWriter::ReadResponseHeadCallbackAdapter
DCHECK(owner_); DCHECK(owner_);
} }
void DidReadResponseInfo(int result, void DidReadResponseHead(int result,
network::mojom::URLResponseHeadPtr response_head, network::mojom::URLResponseHeadPtr response_head,
scoped_refptr<net::IOBufferWithSize> /*metadata*/) { base::Optional<mojo_base::BigBuffer>) {
result_ = result; result_ = result;
if (!owner_) if (!owner_)
return; return;
...@@ -76,12 +76,6 @@ class ServiceWorkerCacheWriter::ReadResponseHeadCallbackAdapter ...@@ -76,12 +76,6 @@ class ServiceWorkerCacheWriter::ReadResponseHeadCallbackAdapter
owner_->AsyncDoLoop(result); owner_->AsyncDoLoop(result);
} }
void DidReadResponseHead(int result,
network::mojom::URLResponseHeadPtr response_head,
base::Optional<mojo_base::BigBuffer>) {
DidReadResponseInfo(result, std::move(response_head), nullptr);
}
void SetAsync() { async_ = true; } void SetAsync() { async_ = true; }
int result() { return result_; } int result() { return result_; }
......
...@@ -39,7 +39,7 @@ class CONTENT_EXPORT ServiceWorkerCacheWriter { ...@@ -39,7 +39,7 @@ class CONTENT_EXPORT ServiceWorkerCacheWriter {
using OnWriteCompleteCallback = base::OnceCallback<void(net::Error)>; using OnWriteCompleteCallback = base::OnceCallback<void(net::Error)>;
// This class defines the interfaces of observer that observes write // This class defines the interfaces of observer that observes write
// operations. The observer is notified when response info or data // operations. The observer is notified when response head or data
// will be written to storage. // will be written to storage.
class WriteObserver { class WriteObserver {
public: public:
...@@ -258,7 +258,7 @@ class CONTENT_EXPORT ServiceWorkerCacheWriter { ...@@ -258,7 +258,7 @@ class CONTENT_EXPORT ServiceWorkerCacheWriter {
// WriteResponseHead() operates the same as // WriteResponseHead() operates the same as
// WriteResponseHeadToResponseWriter() and WriteData() operates the same as // WriteResponseHeadToResponseWriter() and WriteData() operates the same as
// WriteDataToResponseWriter(). // WriteDataToResponseWriter().
// If observer is set, the argument |response_info| or |data| is first sent // If observer is set, the argument |response_head| or |data| is first sent
// to observer then WriteResponseHeadToResponseWriter() or // to observer then WriteResponseHeadToResponseWriter() or
// WriteDataToResponseWriter() is called. // WriteDataToResponseWriter() is called.
int WriteResponseHead(network::mojom::URLResponseHeadPtr response_head); int WriteResponseHead(network::mojom::URLResponseHeadPtr response_head);
......
...@@ -22,7 +22,7 @@ namespace content { ...@@ -22,7 +22,7 @@ namespace content {
namespace { namespace {
// A test implementation of ServiceWorkerCacheWriter::WriteObserver. // A test implementation of ServiceWorkerCacheWriter::WriteObserver.
// This observer captures the response info or data sent to the observer // This observer captures the response head or data sent to the observer
// for further checking. // for further checking.
class MockServiceWorkerCacheWriterObserver class MockServiceWorkerCacheWriterObserver
: public ServiceWorkerCacheWriter::WriteObserver { : public ServiceWorkerCacheWriter::WriteObserver {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment