[session_manager] Move user session initialization code out of ExistingUserController

Added UserSessionManager::InitializeUserSession()
(1) Launches browser for most common case
(2) Continues new user sign in with TOS (public sessions)/image screen (new users)
(3) For kiosk flow delegates launching app to the existing kiosk initialization flow

(1) Currently results in LoginUtils::Get()->DoBrowserLaunch() which may postpone launching browser for these reasons:
(a) There's custom user login flow defined like SupervisedUserCreationFlow. In that case login UI continues to live and custom flow UI is launched in that context.
(b) User has different app locale which requires reloading resource_bundle prior to launching browser
(c) User has custom flags set (or user flags are different from login screen flags defined by the owner), this requires restarting Chrome which will be launched in the active user session.

Small refactoring in ExistingUserController, added

* PerformPreLoginActions() - performs sets of actions right prior to login has been started.
* PerformLoginFinishedActions() - performs set of actions when login has been completed or has been cancelled.

BUG=370175

Review URL: https://codereview.chromium.org/656283002

Cr-Commit-Position: refs/heads/master@{#300708}

chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc

@@ -183,7 +183,8 @@ void KioskProfileLoader::OnOnlineChecked(
   NOTREACHED();
 }
 
-void KioskProfileLoader::OnProfilePrepared(Profile* profile) {
+void KioskProfileLoader::OnProfilePrepared(Profile* profile,
+                                           bool browser_launched) {
   // This object could be deleted any time after successfully reporting
   // a profile load, so invalidate the LoginUtils delegate now.
   LoginUtils::Get()->DelegateDeleted(this);

chrome/browser/chromeos/app_mode/kiosk_profile_loader.h

@@ -57,7 +57,8 @@ class KioskProfileLoader : public LoginPerformer::Delegate,
       const std::string& email, bool success) override;
 
   // LoginUtils::Delegate implementation:
-  virtual void OnProfilePrepared(Profile* profile) override;
+  virtual void OnProfilePrepared(Profile* profile,
+                                 bool browser_launched) override;
 
   std::string user_id_;
   bool use_guest_mount_;

chrome/browser/chromeos/login/existing_user_controller.h

@@ -156,20 +156,15 @@ class ExistingUserController : public LoginDisplay::Delegate,
       const std::string& username, bool success) override;
 
   // LoginUtils::Delegate implementation:
-  virtual void OnProfilePrepared(Profile* profile) override;
+  virtual void OnProfilePrepared(Profile* profile,
+                                 bool browser_launched) override;
 
   // Called when device settings change.
   void DeviceSettingsChanged();
 
-  // Starts WizardController with the specified screen.
-  void ActivateWizard(const std::string& screen_name);
-
   // Returns corresponding native window.
   gfx::NativeWindow GetNativeWindow() const;
 
-  // Adds first-time login URLs.
-  void InitializeStartUrls() const;
-
   // Show error message. |error_id| error message ID in resources.
   // If |details| string is not empty, it specify additional error text
   // provided by authenticator, it is not localized.
@@ -235,6 +230,14 @@ class ExistingUserController : public LoginDisplay::Delegate,
   // preconditions have been verified.
   void LoginAsPublicSessionInternal(const UserContext& user_context);
 
+  // Performs sets of actions right prior to login has been started.
+  void PerformPreLoginActions(const UserContext& user_context);
+
+  // Performs set of actions when login has been completed or has been
+  // cancelled. If |start_public_session_timer| is true than public session
+  // auto-login timer is started.
+  void PerformLoginFinishedActions(bool start_public_session_timer);
+
   // Public session auto-login timer.
   scoped_ptr<base::OneShotTimer<ExistingUserController> > auto_login_timer_;
 

chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

@@ -163,6 +163,9 @@ class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest {
         .WillRepeatedly(Return(false));
     EXPECT_CALL(*mock_user_manager_, Shutdown())
         .Times(1);
+    EXPECT_CALL(*mock_user_manager_, FindUser(_))
+        .Times(AnyNumber())
+        .WillRepeatedly(ReturnNull());
   }
 
   virtual void SetUpOnMainThread() override {
@@ -175,7 +178,8 @@ class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest {
     profile_prepared_cb_ =
         base::Bind(&ExistingUserController::OnProfilePrepared,
                    base::Unretained(existing_user_controller()),
-                   testing_profile_.get());
+                   testing_profile_.get(),
+                   false);
   }
 
   virtual void TearDownOnMainThread() override {
@@ -232,10 +236,8 @@ class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest {
 };
 
 IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest, ExistingUserLogin) {
-  // This is disabled twice: once right after signin but before checking for
-  // auto-enrollment, and again after doing an ownership status check.
   EXPECT_CALL(*mock_login_display_, SetUIEnabled(false))
-      .Times(2);
+      .Times(1);
   UserContext user_context(kUsername);
   user_context.SetKey(Key(kPassword));
   user_context.SetUserIDHash(kUsername);
@@ -246,10 +248,6 @@ IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest, ExistingUserLogin) {
       .Times(1)
       .WillOnce(InvokeWithoutArgs(&profile_prepared_cb_,
                                   &base::Callback<void(void)>::Run));
-  EXPECT_CALL(*mock_login_utils_,
-              DoBrowserLaunch(testing_profile_.get(),
-                              mock_login_display_host_.get()))
-      .Times(1);
   EXPECT_CALL(*mock_login_display_, SetUIEnabled(true))
       .Times(1);
   EXPECT_CALL(*mock_login_display_host_,
@@ -294,10 +292,6 @@ IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest,
               StartWizardPtr(WizardController::kEnrollmentScreenName,
                              _))
       .Times(0);
-  EXPECT_CALL(*mock_login_display_host_,
-              StartWizardPtr(WizardController::kTermsOfServiceScreenName,
-                             NULL))
-      .Times(1);
   UserContext user_context(kNewUsername);
   user_context.SetKey(Key(kPassword));
   user_context.SetUserIDHash(kNewUsername);
@@ -327,7 +321,7 @@ IN_PROC_BROWSER_TEST_F(ExistingUserControllerTest,
   // This is disabled twice: once right after signin but before checking for
   // auto-enrollment, and again after doing an ownership status check.
   EXPECT_CALL(*mock_login_display_, SetUIEnabled(false))
-      .Times(2)
+      .Times(1)
       .InSequence(uiEnabledSequence);
   EXPECT_CALL(*mock_login_display_, SetUIEnabled(true))
       .Times(1)
@@ -437,10 +431,6 @@ class ExistingUserControllerPublicSessionTest
         .Times(1)
         .WillOnce(InvokeWithoutArgs(&profile_prepared_cb_,
                                     &base::Callback<void(void)>::Run));
-    EXPECT_CALL(*mock_login_utils_,
-                DoBrowserLaunch(testing_profile_.get(),
-                                mock_login_display_host_.get()))
-        .Times(1);
     EXPECT_CALL(*mock_login_display_, SetUIEnabled(true))
         .Times(1);
     EXPECT_CALL(*mock_login_display_host_,

chrome/browser/chromeos/login/fake_login_utils.cc

@@ -9,6 +9,7 @@
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host.h"
+#include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
 #include "chrome/browser/chromeos/login/user_flow.h"
 #include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/supervised_user_manager.h"
@@ -60,11 +61,11 @@ void FakeLoginUtils::PrepareProfile(const UserContext& user_context,
                                     bool has_cookies,
                                     bool has_active_session,
                                     LoginUtils::Delegate* delegate) {
-  user_manager::UserManager::Get()->UserLoggedIn(
+  user_manager::UserManager* user_manager = user_manager::UserManager::Get();
+  user_manager->UserLoggedIn(
       user_context.GetUserID(), user_context.GetUserIDHash(), false);
   user_manager::User* user =
-      user_manager::UserManager::Get()->FindUserAndModify(
-          user_context.GetUserID());
+      user_manager->FindUserAndModify(user_context.GetUserID());
   DCHECK(user);
 
   // Make sure that we get the real Profile instead of the login Profile.
@@ -73,9 +74,8 @@ void FakeLoginUtils::PrepareProfile(const UserContext& user_context,
   profile->GetPrefs()->SetString(prefs::kGoogleServicesUsername,
                                  user_context.GetUserID());
 
-  if (user_manager::UserManager::Get()->IsLoggedInAsSupervisedUser()) {
-    user_manager::User* active_user =
-        user_manager::UserManager::Get()->GetActiveUser();
+  if (user_manager->IsLoggedInAsSupervisedUser()) {
+    user_manager::User* active_user = user_manager->GetActiveUser();
     std::string supervised_user_sync_id =
         ChromeUserManager::Get()->GetSupervisedUserManager()->GetUserSyncId(
             active_user->email());
@@ -89,8 +89,22 @@ void FakeLoginUtils::PrepareProfile(const UserContext& user_context,
       chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED,
       content::NotificationService::AllSources(),
       content::Details<Profile>(profile));
+
+  // Emulate UserSessionManager::InitializeUserSession() for now till
+  // FakeLoginUtils are deprecated.
+  bool browser_launched = false;
+  if (!user_manager->IsLoggedInAsKioskApp()) {
+    if (user_manager->IsCurrentUserNew()) {
+      NOTREACHED() << "Method not implemented.";
+    } else {
+      browser_launched = true;
+      LoginUtils::Get()->DoBrowserLaunch(profile,
+                                         LoginDisplayHostImpl::default_host());
+    }
+  }
+
   if (delegate)
-    delegate->OnProfilePrepared(profile);
+    delegate->OnProfilePrepared(profile, browser_launched);
 }
 
 void FakeLoginUtils::DelegateDeleted(LoginUtils::Delegate* delegate) {

chrome/browser/chromeos/login/login_manager_test.cc

@@ -118,14 +118,14 @@ void LoginManagerTest::JSExpect(const std::string& expression) {
 }
 
 void LoginManagerTest::InitializeWebContents() {
-    LoginDisplayHost* host = LoginDisplayHostImpl::default_host();
-    EXPECT_TRUE(host != NULL);
-
-    content::WebContents* web_contents =
-        host->GetWebUILoginView()->GetWebContents();
-    EXPECT_TRUE(web_contents != NULL);
-    set_web_contents(web_contents);
-    js_checker_.set_web_contents(web_contents);
-  }
+  LoginDisplayHost* host = LoginDisplayHostImpl::default_host();
+  EXPECT_TRUE(host != NULL);
+
+  content::WebContents* web_contents =
+      host->GetWebUILoginView()->GetWebContents();
+  EXPECT_TRUE(web_contents != NULL);
+  set_web_contents(web_contents);
+  js_checker_.set_web_contents(web_contents);
+}
 
 }  // namespace chromeos

chrome/browser/chromeos/login/login_utils.cc

@@ -48,6 +48,7 @@
 #include "chrome/browser/chromeos/login/signin/oauth2_login_manager_factory.h"
 #include "chrome/browser/chromeos/login/ui/input_events_blocker.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host.h"
+#include "chrome/browser/chromeos/login/ui/user_adding_screen.h"
 #include "chrome/browser/chromeos/login/user_flow.h"
 #include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/supervised_user_manager.h"
@@ -200,7 +201,8 @@ class LoginUtilsImpl : public LoginUtils,
                                                    bool early_restart) override;
 
   // UserSessionManager::Delegate implementation:
-  virtual void OnProfilePrepared(Profile* profile) override;
+  virtual void OnProfilePrepared(Profile* profile,
+                                 bool browser_launched) override;
 #if defined(ENABLE_RLZ)
   virtual void OnRlzInitialized() override;
 #endif
@@ -371,12 +373,21 @@ void LoginUtilsImpl::PrepareProfile(
   // as it coexist with SessionManager.
   delegate_ = delegate;
 
+  UserSessionManager::StartSessionType start_session_type =
+      UserAddingScreen::Get()->IsRunning() ?
+          UserSessionManager::SECONDARY_USER_SESSION :
+          UserSessionManager::PRIMARY_USER_SESSION;
+
   // For the transition part LoginUtils will just delegate profile
   // creation and initialization to SessionManager. Later LoginUtils will be
   // removed and all LoginUtils clients will just work with SessionManager
   // directly.
-  UserSessionManager::GetInstance()->StartSession(
-      user_context, authenticator_, has_auth_cookies, has_active_session, this);
+  UserSessionManager::GetInstance()->StartSession(user_context,
+                                                  start_session_type,
+                                                  authenticator_,
+                                                  has_auth_cookies,
+                                                  has_active_session,
+                                                  this);
 }
 
 void LoginUtilsImpl::DelegateDeleted(LoginUtils::Delegate* delegate) {
@@ -429,9 +440,10 @@ scoped_refptr<Authenticator> LoginUtilsImpl::CreateAuthenticator(
   return authenticator_;
 }
 
-void LoginUtilsImpl::OnProfilePrepared(Profile* profile) {
+void LoginUtilsImpl::OnProfilePrepared(Profile* profile,
+                                       bool browser_launched) {
   if (delegate_)
-    delegate_->OnProfilePrepared(profile);
+    delegate_->OnProfilePrepared(profile, browser_launched);
 }
 
 #if defined(ENABLE_RLZ)

chrome/browser/chromeos/login/login_utils.h

@@ -29,7 +29,10 @@ class LoginUtils {
   class Delegate {
    public:
     // Called after profile is loaded and prepared for the session.
-    virtual void OnProfilePrepared(Profile* profile) = 0;
+    // |browser_launched| will be true is browser has been launched, otherwise
+    // it will return false and client is responsible on launching browser.
+    virtual void OnProfilePrepared(Profile* profile,
+                                   bool browser_launched) = 0;
 
 #if defined(ENABLE_RLZ)
     // Called after post-profile RLZ initialization.

chrome/browser/chromeos/login/session/user_session_manager.h

@@ -41,7 +41,10 @@ class EasyUnlockKeyManager;
 class UserSessionManagerDelegate {
  public:
   // Called after profile is loaded and prepared for the session.
-  virtual void OnProfilePrepared(Profile* profile) = 0;
+  // |browser_launched| will be true is browser has been launched, otherwise
+  // it will return false and client is responsible on launching browser.
+  virtual void OnProfilePrepared(Profile* profile,
+                                 bool browser_launched) = 0;
 
 #if defined(ENABLE_RLZ)
   // Called after post-profile RLZ initialization.
@@ -61,10 +64,10 @@ class UserSessionStateObserver {
 };
 
 // UserSessionManager is responsible for starting user session which includes:
-// load and initialize Profile (including custom Profile preferences),
-// mark user as logged in and notify observers,
-// initialize OAuth2 authentication session,
-// initialize and launch user session based on the user type.
+// * load and initialize Profile (including custom Profile preferences),
+// * mark user as logged in and notify observers,
+// * initialize OAuth2 authentication session,
+// * initialize and launch user session based on the user type.
 // Also supports restoring active user sessions after browser crash:
 // load profile, restore OAuth authentication session etc.
 class UserSessionManager
@@ -74,6 +77,21 @@ class UserSessionManager
       public UserSessionManagerDelegate,
       public user_manager::UserManager::UserSessionStateObserver {
  public:
+  // Context of StartSession calls.
+  typedef enum {
+    // Starting primary user session, through login UI.
+    PRIMARY_USER_SESSION,
+
+    // Starting secondary user session, through multi-profiles login UI.
+    SECONDARY_USER_SESSION,
+
+    // Starting primary user session after browser crash.
+    PRIMARY_USER_SESSION_AFTER_CRASH,
+
+    // Starting secondary user session after browser crash.
+    SECONDARY_USER_SESSION_AFTER_CRASH,
+  } StartSessionType;
+
   // Returns UserSessionManager instance.
   static UserSessionManager* GetInstance();
 
@@ -91,6 +109,7 @@ class UserSessionManager
   // Start user session given |user_context| and |authenticator| which holds
   // authentication context (profile).
   void StartSession(const UserContext& user_context,
+                    StartSessionType start_session_type,
                     scoped_refptr<Authenticator> authenticator,
                     bool has_auth_cookies,
                     bool has_active_session,
@@ -198,7 +217,8 @@ class UserSessionManager
 
   // UserSessionManagerDelegate overrides:
   // Used when restoring user sessions after crash.
-  virtual void OnProfilePrepared(Profile* profile) override;
+  virtual void OnProfilePrepared(Profile* profile,
+                                 bool browser_launched) override;
 
   void CreateUserSession(const UserContext& user_context,
                          bool has_auth_cookies);
@@ -233,6 +253,18 @@ class UserSessionManager
   // Finalized profile preparation.
   void FinalizePrepareProfile(Profile* profile);
 
+  // Starts out-of-box flow with the specified screen.
+  void ActivateWizard(const std::string& screen_name);
+
+  // Adds first-time login URLs.
+  void InitializeStartUrls() const;
+
+  // Perform session initialization and either move to additional login flows
+  // such as TOS (public sessions), priority pref sync UI (new users) or
+  // launch browser.
+  // Returns true if browser has been launched or false otherwise.
+  bool InitializeUserSession(Profile* profile);
+
   // Initializes member variables needed for session restore process via
   // OAuthLoginManager.
   void InitSessionRestoreStrategy();
@@ -270,6 +302,7 @@ class UserSessionManager
   // Authentication/user context.
   UserContext user_context_;
   scoped_refptr<Authenticator> authenticator_;
+  StartSessionType start_session_type_;
 
   // True if the authentication context's cookie jar contains authentication
   // cookies from the authentication extension login flow.

chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc

@@ -5,6 +5,7 @@
 #include "chrome/browser/chromeos/login/supervised/supervised_user_login_flow.h"
 
 #include "base/base64.h"
+#include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_registry_simple.h"
@@ -18,6 +19,7 @@
 #include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/supervised_user_manager.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
+#include "chrome/common/chrome_switches.h"
 #include "chromeos/login/auth/key.h"
 #include "components/user_manager/user_manager.h"
 #include "content/public/browser/browser_thread.h"
@@ -35,6 +37,14 @@ SupervisedUserLoginFlow::SupervisedUserLoginFlow(
 
 SupervisedUserLoginFlow::~SupervisedUserLoginFlow() {}
 
+void SupervisedUserLoginFlow::AppendAdditionalCommandLineSwitches() {
+  user_manager::UserManager* user_manager = user_manager::UserManager::Get();
+  if (user_manager->IsCurrentUserNew()) {
+    // Supervised users should launch into empty desktop on first run.
+    CommandLine::ForCurrentProcess()->AppendSwitch(::switches::kSilentLaunch);
+  }
+}
+
 bool SupervisedUserLoginFlow::CanLockScreen() {
   return true;
 }
@@ -59,10 +69,6 @@ bool SupervisedUserLoginFlow::HandlePasswordChangeDetected() {
   return false;
 }
 
-void SupervisedUserLoginFlow::HandleOAuthTokenStatusChange(
-    user_manager::User::OAuthTokenStatus status) {
-}
-
 void SupervisedUserLoginFlow::OnSyncSetupDataLoaded(
     const std::string& token) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

chrome/browser/chromeos/login/supervised/supervised_user_login_flow.h

@@ -24,6 +24,7 @@ class SupervisedUserLoginFlow
   virtual ~SupervisedUserLoginFlow();
 
   // ExtendedUserFlow overrides.
+  virtual void AppendAdditionalCommandLineSwitches() override;
   virtual bool CanLockScreen() override;
   virtual bool ShouldLaunchBrowser() override;
   virtual bool ShouldSkipPostLoginScreens() override;
@@ -31,8 +32,6 @@ class SupervisedUserLoginFlow
   virtual bool HandleLoginFailure(const AuthFailure& failure) override;
   virtual void HandleLoginSuccess(const UserContext& context) override;
   virtual bool HandlePasswordChangeDetected() override;
-  virtual void HandleOAuthTokenStatusChange(
-      user_manager::User::OAuthTokenStatus status) override;
   virtual void LaunchExtraSteps(Profile* profile) override;
 
   // ExtendedAuthenticator::NewAuthStatusConsumer overrides.

chrome/browser/chromeos/login/test_login_utils.cc

@@ -24,8 +24,9 @@ void TestLoginUtils::PrepareProfile(
     Delegate* delegate) {
   if (user_context != expected_user_context_)
     NOTREACHED();
+
   // Profile hasn't been loaded.
-  delegate->OnProfilePrepared(NULL);
+  delegate->OnProfilePrepared(NULL, false);
 }
 
 void TestLoginUtils::DelegateDeleted(Delegate* delegate) {

chrome/browser/chromeos/login/user_flow.cc

@@ -24,6 +24,9 @@ UserFlow::~UserFlow() {}
 
 DefaultUserFlow::~DefaultUserFlow() {}
 
+void DefaultUserFlow::AppendAdditionalCommandLineSwitches() {
+}
+
 bool DefaultUserFlow::CanLockScreen() {
   return true;
 }
@@ -68,10 +71,17 @@ ExtendedUserFlow::ExtendedUserFlow(const std::string& user_id)
 ExtendedUserFlow::~ExtendedUserFlow() {
 }
 
+void ExtendedUserFlow::AppendAdditionalCommandLineSwitches() {
+}
+
 bool ExtendedUserFlow::ShouldShowSettings() {
   return true;
 }
 
+void ExtendedUserFlow::HandleOAuthTokenStatusChange(
+    user_manager::User::OAuthTokenStatus status) {
+}
+
 void ExtendedUserFlow::UnregisterFlowSoon() {
   std::string id_copy(user_id());
   base::MessageLoop::current()->PostTask(FROM_HERE,

chrome/browser/chromeos/login/user_flow.h

@@ -21,6 +21,10 @@ class UserFlow {
  public:
   UserFlow();
   virtual ~UserFlow() = 0;
+
+  // Provides ability to alter command line before session has started.
+  virtual void AppendAdditionalCommandLineSwitches() = 0;
+
   // Indicates if screen locking should be enabled or disabled for a flow.
   virtual bool CanLockScreen() = 0;
   virtual bool ShouldShowSettings() = 0;
@@ -51,6 +55,7 @@ class DefaultUserFlow : public UserFlow {
  public:
   virtual ~DefaultUserFlow();
 
+  virtual void AppendAdditionalCommandLineSwitches() override;
   virtual bool CanLockScreen() override;
   virtual bool ShouldShowSettings() override;
   virtual bool ShouldLaunchBrowser() override;
@@ -70,7 +75,10 @@ class ExtendedUserFlow : public UserFlow {
   explicit ExtendedUserFlow(const std::string& user_id);
   virtual ~ExtendedUserFlow();
 
+  virtual void AppendAdditionalCommandLineSwitches() override;
   virtual bool ShouldShowSettings() override;
+  virtual void HandleOAuthTokenStatusChange(
+      user_manager::User::OAuthTokenStatus status) override;
 
  protected:
   // Subclasses can call this method to unregister flow in the next event.

google_apis/gaia/gaia_auth_util.cc

@@ -25,8 +25,9 @@ std::string CanonicalizeEmailImpl(const std::string& email_address,
   char at = '@';
   base::SplitString(email_address, at, &parts);
   if (parts.size() != 2U) {
-    NOTREACHED() << "expecting exactly one @, but got " << parts.size()-1 <<
-        " : " << email_address;
+    NOTREACHED() << "expecting exactly one @, but got "
+                 << (parts.empty() ? 0 : parts.size() - 1)
+                 << " : " << email_address;
   } else {
     if (change_googlemail_to_gmail && parts[1] == kGooglemailDomain)
       parts[1] = kGmailDomain;