Commit 60d2c270 authored by sudarsana.nagineni's avatar sudarsana.nagineni Committed by Commit bot

Fix a DCHECK failure by registering a handler for 'dialogClose' message.

This fixes a DCHECK failure on chrome://print, where no handler was
registered to handle chrome.send("dialogClose").

BUG=416783

Review URL: https://codereview.chromium.org/614683002

Cr-Commit-Position: refs/heads/master@{#297199}
parent a12fd96d
...@@ -60,6 +60,11 @@ ConstrainedWebDialogUI::~ConstrainedWebDialogUI() { ...@@ -60,6 +60,11 @@ ConstrainedWebDialogUI::~ConstrainedWebDialogUI() {
void ConstrainedWebDialogUI::RenderViewCreated( void ConstrainedWebDialogUI::RenderViewCreated(
RenderViewHost* render_view_host) { RenderViewHost* render_view_host) {
// Add a "dialogClose" callback which matches WebDialogUI behavior.
web_ui()->RegisterMessageCallback("dialogClose",
base::Bind(&ConstrainedWebDialogUI::OnDialogCloseMessage,
base::Unretained(this)));
ConstrainedWebDialogDelegate* delegate = GetConstrainedDelegate(); ConstrainedWebDialogDelegate* delegate = GetConstrainedDelegate();
if (!delegate) if (!delegate)
return; return;
...@@ -74,11 +79,6 @@ void ConstrainedWebDialogUI::RenderViewCreated( ...@@ -74,11 +79,6 @@ void ConstrainedWebDialogUI::RenderViewCreated(
web_ui()->AddMessageHandler(*it); web_ui()->AddMessageHandler(*it);
} }
// Add a "dialogClose" callback which matches WebDialogUI behavior.
web_ui()->RegisterMessageCallback("dialogClose",
base::Bind(&ConstrainedWebDialogUI::OnDialogCloseMessage,
base::Unretained(this)));
dialog_delegate->OnDialogShown(web_ui(), render_view_host); dialog_delegate->OnDialogShown(web_ui(), render_view_host);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment