Commit 60e171cc authored by Gang Wu's avatar Gang Wu Committed by Commit Bot

Disable two tests in IDBRequestTest on Android

IDBRequestTest.AbortErrorAfterAbort
IDBRequestTest.EventsAfterEarlyDeathStopWithTwoQueuedResults are flaky
on Marshmallow

TBR=cmp@chromium.org

Bug: 1068057
Change-Id: I95203303a82d01eaa81618a1949b8b5cf44e6eb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136892Reviewed-by: default avatarGang Wu <gangwu@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Auto-Submit: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756577}
parent 71566833
...@@ -320,7 +320,17 @@ TEST_F(IDBRequestTest, EventsAfterEarlyDeathStopWithQueuedResult) { ...@@ -320,7 +320,17 @@ TEST_F(IDBRequestTest, EventsAfterEarlyDeathStopWithQueuedResult) {
EnsureIDBCallbacksDontThrow(request, scope.GetExceptionState()); EnsureIDBCallbacksDontThrow(request, scope.GetExceptionState());
} }
TEST_F(IDBRequestTest, EventsAfterEarlyDeathStopWithTwoQueuedResults) { // This test is flaky on Marshmallow 64 bit Tester because the test is
// crashing. See <http://crbug.com/1068057>.
#if defined(OS_ANDROID)
#define MAYBE_EventsAfterEarlyDeathStopWithTwoQueuedResults \
DISABLED_EventsAfterEarlyDeathStopWithTwoQueuedResults
#else
#define MAYBE_EventsAfterEarlyDeathStopWithTwoQueuedResults \
EventsAfterEarlyDeathStopWithTwoQueuedResults
#endif
TEST_F(IDBRequestTest, MAYBE_EventsAfterEarlyDeathStopWithTwoQueuedResults) {
V8TestingScope scope; V8TestingScope scope;
const int64_t kTransactionId = 1234; const int64_t kTransactionId = 1234;
auto database_backend = std::make_unique<MockWebIDBDatabase>(); auto database_backend = std::make_unique<MockWebIDBDatabase>();
...@@ -357,7 +367,17 @@ TEST_F(IDBRequestTest, EventsAfterEarlyDeathStopWithTwoQueuedResults) { ...@@ -357,7 +367,17 @@ TEST_F(IDBRequestTest, EventsAfterEarlyDeathStopWithTwoQueuedResults) {
EnsureIDBCallbacksDontThrow(request2, scope.GetExceptionState()); EnsureIDBCallbacksDontThrow(request2, scope.GetExceptionState());
} }
TEST_F(IDBRequestTest, AbortErrorAfterAbort) { // This test is flaky on Marshmallow 64 bit Tester because the test is
// crashing. See <http://crbug.com/1068057>.
#if defined(OS_ANDROID)
#define MAYBE_AbortErrorAfterAbort \
DISABLED_AbortErrorAfterAbort
#else
#define MAYBE_AbortErrorAfterAbort \
AbortErrorAfterAbort
#endif
TEST_F(IDBRequestTest, MAYBE_AbortErrorAfterAbort) {
V8TestingScope scope; V8TestingScope scope;
IDBTransaction* transaction = nullptr; IDBTransaction* transaction = nullptr;
IDBRequest* request = IDBRequest* request =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment