Commit 60eec06e authored by Peter Wen's avatar Peter Wen Committed by Commit Bot

Android: Count all renderer crashes with minidump

Switch stability proto's renderer crash count to include all renderer
crashes that result in a minidump rather than just foreground.

Pros:
- Align renderer crash counting with GPU crash counting
- Closer alignment with crashes that are uploaded
  - Every crash resulting in a minidump is a candidate to be uploaded
- Background renderer crashes are real crashes and should be fixed

Cons:
- Foreground renderer crashes are certain to cause a bad user experience
  while background crashes do not necessarily do so.

We are testing this out and keeping the rest of the crash pipeline the
same so that we can continue to compare old vs new metrics. If it does
not result in poor prioritization, this change will stick.

Full context: http://g/clank-crash/hZJyq3PJC3g

Bug: 839017
Change-Id: Iab8d6bdae993fbe3d41932719b9cecc5a6c450b8
Reviewed-on: https://chromium-review.googlesource.com/1246462Reviewed-by: default avatarBo <boliu@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594832}
parent 02995c14
...@@ -160,12 +160,8 @@ void ChromeStabilityMetricsProvider::OnCrashDumpProcessed( ...@@ -160,12 +160,8 @@ void ChromeStabilityMetricsProvider::OnCrashDumpProcessed(
int rph_id, int rph_id,
const crash_reporter::CrashMetricsReporter::ReportedCrashTypeSet& const crash_reporter::CrashMetricsReporter::ReportedCrashTypeSet&
reported_counts) { reported_counts) {
if (reported_counts.count( if (reported_counts.count(crash_reporter::CrashMetricsReporter::
crash_reporter::CrashMetricsReporter::ProcessedCrashCounts:: ProcessedCrashCounts::kRendererCrashAll)) {
kRendererForegroundVisibleCrash) ||
reported_counts.count(
crash_reporter::CrashMetricsReporter::ProcessedCrashCounts::
kRendererForegroundVisibleSubframeCrash)) {
helper_.IncreaseRendererCrashCount(); helper_.IncreaseRendererCrashCount();
} }
if (reported_counts.count(crash_reporter::CrashMetricsReporter:: if (reported_counts.count(crash_reporter::CrashMetricsReporter::
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment