Commit 60f38528 authored by Victor Vasiliev's avatar Victor Vasiliev Committed by Commit Bot

Use real absl::StrCat.

The binary size impact appears to be about 4 kilobytes, which is
much less than I've feared.

Change-Id: Ib85806f7fffe809f24692f24f3811447b8400c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412627Reviewed-by: default avatarDavid Schinazi <dschinazi@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823853}
parent 27749786
......@@ -9,16 +9,24 @@
#include <string>
#include <utility>
#include "base/strings/abseil_string_conversions.h"
#include "base/strings/stringprintf.h"
#include "third_party/abseil-cpp/absl/strings/str_cat.h"
namespace quiche {
inline absl::string_view MaybeStringPieceToStringView(base::StringPiece arg) {
return base::StringPieceToStringView(arg);
}
template <typename T>
inline T MaybeStringPieceToStringView(const T& arg) {
return arg;
}
template <typename... Args>
inline std::string QuicheStrCatImpl(const Args&... args) {
std::ostringstream oss;
int dummy[] = {1, (oss << args, 0)...};
static_cast<void>(dummy);
return oss.str();
return absl::StrCat(MaybeStringPieceToStringView(args)...);
}
template <typename... Args>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment