Add label to read later menu button and update menu title.

Bug: 1109316
Change-Id: I7b43d2fcfcce720ac8a812034aade2cecbc2c715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428392Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810261}

chrome/app/generated_resources.grd

@@ -5683,10 +5683,17 @@ Keep your key file in a safe place. You will need it to create new versions of y
         </message>
       </if>
 
-      <!-- Read Later menu -->
-      <message name="IDS_READ_LATER_MENU_TITLE" desc="Title of the Read later menu">
-        Read later
-      </message>
+      <!-- Read Later button and menu -->
+      <if expr="use_titlecase">
+        <message name="IDS_READ_LATER_TITLE" desc="Title of the Read later menu">
+          Reading List
+        </message>
+      </if>
+      <if expr="not use_titlecase">
+        <message name="IDS_READ_LATER_TITLE" desc="Title of the Read later menu">
+          Reading list
+        </message>
+      </if>
       <message name="IDS_READ_LATER_MENU_UNREAD_HEADER" desc="Header for section of unread Read later items.">
         UNREAD
       </message>
@@ -5742,9 +5749,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
       <message name="IDS_TOOLTIP_MIC_SEARCH" desc="The tooltip for search-by-voice button">
         Search by voice
       </message>
-      <message name="IDS_TOOLTIP_READ_LATER_BUTTON" desc="The tooltip for the read-later button">
-        Read later
-      </message>
       <message name="IDS_TOOLTIP_SAVE_CREDIT_CARD" desc="The tooltip for the icon that shows the save credit card bubble">
         Save card
       </message>

chrome/app/generated_resources_grd/IDS_READ_LATER_MENU_TITLE.png.sha1

-97cc37ef9726d64172b7cfdd8bf251cb5b66d645
\ No newline at end of file

chrome/app/generated_resources_grd/IDS_READ_LATER_TITLE.png.sha1

+07fc3d80481bd9c45c4ce4dc913d9ca6a11cae78
\ No newline at end of file

chrome/app/generated_resources_grd/IDS_TOOLTIP_READ_LATER_BUTTON.png.sha1

-5b3b3031843ec01ec012ee1c6ee2c48729910490
\ No newline at end of file

chrome/browser/ui/views/read_later/read_later_button.cc

@@ -19,13 +19,17 @@
 #include "ui/views/bubble/bubble_dialog_delegate_view.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/button/button_controller.h"
+#include "ui/views/controls/button/label_button.h"
 
 ReadLaterButton::ReadLaterButton(Browser* browser)
     : ToolbarButton(this), browser_(browser) {
-  SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_READ_LATER_BUTTON));
+  SetTooltipText(l10n_util::GetStringUTF16(IDS_READ_LATER_TITLE));
   GetViewAccessibility().OverrideHasPopup(ax::mojom::HasPopup::kMenu);
   button_controller()->set_notify_action(
       views::ButtonController::NotifyAction::kOnPress);
+  // We don't want to use ToolbarButton::SetHighlight here because it adds a
+  // border around the button.
+  LabelButton::SetText(l10n_util::GetStringUTF16(IDS_READ_LATER_TITLE));
 }
 
 ReadLaterButton::~ReadLaterButton() = default;

chrome/browser/ui/webui/read_later/read_later_ui.cc

@@ -41,7 +41,7 @@ ReadLaterUI::ReadLaterUI(content::WebUI* web_ui)
                           IDR_READ_LATER_MOJO_LITE_JS);
   static constexpr webui::LocalizedString kLocalizedStrings[] = {
       {"readHeader", IDS_READ_LATER_MENU_READ_HEADER},
-      {"title", IDS_READ_LATER_MENU_TITLE},
+      {"title", IDS_READ_LATER_TITLE},
       {"tooltipDelete", IDS_DELETE},
       {"tooltipMarkAsRead", IDS_READ_LATER_MENU_TOOLTIP_MARK_AS_READ},
       {"tooltipMarkAsUnread", IDS_READ_LATER_MENU_TOOLTIP_MARK_AS_UNREAD},