Commit 610e09c8 authored by Bo Liu's avatar Bo Liu Committed by Chromium LUCI CQ

Remove GLSurfaceEGLSurfaceControl DumpWithoutCrashing

This is generating a significant number of crash reports that it's
affecting ability to evaluate other crashes. There are reports from beta
already, so going to remove the DumpWithoutCrashing and merge it before
hitting stable.

Bug: 1142569, 1037760
Change-Id: Id91b95a385ee91e0e065ec46e5f25a779f6e0c35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612525Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840788}
parent 00b27524
...@@ -10,9 +10,7 @@ ...@@ -10,9 +10,7 @@
#include "base/android/build_info.h" #include "base/android/build_info.h"
#include "base/android/scoped_hardware_buffer_fence_sync.h" #include "base/android/scoped_hardware_buffer_fence_sync.h"
#include "base/bind.h" #include "base/bind.h"
#include "base/debug/dump_without_crashing.h"
#include "base/posix/eintr_wrapper.h" #include "base/posix/eintr_wrapper.h"
#include "base/rand_util.h"
#include "base/strings/strcat.h" #include "base/strings/strcat.h"
#include "base/threading/thread_task_runner_handle.h" #include "base/threading/thread_task_runner_handle.h"
#include "base/trace_event/trace_event.h" #include "base/trace_event/trace_event.h"
...@@ -685,11 +683,6 @@ void GLSurfaceEGLSurfaceControl::TransactionAckTimeoutManager:: ...@@ -685,11 +683,6 @@ void GLSurfaceEGLSurfaceControl::TransactionAckTimeoutManager::
LOG(ERROR) << "Transaction id " << transaction_id LOG(ERROR) << "Transaction id " << transaction_id
<< " haven't received any ack from past 5 second which indicates " << " haven't received any ack from past 5 second which indicates "
"it hanged"; "it hanged";
// Hang detection logic here. we want to limit the number of dumps to 10% of
// the cases to avoid seeing too many instances in crash report.
if (base::RandInt(1, 10) == 1)
base::debug::DumpWithoutCrashing();
} }
} // namespace gl } // namespace gl
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment