Remove BaseAudioContext::suspendContext()

This virtual method is not needed.  The derived classes don't all
support this method, and indeed it is invalid for an
OfflineAudioContext because the offline context requires a time
argument.

Bug: 889694
Test: internal change
Change-Id: I9ee9aa6279693f90b4a91bfa34f3f584e5f3654d
Reviewed-on: https://chromium-review.googlesource.com/1247683Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594809}

third_party/blink/renderer/modules/webaudio/audio_context.h

@@ -41,7 +41,7 @@ class MODULES_EXPORT AudioContext : public BaseAudioContext {
   ScriptPromise closeContext(ScriptState*);
   bool IsContextClosed() const final;
 
-  ScriptPromise suspendContext(ScriptState*) final;
+  ScriptPromise suspendContext(ScriptState*);
   ScriptPromise resumeContext(ScriptState*) final;
 
   bool HasRealtimeConstraint() final { return true; }

third_party/blink/renderer/modules/webaudio/base_audio_context.h

@@ -220,9 +220,6 @@ class MODULES_EXPORT BaseAudioContext
                                    const PeriodicWaveConstraints&,
                                    ExceptionState&);
 
-  // Suspend
-  virtual ScriptPromise suspendContext(ScriptState*) = 0;
-
   // Resume
   virtual ScriptPromise resumeContext(ScriptState*) = 0;
 

third_party/blink/renderer/modules/webaudio/offline_audio_context.cc

@@ -222,12 +222,6 @@ ScriptPromise OfflineAudioContext::startOfflineRendering(
   return complete_resolver_->Promise();
 }
 
-ScriptPromise OfflineAudioContext::suspendContext(ScriptState* script_state) {
-  LOG(FATAL) << "This CANNOT be called on OfflineAudioContext; this is only to "
-                "implement the pure virtual interface from BaseAudioContext.";
-  return ScriptPromise();
-}
-
 ScriptPromise OfflineAudioContext::suspendContext(ScriptState* script_state,
                                                   double when) {
   DCHECK(IsMainThread());

third_party/blink/renderer/modules/webaudio/offline_audio_context.h

@@ -61,10 +61,6 @@ class MODULES_EXPORT OfflineAudioContext final : public BaseAudioContext {
   ScriptPromise suspendContext(ScriptState*, double);
   ScriptPromise resumeContext(ScriptState*) final;
 
-  // This is to implement the pure virtual method from BaseAudioContext.
-  // CANNOT be called from an OfflineAudioContext.
-  ScriptPromise suspendContext(ScriptState*) final;
-
   void RejectPendingResolvers() override;
 
   bool HasRealtimeConstraint() final { return false; }