Commit 61124039 authored by cm.sanchi's avatar cm.sanchi Committed by Commit Bot

chrome: Move chrome/browser/ui/crypto files out of chrome namespace.

From discussion on chromium-dev, it was decided to remove 'chrome'
namespace.

TBR=sky@chromium.org

Bug: 289619
Change-Id: I7a3769cfb30db3a2bb8d761f646cf23f1582f972
Reviewed-on: https://chromium-review.googlesource.com/787810Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Commit-Queue: Chandramouli Sanchi <cm.sanchi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#521139}
parent d0ce0f4d
...@@ -121,7 +121,7 @@ void CertificateManagerModel::Refresh() { ...@@ -121,7 +121,7 @@ void CertificateManagerModel::Refresh() {
cert_db_->ListModules(&modules, false); cert_db_->ListModules(&modules, false);
DVLOG(1) << "refresh waiting for unlocking..."; DVLOG(1) << "refresh waiting for unlocking...";
chrome::UnlockSlotsIfNecessary( chrome::UnlockSlotsIfNecessary(
std::move(modules), chrome::kCryptoModulePasswordListCerts, std::move(modules), kCryptoModulePasswordListCerts,
net::HostPortPair(), // unused. net::HostPortPair(), // unused.
NULL, // TODO(mattm): supply parent window. NULL, // TODO(mattm): supply parent window.
base::Bind(&CertificateManagerModel::RefreshSlotsUnlocked, base::Bind(&CertificateManagerModel::RefreshSlotsUnlocked,
......
...@@ -980,11 +980,11 @@ std::unique_ptr<net::ClientCertStore> ProfileIOData::CreateClientCertStore() { ...@@ -980,11 +980,11 @@ std::unique_ptr<net::ClientCertStore> ProfileIOData::CreateClientCertStore() {
base::MakeUnique<chromeos::ClientCertFilterChromeOS>( base::MakeUnique<chromeos::ClientCertFilterChromeOS>(
use_system_key_slot_, username_hash_), use_system_key_slot_, username_hash_),
base::Bind(&CreateCryptoModuleBlockingPasswordDelegate, base::Bind(&CreateCryptoModuleBlockingPasswordDelegate,
chrome::kCryptoModulePasswordClientAuth))); kCryptoModulePasswordClientAuth)));
#elif defined(USE_NSS_CERTS) #elif defined(USE_NSS_CERTS)
return std::unique_ptr<net::ClientCertStore>(new net::ClientCertStoreNSS( return std::unique_ptr<net::ClientCertStore>(new net::ClientCertStoreNSS(
base::Bind(&CreateCryptoModuleBlockingPasswordDelegate, base::Bind(&CreateCryptoModuleBlockingPasswordDelegate,
chrome::kCryptoModulePasswordClientAuth))); kCryptoModulePasswordClientAuth)));
#elif defined(OS_WIN) #elif defined(OS_WIN)
return std::unique_ptr<net::ClientCertStore>(new net::ClientCertStoreWin()); return std::unique_ptr<net::ClientCertStore>(new net::ClientCertStoreWin());
#elif defined(OS_MACOSX) #elif defined(OS_MACOSX)
......
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
using content::BrowserThread; using content::BrowserThread;
ChromeNSSCryptoModuleDelegate::ChromeNSSCryptoModuleDelegate( ChromeNSSCryptoModuleDelegate::ChromeNSSCryptoModuleDelegate(
chrome::CryptoModulePasswordReason reason, CryptoModulePasswordReason reason,
const net::HostPortPair& server) const net::HostPortPair& server)
: reason_(reason), : reason_(reason),
server_(server), server_(server),
...@@ -66,8 +66,7 @@ void ChromeNSSCryptoModuleDelegate::GotPassword(const std::string& password) { ...@@ -66,8 +66,7 @@ void ChromeNSSCryptoModuleDelegate::GotPassword(const std::string& password) {
} }
crypto::CryptoModuleBlockingPasswordDelegate* crypto::CryptoModuleBlockingPasswordDelegate*
CreateCryptoModuleBlockingPasswordDelegate( CreateCryptoModuleBlockingPasswordDelegate(CryptoModulePasswordReason reason,
chrome::CryptoModulePasswordReason reason, const net::HostPortPair& server) {
const net::HostPortPair& server) {
return new ChromeNSSCryptoModuleDelegate(reason, server); return new ChromeNSSCryptoModuleDelegate(reason, server);
} }
...@@ -22,7 +22,7 @@ class ChromeNSSCryptoModuleDelegate ...@@ -22,7 +22,7 @@ class ChromeNSSCryptoModuleDelegate
// Create a ChromeNSSCryptoModuleDelegate. |reason| is used to select what // Create a ChromeNSSCryptoModuleDelegate. |reason| is used to select what
// string to show the user, |server| is displayed to indicate which connection // string to show the user, |server| is displayed to indicate which connection
// is causing the dialog to appear. |slot| can be NULL. // is causing the dialog to appear. |slot| can be NULL.
ChromeNSSCryptoModuleDelegate(chrome::CryptoModulePasswordReason reason, ChromeNSSCryptoModuleDelegate(CryptoModulePasswordReason reason,
const net::HostPortPair& server); const net::HostPortPair& server);
// crypto::CryptoModuleBlockingPasswordDelegate implementation. // crypto::CryptoModuleBlockingPasswordDelegate implementation.
...@@ -40,7 +40,7 @@ class ChromeNSSCryptoModuleDelegate ...@@ -40,7 +40,7 @@ class ChromeNSSCryptoModuleDelegate
void GotPassword(const std::string& password); void GotPassword(const std::string& password);
// Parameters displayed in the dialog. // Parameters displayed in the dialog.
const chrome::CryptoModulePasswordReason reason_; const CryptoModulePasswordReason reason_;
net::HostPortPair server_; net::HostPortPair server_;
// Event to block worker thread while waiting for dialog on UI thread. // Event to block worker thread while waiting for dialog on UI thread.
...@@ -55,8 +55,7 @@ class ChromeNSSCryptoModuleDelegate ...@@ -55,8 +55,7 @@ class ChromeNSSCryptoModuleDelegate
// Create a delegate which only handles unlocking slots. // Create a delegate which only handles unlocking slots.
crypto::CryptoModuleBlockingPasswordDelegate* crypto::CryptoModuleBlockingPasswordDelegate*
CreateCryptoModuleBlockingPasswordDelegate( CreateCryptoModuleBlockingPasswordDelegate(CryptoModulePasswordReason reason,
chrome::CryptoModulePasswordReason reason, const net::HostPortPair& server);
const net::HostPortPair& server);
#endif // CHROME_BROWSER_UI_CRYPTO_MODULE_DELEGATE_NSS_H_ #endif // CHROME_BROWSER_UI_CRYPTO_MODULE_DELEGATE_NSS_H_
...@@ -10,8 +10,6 @@ ...@@ -10,8 +10,6 @@
#include "base/callback.h" #include "base/callback.h"
#include "ui/gfx/native_widget_types.h" #include "ui/gfx/native_widget_types.h"
namespace chrome {
// An enum to describe the reason for the password request. // An enum to describe the reason for the password request.
enum CryptoModulePasswordReason { enum CryptoModulePasswordReason {
kCryptoModulePasswordCertEnrollment, kCryptoModulePasswordCertEnrollment,
...@@ -35,6 +33,4 @@ void ShowCryptoModulePasswordDialog( ...@@ -35,6 +33,4 @@ void ShowCryptoModulePasswordDialog(
gfx::NativeWindow parent, gfx::NativeWindow parent,
const CryptoModulePasswordCallback& callback); const CryptoModulePasswordCallback& callback);
} // namespace chrome
#endif // CHROME_BROWSER_UI_CRYPTO_MODULE_PASSWORD_DIALOG_H_ #endif // CHROME_BROWSER_UI_CRYPTO_MODULE_PASSWORD_DIALOG_H_
...@@ -26,7 +26,7 @@ bool ShouldShowDialog(PK11SlotInfo* slot) { ...@@ -26,7 +26,7 @@ bool ShouldShowDialog(PK11SlotInfo* slot) {
class SlotUnlocker { class SlotUnlocker {
public: public:
SlotUnlocker(std::vector<crypto::ScopedPK11Slot> modules, SlotUnlocker(std::vector<crypto::ScopedPK11Slot> modules,
chrome::CryptoModulePasswordReason reason, CryptoModulePasswordReason reason,
const net::HostPortPair& server, const net::HostPortPair& server,
gfx::NativeWindow parent, gfx::NativeWindow parent,
const base::Closure& callback); const base::Closure& callback);
...@@ -39,7 +39,7 @@ class SlotUnlocker { ...@@ -39,7 +39,7 @@ class SlotUnlocker {
size_t current_; size_t current_;
std::vector<crypto::ScopedPK11Slot> modules_; std::vector<crypto::ScopedPK11Slot> modules_;
chrome::CryptoModulePasswordReason reason_; CryptoModulePasswordReason reason_;
net::HostPortPair server_; net::HostPortPair server_;
gfx::NativeWindow parent_; gfx::NativeWindow parent_;
base::Closure callback_; base::Closure callback_;
...@@ -47,7 +47,7 @@ class SlotUnlocker { ...@@ -47,7 +47,7 @@ class SlotUnlocker {
}; };
SlotUnlocker::SlotUnlocker(std::vector<crypto::ScopedPK11Slot> modules, SlotUnlocker::SlotUnlocker(std::vector<crypto::ScopedPK11Slot> modules,
chrome::CryptoModulePasswordReason reason, CryptoModulePasswordReason reason,
const net::HostPortPair& server, const net::HostPortPair& server,
gfx::NativeWindow parent, gfx::NativeWindow parent,
const base::Closure& callback) const base::Closure& callback)
...@@ -118,7 +118,7 @@ void SlotUnlocker::Done() { ...@@ -118,7 +118,7 @@ void SlotUnlocker::Done() {
namespace chrome { namespace chrome {
void UnlockSlotsIfNecessary(std::vector<crypto::ScopedPK11Slot> modules, void UnlockSlotsIfNecessary(std::vector<crypto::ScopedPK11Slot> modules,
chrome::CryptoModulePasswordReason reason, CryptoModulePasswordReason reason,
const net::HostPortPair& server, const net::HostPortPair& server,
gfx::NativeWindow parent, gfx::NativeWindow parent,
const base::Closure& callback) { const base::Closure& callback) {
...@@ -134,7 +134,7 @@ void UnlockSlotsIfNecessary(std::vector<crypto::ScopedPK11Slot> modules, ...@@ -134,7 +134,7 @@ void UnlockSlotsIfNecessary(std::vector<crypto::ScopedPK11Slot> modules,
} }
void UnlockCertSlotIfNecessary(CERTCertificate* cert, void UnlockCertSlotIfNecessary(CERTCertificate* cert,
chrome::CryptoModulePasswordReason reason, CryptoModulePasswordReason reason,
const net::HostPortPair& server, const net::HostPortPair& server,
gfx::NativeWindow parent, gfx::NativeWindow parent,
const base::Closure& callback) { const base::Closure& callback) {
......
...@@ -16,8 +16,6 @@ ...@@ -16,8 +16,6 @@
#include "ui/views/layout/grid_layout.h" #include "ui/views/layout/grid_layout.h"
#include "ui/views/widget/widget.h" #include "ui/views/widget/widget.h"
namespace chrome {
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// CryptoModulePasswordDialogView, public: // CryptoModulePasswordDialogView, public:
...@@ -90,25 +88,25 @@ void CryptoModulePasswordDialogView::Init(const std::string& hostname, ...@@ -90,25 +88,25 @@ void CryptoModulePasswordDialogView::Init(const std::string& hostname,
const base::string16& hostname16 = base::UTF8ToUTF16(hostname); const base::string16& hostname16 = base::UTF8ToUTF16(hostname);
const base::string16& slot16 = base::UTF8ToUTF16(slot_name); const base::string16& slot16 = base::UTF8ToUTF16(slot_name);
switch (reason) { switch (reason) {
case chrome::kCryptoModulePasswordCertEnrollment: case kCryptoModulePasswordCertEnrollment:
text = l10n_util::GetStringFUTF8( text = l10n_util::GetStringFUTF8(
IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CERT_ENROLLMENT, IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CERT_ENROLLMENT,
slot16, slot16,
hostname16); hostname16);
break; break;
case chrome::kCryptoModulePasswordClientAuth: case kCryptoModulePasswordClientAuth:
text = l10n_util::GetStringFUTF8( text = l10n_util::GetStringFUTF8(
IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CLIENT_AUTH, slot16, hostname16); IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CLIENT_AUTH, slot16, hostname16);
break; break;
case chrome::kCryptoModulePasswordListCerts: case kCryptoModulePasswordListCerts:
text = l10n_util::GetStringFUTF8( text = l10n_util::GetStringFUTF8(
IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_LIST_CERTS, slot16); IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_LIST_CERTS, slot16);
break; break;
case chrome::kCryptoModulePasswordCertImport: case kCryptoModulePasswordCertImport:
text = l10n_util::GetStringFUTF8( text = l10n_util::GetStringFUTF8(
IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CERT_IMPORT, slot16); IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CERT_IMPORT, slot16);
break; break;
case chrome::kCryptoModulePasswordCertExport: case kCryptoModulePasswordCertExport:
text = l10n_util::GetStringFUTF8( text = l10n_util::GetStringFUTF8(
IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CERT_EXPORT, slot16); IDS_CRYPTO_MODULE_AUTH_DIALOG_TEXT_CERT_EXPORT, slot16);
break; break;
...@@ -165,5 +163,3 @@ void ShowCryptoModulePasswordDialog( ...@@ -165,5 +163,3 @@ void ShowCryptoModulePasswordDialog(
new CryptoModulePasswordDialogView(slot_name, reason, hostname, callback); new CryptoModulePasswordDialogView(slot_name, reason, hostname, callback);
views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent)->Show(); views::DialogDelegate::CreateDialogWidget(dialog, NULL, parent)->Show();
} }
} // namespace chrome
...@@ -18,8 +18,6 @@ class Label; ...@@ -18,8 +18,6 @@ class Label;
class Textfield; class Textfield;
} }
namespace chrome {
class CryptoModulePasswordDialogView : public views::DialogDelegateView, class CryptoModulePasswordDialogView : public views::DialogDelegateView,
public views::TextfieldController { public views::TextfieldController {
public: public:
...@@ -63,6 +61,4 @@ class CryptoModulePasswordDialogView : public views::DialogDelegateView, ...@@ -63,6 +61,4 @@ class CryptoModulePasswordDialogView : public views::DialogDelegateView,
DISALLOW_COPY_AND_ASSIGN(CryptoModulePasswordDialogView); DISALLOW_COPY_AND_ASSIGN(CryptoModulePasswordDialogView);
}; };
} // namespace chrome
#endif // CHROME_BROWSER_UI_VIEWS_CRYPTO_MODULE_PASSWORD_DIALOG_VIEW_H_ #endif // CHROME_BROWSER_UI_VIEWS_CRYPTO_MODULE_PASSWORD_DIALOG_VIEW_H_
...@@ -14,8 +14,6 @@ ...@@ -14,8 +14,6 @@
#include "ui/views/controls/textfield/textfield.h" #include "ui/views/controls/textfield/textfield.h"
#include "ui/views/test/views_test_base.h" #include "ui/views/test/views_test_base.h"
namespace chrome {
class CryptoModulePasswordDialogViewTest : public views::ViewsTestBase { class CryptoModulePasswordDialogViewTest : public views::ViewsTestBase {
public: public:
CryptoModulePasswordDialogViewTest() {} CryptoModulePasswordDialogViewTest() {}
...@@ -56,5 +54,3 @@ TEST_F(CryptoModulePasswordDialogViewTest, TestAccept) { ...@@ -56,5 +54,3 @@ TEST_F(CryptoModulePasswordDialogViewTest, TestAccept) {
const base::string16 empty; const base::string16 empty;
EXPECT_EQ(empty, dialog_->password_entry_->text()); EXPECT_EQ(empty, dialog_->password_entry_->text());
} }
} // namespace chrome
...@@ -582,7 +582,7 @@ void CertificatesHandler::HandleExportPersonalPasswordSelected( ...@@ -582,7 +582,7 @@ void CertificatesHandler::HandleExportPersonalPasswordSelected(
// TODO(mattm): do something smarter about non-extractable keys // TODO(mattm): do something smarter about non-extractable keys
chrome::UnlockCertSlotIfNecessary( chrome::UnlockCertSlotIfNecessary(
selected_cert_list_[0].get(), chrome::kCryptoModulePasswordCertExport, selected_cert_list_[0].get(), kCryptoModulePasswordCertExport,
net::HostPortPair(), // unused. net::HostPortPair(), // unused.
GetParentWindow(), GetParentWindow(),
base::Bind(&CertificatesHandler::ExportPersonalSlotsUnlocked, base::Bind(&CertificatesHandler::ExportPersonalSlotsUnlocked,
...@@ -719,7 +719,7 @@ void CertificatesHandler::HandleImportPersonalPasswordSelected( ...@@ -719,7 +719,7 @@ void CertificatesHandler::HandleImportPersonalPasswordSelected(
std::vector<crypto::ScopedPK11Slot> modules; std::vector<crypto::ScopedPK11Slot> modules;
modules.push_back(crypto::ScopedPK11Slot(PK11_ReferenceSlot(slot_.get()))); modules.push_back(crypto::ScopedPK11Slot(PK11_ReferenceSlot(slot_.get())));
chrome::UnlockSlotsIfNecessary( chrome::UnlockSlotsIfNecessary(
std::move(modules), chrome::kCryptoModulePasswordCertImport, std::move(modules), kCryptoModulePasswordCertImport,
net::HostPortPair(), // unused. net::HostPortPair(), // unused.
GetParentWindow(), GetParentWindow(),
base::Bind(&CertificatesHandler::ImportPersonalSlotUnlocked, base::Bind(&CertificatesHandler::ImportPersonalSlotUnlocked,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment