Commit 611c9a6a authored by Roberto Carrillo's avatar Roberto Carrillo Committed by Commit Bot

Accept resultdb_bigquery_exports parameter in builder(...).

Also, enable test results export to BQ on CI builders in the dev
instance of buildbucket.

R=vadimsh,nodir,chanli

Bug: 1048825
Change-Id: I8135072708114962306b21f6293767c7db23368a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153932
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: default avatarNodir Turakulov <nodir@chromium.org>
Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Auto-Submit: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760185}
parent 8e0d3fd1
...@@ -49,6 +49,9 @@ def ci_builder(*, name, **kwargs): ...@@ -49,6 +49,9 @@ def ci_builder(*, name, **kwargs):
return builder( return builder(
name = name, name = name,
triggered_by = ['master-gitiles-trigger'], triggered_by = ['master-gitiles-trigger'],
resultdb_bigquery_exports = [resultdb.export_test_results(
bq_table = 'luci-resultdb-dev.chromium.ci_test_results',
)],
**kwargs **kwargs
) )
......
...@@ -39,6 +39,12 @@ buckets: < ...@@ -39,6 +39,12 @@ buckets: <
service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com" service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com"
resultdb: < resultdb: <
enable: true enable: true
bq_exports: <
project: "luci-resultdb-dev"
dataset: "chromium"
table: "ci_test_results"
test_results: <>
>
> >
> >
builders: < builders: <
...@@ -58,6 +64,12 @@ buckets: < ...@@ -58,6 +64,12 @@ buckets: <
service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com" service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com"
resultdb: < resultdb: <
enable: true enable: true
bq_exports: <
project: "luci-resultdb-dev"
dataset: "chromium"
table: "ci_test_results"
test_results: <>
>
> >
> >
builders: < builders: <
...@@ -77,6 +89,12 @@ buckets: < ...@@ -77,6 +89,12 @@ buckets: <
service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com" service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com"
resultdb: < resultdb: <
enable: true enable: true
bq_exports: <
project: "luci-resultdb-dev"
dataset: "chromium"
table: "ci_test_results"
test_results: <>
>
> >
> >
builders: < builders: <
...@@ -96,6 +114,12 @@ buckets: < ...@@ -96,6 +114,12 @@ buckets: <
service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com" service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com"
resultdb: < resultdb: <
enable: true enable: true
bq_exports: <
project: "luci-resultdb-dev"
dataset: "chromium"
table: "ci_test_results"
test_results: <>
>
> >
> >
builders: < builders: <
...@@ -115,6 +139,12 @@ buckets: < ...@@ -115,6 +139,12 @@ buckets: <
service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com" service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com"
resultdb: < resultdb: <
enable: true enable: true
bq_exports: <
project: "luci-resultdb-dev"
dataset: "chromium"
table: "ci_test_results"
test_results: <>
>
> >
> >
builders: < builders: <
...@@ -134,6 +164,12 @@ buckets: < ...@@ -134,6 +164,12 @@ buckets: <
service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com" service_account: "chromium-ci-builder-dev@chops-service-accounts.iam.gserviceaccount.com"
resultdb: < resultdb: <
enable: true enable: true
bq_exports: <
project: "luci-resultdb-dev"
dataset: "chromium"
table: "ci_test_results"
test_results: <>
>
> >
> >
> >
......
...@@ -221,6 +221,7 @@ defaults = args.defaults( ...@@ -221,6 +221,7 @@ defaults = args.defaults(
ssd = args.COMPUTE, ssd = args.COMPUTE,
use_clang_coverage = False, use_clang_coverage = False,
use_java_coverage = False, use_java_coverage = False,
resultdb_bigquery_exports = [],
should_exonerate_flaky_failures = False, should_exonerate_flaky_failures = False,
# Provide vars for bucket and executable so users don't have to # Provide vars for bucket and executable so users don't have to
...@@ -255,6 +256,7 @@ def builder( ...@@ -255,6 +256,7 @@ def builder(
goma_jobs=args.DEFAULT, goma_jobs=args.DEFAULT,
use_clang_coverage=args.DEFAULT, use_clang_coverage=args.DEFAULT,
use_java_coverage=args.DEFAULT, use_java_coverage=args.DEFAULT,
resultdb_bigquery_exports=args.DEFAULT,
should_exonerate_flaky_failures=args.DEFAULT, should_exonerate_flaky_failures=args.DEFAULT,
**kwargs): **kwargs):
"""Define a builder. """Define a builder.
...@@ -331,6 +333,9 @@ def builder( ...@@ -331,6 +333,9 @@ def builder(
'$build/code_coverage' property. By default, considered False. '$build/code_coverage' property. By default, considered False.
* should_exonerate_flaky_failures - a boolean indicathing whether the * should_exonerate_flaky_failures - a boolean indicathing whether the
builder should exonerate a test failure if it's known to be flaky on ToT. builder should exonerate a test failure if it's known to be flaky on ToT.
* resultdb_bigquery_exports - a list of resultdb.export_test_results(...)
specifying parameters for exporting test results to BigQuery. By default,
do not export.
* kwargs - Additional keyword arguments to forward on to `luci.builder`. * kwargs - Additional keyword arguments to forward on to `luci.builder`.
""" """
# We don't have any need of an explicit dimensions dict, # We don't have any need of an explicit dimensions dict,
...@@ -446,6 +451,8 @@ def builder( ...@@ -446,6 +451,8 @@ def builder(
properties = properties, properties = properties,
resultdb_settings = resultdb.settings( resultdb_settings = resultdb.settings(
enable = True, enable = True,
bq_exports = defaults.get_value(
'resultdb_bigquery_exports', resultdb_bigquery_exports),
), ),
**kwargs **kwargs
) )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment