Commit 6137a19b authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

logging.h related include-what-you-use (google_apis/)

Fix code that was implicitly depending on logging.h or its
dependencies.

For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.

This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.

Bug: 1031540
Change-Id: If0ae65768b8b03077e06c70d37a221b7a4392971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157085
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760538}
parent d0dfddf6
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
#include <string> #include <string>
#include "base/macros.h"
#include "base/time/time.h" #include "base/time/time.h"
class GoogleServiceAuthError; class GoogleServiceAuthError;
......
...@@ -4,12 +4,14 @@ ...@@ -4,12 +4,14 @@
#include "google_apis/gaia/oauth2_id_token_decoder.h" #include "google_apis/gaia/oauth2_id_token_decoder.h"
#include <base/base64url.h>
#include <base/json/json_reader.h>
#include <base/strings/string_split.h>
#include <base/values.h>
#include <memory> #include <memory>
#include "base/base64url.h"
#include "base/json/json_reader.h"
#include "base/logging.h"
#include "base/strings/string_split.h"
#include "base/values.h"
namespace { namespace {
// The name of the service flag that defines the account is Unicorn. // The name of the service flag that defines the account is Unicorn.
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "base/json/json_reader.h" #include "base/json/json_reader.h"
#include "base/logging.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "base/optional.h" #include "base/optional.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include <stdint.h> #include <stdint.h>
#include "base/logging.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h" #include "base/strings/string_split.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment