Tests for supervised users password sync:

First two test cases:
  password change detected when SU is signed in, only su is signed in after
  password change is detected when manager is signed in.

R=nkostylev@chromium.org

BUG=354607

Review URL: https://codereview.chromium.org/243103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266892 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/chromeos/login/managed/managed_user_creation_browsertest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "base/run_loop.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/threading/sequenced_worker_pool.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/chromeos/login/login_display_host_impl.h"
+#include "chrome/browser/chromeos/login/login_manager_test.h"
+#include "chrome/browser/chromeos/login/managed/managed_user_test_base.h"
+#include "chrome/browser/chromeos/login/managed/supervised_user_authentication.h"
+#include "chrome/browser/chromeos/login/startup_utils.h"
+#include "chrome/browser/chromeos/login/supervised_user_manager.h"
+#include "chrome/browser/chromeos/login/webui_login_view.h"
+#include "chrome/browser/chromeos/net/network_portal_detector_test_impl.h"
+#include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h"
+#include "chrome/browser/managed_mode/managed_user_constants.h"
+#include "chrome/browser/managed_mode/managed_user_registration_utility.h"
+#include "chrome/browser/managed_mode/managed_user_registration_utility_stub.h"
+#include "chrome/browser/managed_mode/managed_user_shared_settings_service.h"
+#include "chrome/browser/managed_mode/managed_user_shared_settings_service_factory.h"
+#include "chrome/browser/managed_mode/managed_user_sync_service.h"
+#include "chrome/browser/managed_mode/managed_user_sync_service_factory.h"
+#include "chromeos/cryptohome/mock_async_method_caller.h"
+#include "chromeos/cryptohome/mock_homedir_methods.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/test/browser_test_utils.h"
+#include "content/public/test/test_utils.h"
+#include "sync/api/attachments/attachment_service_proxy_for_test.h"
+#include "sync/api/fake_sync_change_processor.h"
+#include "sync/api/sync_change.h"
+#include "sync/api/sync_error_factory_mock.h"
+#include "sync/protocol/sync.pb.h"
+
+using testing::_;
+using chromeos::testing::ManagedUserTestBase;
+using chromeos::testing::kTestSupervisedUserDisplayName;
+using chromeos::testing::kTestManager;
+
+namespace chromeos {
+
+class SupervisedUserCreationTest : public ManagedUserTestBase {
+ public:
+  SupervisedUserCreationTest() : ManagedUserTestBase() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SupervisedUserCreationTest);
+};
+
+class SupervisedUserTransactionCleanupTest : public ManagedUserTestBase {
+ public:
+  SupervisedUserTransactionCleanupTest() : ManagedUserTestBase() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SupervisedUserTransactionCleanupTest);
+};
+
+class SupervisedUserOwnerCreationTest : public ManagedUserTestBase {
+ public:
+  SupervisedUserOwnerCreationTest() : ManagedUserTestBase() {}
+
+  virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
+    ManagedUserTestBase::SetUpInProcessBrowserTestFixture();
+    cros_settings_provider_.reset(new StubCrosSettingsProvider());
+    cros_settings_provider_->Set(kDeviceOwner, base::StringValue(kTestManager));
+  }
+
+ private:
+  scoped_ptr<StubCrosSettingsProvider> cros_settings_provider_;
+  DISALLOW_COPY_AND_ASSIGN(SupervisedUserOwnerCreationTest);
+};
+
+class SupervisedUserTransactionCleanupTest2
+    : public SupervisedUserTransactionCleanupTest {
+ public:
+  SupervisedUserTransactionCleanupTest2()
+      : SupervisedUserTransactionCleanupTest() {}
+
+  virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
+    SupervisedUserTransactionCleanupTest::SetUpInProcessBrowserTestFixture();
+    EXPECT_CALL(*mock_async_method_caller_, AsyncRemove(_, _)).Times(1);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SupervisedUserTransactionCleanupTest2);
+};
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserCreationTest,
+                       PRE_PRE_PRE_CreateAndRemoveSupervisedUser) {
+  PrepareUsers();
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserCreationTest,
+                       PRE_PRE_CreateAndRemoveSupervisedUser) {
+  StartFlowLoginAsManager();
+  FillNewUserData(kTestSupervisedUserDisplayName);
+  StartUserCreation("managed-user-creation-next-button",
+                    kTestSupervisedUserDisplayName);
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserCreationTest,
+                       PRE_CreateAndRemoveSupervisedUser) {
+  SigninAsSupervisedUser(true, 0, kTestSupervisedUserDisplayName);
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserCreationTest,
+                       CreateAndRemoveSupervisedUser) {
+  RemoveSupervisedUser(3, 0, kTestSupervisedUserDisplayName);
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserOwnerCreationTest,
+                       PRE_PRE_PRE_CreateAndRemoveSupervisedUser) {
+  PrepareUsers();
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserOwnerCreationTest,
+                       PRE_PRE_CreateAndRemoveSupervisedUser) {
+  StartFlowLoginAsManager();
+  FillNewUserData(kTestSupervisedUserDisplayName);
+  StartUserCreation("managed-user-creation-next-button",
+                    kTestSupervisedUserDisplayName);
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserOwnerCreationTest,
+                       PRE_CreateAndRemoveSupervisedUser) {
+  SigninAsSupervisedUser(true, 0, kTestSupervisedUserDisplayName);
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserOwnerCreationTest,
+                       CreateAndRemoveSupervisedUser) {
+  RemoveSupervisedUser(3, 0, kTestSupervisedUserDisplayName);
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserTransactionCleanupTest,
+                       PRE_PRE_CreateAndCancelSupervisedUser) {
+  PrepareUsers();
+}
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserTransactionCleanupTest,
+                       PRE_CreateAndCancelSupervisedUser) {
+  StartFlowLoginAsManager();
+  FillNewUserData(kTestSupervisedUserDisplayName);
+
+  EXPECT_CALL(*mock_homedir_methods_, MountEx(_, _, _, _)).Times(1);
+  EXPECT_CALL(*mock_homedir_methods_, AddKeyEx(_, _, _, _, _)).Times(1);
+
+  JSEval("$('managed-user-creation-next-button').click()");
+
+  ::testing::Mock::VerifyAndClearExpectations(mock_homedir_methods_);
+
+  EXPECT_TRUE(registration_utility_stub_->register_was_called());
+  EXPECT_EQ(registration_utility_stub_->display_name(),
+            base::UTF8ToUTF16(kTestSupervisedUserDisplayName));
+
+  std::string user_id = registration_utility_stub_->managed_user_id();
+
+  // Make sure user is already in list.
+  ASSERT_EQ(3UL, UserManager::Get()->GetUsers().size());
+
+  // We wait for token now. Press cancel button at this point.
+  JSEval("$('cancel-add-user-button').click()");
+}
+
+IN_PROC_BROWSER_TEST_(
+    SupervisedUserTransactionCleanupTest,
+    CreateAndCancelSupervisedUser,
+    SupervisedUserTransactionCleanupTest2,
+    ::testing::internal::GetTypeId<SupervisedUserTransactionCleanupTest>()) {
+  // Make sure there is no supervised user in list.
+  ASSERT_EQ(2UL, UserManager::Get()->GetUsers().size());
+}
+
+}  // namespace chromeos

chrome/browser/chromeos/login/managed/managed_user_test_base.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_MANAGED_MANAGED_USER_TEST_BASE_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_MANAGED_MANAGED_USER_TEST_BASE_H_
+
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/chromeos/login/login_manager_test.h"
+#include "chrome/browser/chromeos/net/network_portal_detector_test_impl.h"
+#include "chrome/browser/managed_mode/managed_user_registration_utility_stub.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chromeos/cryptohome/mock_async_method_caller.h"
+#include "chromeos/cryptohome/mock_homedir_methods.h"
+#include "sync/api/fake_sync_change_processor.h"
+#include "sync/api/sync_change.h"
+#include "sync/api/sync_error_factory_mock.h"
+#include "sync/protocol/sync.pb.h"
+
+namespace chromeos {
+
+namespace testing {
+
+const char kStubEthernetServicePath[] = "eth0";
+
+const char kTestManager[] = "test-manager@gmail.com";
+const char kTestOtherUser[] = "test-user@gmail.com";
+
+const char kTestManagerPassword[] = "password";
+const char kTestSupervisedUserDisplayName[] = "John Doe";
+const char kTestSupervisedUserPassword[] = "simplepassword";
+
+class ManagedUsersSyncTestAdapter {
+ public:
+  explicit ManagedUsersSyncTestAdapter(Profile* profile);
+
+  bool HasChanges() { return !processor_->changes().empty(); }
+
+  scoped_ptr< ::sync_pb::ManagedUserSpecifics> GetFirstChange();
+
+  void AddChange(const ::sync_pb::ManagedUserSpecifics& proto, bool update);
+
+  syncer::FakeSyncChangeProcessor* processor_;
+  ManagedUserSyncService* service_;
+  int next_sync_data_id_;
+};
+
+class ManagedUsersSharedSettingsSyncTestAdapter {
+ public:
+  explicit ManagedUsersSharedSettingsSyncTestAdapter(Profile* profile);
+
+  bool HasChanges() { return !processor_->changes().empty(); }
+
+  scoped_ptr< ::sync_pb::ManagedUserSharedSettingSpecifics> GetFirstChange();
+
+  void AddChange(const ::sync_pb::ManagedUserSharedSettingSpecifics& proto,
+                 bool update);
+
+  void AddChange(const std::string& mu_id,
+                 const std::string& key,
+                 const base::Value& value,
+                 bool acknowledged,
+                 bool update);
+
+  syncer::FakeSyncChangeProcessor* processor_;
+  ManagedUserSharedSettingsService* service_;
+  int next_sync_data_id_;
+};
+
+class ManagedUserTestBase : public chromeos::LoginManagerTest {
+ public:
+  ManagedUserTestBase();
+  virtual ~ManagedUserTestBase();
+
+  virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
+  virtual void CleanUpOnMainThread() OVERRIDE;
+
+ protected:
+  virtual void TearDown() OVERRIDE;
+
+  virtual void TearDownInProcessBrowserTestFixture() OVERRIDE;
+
+  void JSEval(const std::string& script);
+
+  void JSExpectAsync(const std::string& function);
+
+  void JSSetTextField(const std::string& element_selector,
+                      const std::string& value);
+
+  void PrepareUsers();
+  void StartFlowLoginAsManager();
+  void FillNewUserData(const std::string& display_name);
+  void StartUserCreation(const std::string& button_id,
+                         const std::string& expected_display_name);
+  void SigninAsSupervisedUser(bool check_homedir_calls,
+                              int user_index,
+                              const std::string& expected_display_name);
+  void SigninAsManager(int user_index);
+  void RemoveSupervisedUser(unsigned long original_user_count,
+                            int user_index,
+                            const std::string& expected_display_name);
+
+  cryptohome::MockAsyncMethodCaller* mock_async_method_caller_;
+  cryptohome::MockHomedirMethods* mock_homedir_methods_;
+  NetworkPortalDetectorTestImpl* network_portal_detector_;
+  ManagedUserRegistrationUtilityStub* registration_utility_stub_;
+  scoped_ptr<ScopedTestingManagedUserRegistrationUtility> scoped_utility_;
+  scoped_ptr<ManagedUsersSharedSettingsSyncTestAdapter>
+      shared_settings_adapter_;
+  scoped_ptr<ManagedUsersSyncTestAdapter> managed_users_adapter_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ManagedUserTestBase);
+};
+
+}  // namespace testing
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_LOGIN_MANAGED_MANAGED_USER_TEST_BASE_H_

chrome/chrome_tests.gypi

@@ -911,7 +911,10 @@
         'browser/chromeos/login/login_utils_browsertest.cc',
         'browser/chromeos/login/login_manager_test.cc',
         'browser/chromeos/login/login_manager_test.h',
-        'browser/chromeos/login/managed/supervised_user_creation_browsertest.cc',
+        'browser/chromeos/login/managed/managed_user_creation_browsertest.cc',
+        'browser/chromeos/login/managed/managed_user_password_browsertest.cc',
+        'browser/chromeos/login/managed/managed_user_test_base.cc',
+        'browser/chromeos/login/managed/managed_user_test_base.h',
         'browser/chromeos/login/mock_authenticator.cc',
         'browser/chromeos/login/mock_authenticator.h',
         'browser/chromeos/login/oauth2_browsertest.cc',