[Signin][Android] Remove dead code from RecentTabsManager

This CL removes the last usages of
SigninPromoController.arePersonalizedPromosEnabled and the method
itself.

Bug: 792430
Change-Id: Ib169667f755d87fc170b121654c59d50cb5d2b8e
Reviewed-on: https://chromium-review.googlesource.com/844318Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526506}

chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

@@ -8,7 +8,6 @@ import android.accounts.Account;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.support.annotation.IntDef;
-import android.support.annotation.Nullable;
 
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
@@ -82,8 +81,8 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
     private UpdatedCallback mUpdatedCallback;
     private boolean mIsDestroyed;
 
-    private final @Nullable ProfileDataCache mProfileDataCache;
-    private final @Nullable SigninPromoController mSigninPromoController;
+    private final ProfileDataCache mProfileDataCache;
+    private final SigninPromoController mSigninPromoController;
 
     /**
      * Create an RecentTabsManager to be used with RecentTabsPage and RecentTabsRowAdapter.
@@ -104,14 +103,9 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
         mSignInManager = SigninManager.get(context);
         mContext = context;
 
-        if (SigninPromoController.arePersonalizedPromosEnabled()) {
-            int imageSize = context.getResources().getDimensionPixelSize(R.dimen.user_picture_size);
-            mProfileDataCache = new ProfileDataCache(mContext, imageSize);
-            mSigninPromoController = new SigninPromoController(SigninAccessPoint.RECENT_TABS);
-        } else {
-            mProfileDataCache = null;
-            mSigninPromoController = null;
-        }
+        int imageSize = context.getResources().getDimensionPixelSize(R.dimen.user_picture_size);
+        mProfileDataCache = new ProfileDataCache(mContext, imageSize);
+        mSigninPromoController = new SigninPromoController(SigninAccessPoint.RECENT_TABS);
 
         mRecentlyClosedTabManager.setTabsUpdatedRunnable(() -> {
             updateRecentlyClosedTabs();
@@ -137,10 +131,8 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
         mSignInManager.removeSignInStateObserver(this);
         mSignInManager = null;
 
-        if (mSigninPromoController != null) {
-            mProfileDataCache.removeObserver(this);
-            AccountManagerFacade.get().removeObserver(this);
-        }
+        mProfileDataCache.removeObserver(this);
+        AccountManagerFacade.get().removeObserver(this);
 
         mFaviconHelper.destroy();
         mFaviconHelper = null;
@@ -170,10 +162,8 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
         AndroidSyncSettings.registerObserver(mContext, this);
         mSignInManager.addSignInStateObserver(this);
 
-        if (mSigninPromoController != null) {
-            mProfileDataCache.addObserver(this);
-            AccountManagerFacade.get().addObserver(this);
-        }
+        mProfileDataCache.addObserver(this);
+        AccountManagerFacade.get().addObserver(this);
     }
 
     private void updateRecentlyClosedTabs() {

chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoController.java

@@ -67,14 +67,6 @@ public class SigninPromoController {
     private boolean mWasDisplayed;
     private boolean mWasUsed;
 
-    /**
-     * @return Whether the personalized promos experiment is enabled or not.
-     */
-    public static boolean arePersonalizedPromosEnabled() {
-        // TODO(https://crbug.com/792430): Remove this method and dead code for old promos.
-        return true;
-    }
-
     /**
      * Determines whether the impression limit has been reached for the given access point.
      * @param accessPoint The access point for which the impression limit is being checked.