Commit 61771114 authored by Yuki Yamada's avatar Yuki Yamada Committed by Commit Bot

Sheriff: Disable tests for specific platforms

I've disabled some tests for all the platforms, but they had problems
only with specific platforms. This is a follow-up for these CLs:
https://crrev.com/c/2556621
https://crrev.com/c/2557065
https://crrev.com/c/2557279

TBR=dpapad@chromium.org,bugsnash@chromium.org,rohitrao@chromium.org

No-Try: true
Bug: 1152287, 1152318, 1152289
Change-Id: If24633596f23ae8f53447b02b2232dd44eed9761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557284Reviewed-by: default avatarYuki Yamada <yukiy@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830513}
parent 1951a33e
...@@ -213,9 +213,14 @@ IN_PROC_BROWSER_TEST_P(MediaAppIntegrationTest, LoadsPdf) { ...@@ -213,9 +213,14 @@ IN_PROC_BROWSER_TEST_P(MediaAppIntegrationTest, LoadsPdf) {
} }
// Test that the MediaApp can load RAW files passed on launch params. // Test that the MediaApp can load RAW files passed on launch params.
// Disabled because it fails randomly on linux-chromeos-chrome. // Disabled on ChromeOS because it fails randomly on linux-chromeos-chrome.
// See: https://crbug.com/1152318 // See: https://crbug.com/1152318
IN_PROC_BROWSER_TEST_P(MediaAppIntegrationTest, DISABLED_HandleRawFiles) { #if defined(OS_CHROMEOS)
#define MAYBE_HandleRawFiles DISABLED_HandleRawFiles
#else
#define MAYBE_HandleRawFiles HandleRawFiles
#endif
IN_PROC_BROWSER_TEST_P(MediaAppIntegrationTest, MAYBE_HandleRawFiles) {
WaitForTestSystemAppInstall(); WaitForTestSystemAppInstall();
content::WebContents* web_ui; content::WebContents* web_ui;
......
...@@ -40,8 +40,14 @@ var TabSearchAppTest = class extends TabSearchBrowserTest { ...@@ -40,8 +40,14 @@ var TabSearchAppTest = class extends TabSearchBrowserTest {
} }
}; };
// https://crbug.com/1152287 // Disabled on Windows because of random crash on Win 7 Tests x64 (1).
TEST_F('TabSearchAppTest', 'DISABLED_All', function() { // See: https://crbug.com/1152287
GEN('#if defined(OS_WIN)');
GEN('#define MAYBE_All DISABLED_All');
GEN('#else');
GEN('#define MAYBE_All All');
GEN('#endif');
TEST_F('TabSearchAppTest', 'MAYBE_All', function() {
mocha.run(); mocha.run();
}); });
......
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/task/post_task.h" #include "base/task/post_task.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "build/build_config.h"
#include "components/browsing_data/core/browsing_data_utils.h" #include "components/browsing_data/core/browsing_data_utils.h"
#include "components/browsing_data/core/pref_names.h" #include "components/browsing_data/core/pref_names.h"
#include "components/prefs/testing_pref_service.h" #include "components/prefs/testing_pref_service.h"
...@@ -239,9 +240,14 @@ class CacheCounterTest : public PlatformTest { ...@@ -239,9 +240,14 @@ class CacheCounterTest : public PlatformTest {
}; };
// Tests that for the empty cache, the result is zero. // Tests that for the empty cache, the result is zero.
// Disabled because this test randomly crashes on Win 7 Tests x64 (1). // Disabled on Windows because this test randomly crashes on Win 7 Tests x64
// See: https://crbug.com/1152289 // (1). See: https://crbug.com/1152289
TEST_F(CacheCounterTest, DISABLED_Empty) { #if defined(OS_WIN)
#define MAYBE_Empty DISABLED_Empty
#else
#define MAYBE_Empty Empty
#endif
TEST_F(CacheCounterTest, MAYBE_Empty) {
CacheCounter counter(browser_state()); CacheCounter counter(browser_state());
counter.Init(prefs(), browsing_data::ClearBrowsingDataTab::ADVANCED, counter.Init(prefs(), browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&CacheCounterTest::CountingCallback, base::BindRepeating(&CacheCounterTest::CountingCallback,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment