Commit 617b22e9 authored by liberato@chromium.org's avatar liberato@chromium.org Committed by Commit Bot

Turn off nine flaky GCMDriver tests.

GCMDriverFunctionalTest.UnregisterWhenAsyncOperationPending
GCMDriverTest.GCMClientNotReadyBeforeRegistration
GCMDriverFunctionalTest.Register
GCMClientImplTest.RegisterAgainWhenTokenIsFresh
GCMClientImplTest.DispatchDownstreamMessageSendError
GCMClientInstanceIDTest.DeleteAllTokens
GCMClientImplStartAndStopTest.DelayedStartRace
GCMClientImplStartAndStopTest.StartStopAndRestart
GCMClientInstanceIDTest.GetToken

Bug: 1009586
Change-Id: Id9a51969b6d4cd2caa63c8689faf8f9be31fbf69
TBR: fgorski@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829674Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701269}
parent b2765d8f
......@@ -950,7 +950,7 @@ TEST_F(GCMClientImplTest, RegisterPreviousSenderAgain) {
EXPECT_TRUE(ExistsRegistration(kExtensionAppId));
}
TEST_F(GCMClientImplTest, RegisterAgainWhenTokenIsFresh) {
TEST_F(GCMClientImplTest, DISABLED_RegisterAgainWhenTokenIsFresh) {
// Register a sender.
std::vector<std::string> senders;
senders.push_back("sender");
......@@ -1102,7 +1102,7 @@ TEST_F(GCMClientImplTest, DispatchDownstreamMessageRawData) {
EXPECT_EQ(kRawData, last_message().raw_data);
}
TEST_F(GCMClientImplTest, DispatchDownstreamMessageSendError) {
TEST_F(GCMClientImplTest, DISABLED_DispatchDownstreamMessageSendError) {
std::map<std::string, std::string> expected_data = {
{"message_type", "send_error"}, {"error_details", "some details"}};
......@@ -1429,7 +1429,7 @@ void GCMClientImplStartAndStopTest::DefaultCompleteCheckin() {
PumpLoopUntilIdle();
}
TEST_F(GCMClientImplStartAndStopTest, StartStopAndRestart) {
TEST_F(GCMClientImplStartAndStopTest, DISABLED_StartStopAndRestart) {
// GCMClientImpl should be in INITIALIZED state at first.
EXPECT_EQ(GCMClientImpl::INITIALIZED, gcm_client_state());
......@@ -1543,7 +1543,7 @@ TEST_F(GCMClientImplStartAndStopTest, ImmediateStartAndThenDelayStart) {
EXPECT_EQ(GCMClientImpl::LOADED, gcm_client_state());
}
TEST_F(GCMClientImplStartAndStopTest, DelayedStartRace) {
TEST_F(GCMClientImplStartAndStopTest, DISABLED_DelayedStartRace) {
// GCMClientImpl should be in INITIALIZED state at first.
EXPECT_EQ(GCMClientImpl::INITIALIZED, gcm_client_state());
......@@ -1849,7 +1849,7 @@ TEST_F(GCMClientInstanceIDTest, DeleteSingleToken) {
EXPECT_EQ(GCMClient::INVALID_PARAMETER, last_result());
}
TEST_F(GCMClientInstanceIDTest, DeleteAllTokens) {
TEST_F(GCMClientInstanceIDTest, DISABLED_DeleteAllTokens) {
AddInstanceID(kExtensionAppId, kInstanceID);
// Get a token.
......
......@@ -520,7 +520,7 @@ TEST_F(GCMDriverTest, SendFailed) {
EXPECT_EQ(GCMClient::GCM_DISABLED, send_result());
}
TEST_F(GCMDriverTest, GCMClientNotReadyBeforeRegistration) {
TEST_F(GCMDriverTest, DISABLED_GCMClientNotReadyBeforeRegistration) {
CreateDriver();
PumpIOLoop();
PumpUILoop();
......@@ -607,7 +607,7 @@ void GCMDriverFunctionalTest::SetUp() {
PumpUILoop();
}
TEST_F(GCMDriverFunctionalTest, Register) {
TEST_F(GCMDriverFunctionalTest, DISABLED_Register) {
std::vector<std::string> sender_ids;
sender_ids.push_back("sender1");
Register(kTestAppID1, sender_ids, GCMDriverTest::WAIT);
......@@ -728,7 +728,7 @@ TEST_F(GCMDriverFunctionalTest, UnregisterRemovesEncryptionInfo) {
EXPECT_NE(app_auth_secret, auth_secret());
}
TEST_F(GCMDriverFunctionalTest, UnregisterWhenAsyncOperationPending) {
TEST_F(GCMDriverFunctionalTest, DISABLED_UnregisterWhenAsyncOperationPending) {
std::vector<std::string> sender_ids;
sender_ids.push_back("sender1");
// First start registration without waiting for it to complete.
......@@ -1306,7 +1306,7 @@ TEST_F(GCMDriverInstanceIDTest, GCMClientNotReadyBeforeInstanceIDData) {
EXPECT_EQ("Bar", extra_data());
}
TEST_F(GCMDriverInstanceIDTest, GetToken) {
TEST_F(GCMDriverInstanceIDTest, DISABLED_GetToken) {
GetReady();
const std::string expected_token =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment