Commit 617dfcdd authored by Yi Gu's avatar Yi Gu Committed by Commit Bot

[ScrollTimeline] Run tests on cc if threaded compositing is enabled

The scroller in the updated tests is not composited by default. When we
run the tests with the virtual/threaded test suite, the tests can not
properly run on the compositor because cc::ScrollTimeline is considered
as inactive, i.e. scroller is not in cc::ScrollTree because it's not
composited.

This patch forces compositing the scrollers if the animation needs to
play.

Note that once all ScrollNodes including uncomposited ones are in the
compositor after the scroll unification (crbug.com/476553), we no longer
need to add will-change to the scrollers.

Bug: None
Change-Id: I0e379abb071c9bffc58f2167f4cac9f92edbb9da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211048Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771161}
parent 38cff7fc
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
overflow: scroll; overflow: scroll;
height: 500px; height: 500px;
width: 500px; width: 500px;
will-change: transform;
} }
/* Disable scrollbars to simplify the calculations in the test. */ /* Disable scrollbars to simplify the calculations in the test. */
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
overflow: auto; overflow: auto;
height: 500px; height: 500px;
width: 500px; width: 500px;
will-change: transform;
} }
.contents { .contents {
......
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
overflow: auto; overflow: auto;
height: 200px; height: 200px;
width: 100px; width: 100px;
will-change: transform;
} }
.contents { .contents {
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
overflow: auto; overflow: auto;
height: 100px; height: 100px;
width: 100px; width: 100px;
will-change: transform;
} }
.contents { .contents {
height: 1000px; height: 1000px;
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
overflow: auto; overflow: auto;
height: 100px; height: 100px;
width: 100px; width: 100px;
will-change: transform;
} }
.contents { .contents {
height: 1000px; height: 1000px;
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
overflow: auto; overflow: auto;
height: 100px; height: 100px;
width: 100px; width: 100px;
will-change: transform;
} }
.contents { .contents {
height: 1000px; height: 1000px;
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
overflow: auto; overflow: auto;
height: 200px; height: 200px;
width: 100px; width: 100px;
will-change: transform;
} }
.contents { .contents {
height: 1000px; height: 1000px;
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
overflow: auto; overflow: auto;
height: 100px; height: 100px;
width: 100px; width: 100px;
will-change: transform;
} }
.contents { .contents {
height: 1000px; height: 1000px;
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
overflow: auto; overflow: auto;
height: 200px; height: 200px;
width: 100px; width: 100px;
will-change: transform;
} }
.contents { .contents {
height: 1000px; height: 1000px;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment