Skip to content

GitLab

T
tangled
Commit 61b14954 authored by yhirano's avatar yhirano Committed by Commit bot
Browse files
Options

Remove http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html 

The test is essentially flaky and we are unable to fix it.

BUG=518988, 143475
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2570503004
Cr-Commit-Position: refs/heads/master@{#438134}
parent 3eb04723
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 111 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ 61b14954
......@@ -705,7 +705,6 @@ crbug.com/410974 virtual/threaded/fast/scroll-behavior/scroll-customization/touc
crbug.com/518883 crbug.com/390452 http/tests/security/isolatedWorld/media-query-wrapper-leaks.html [ Failure Pass Timeout ]
crbug.com/518883 crbug.com/390452 virtual/mojo-loading/http/tests/security/isolatedWorld/media-query-wrapper-leaks.html [ Failure Pass Timeout ]
crbug.com/518987 http/tests/xmlhttprequest/navigation-abort-detaches-frame.html [ Pass Timeout ]
crbug.com/518988 [ Win7 ] http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html [ Failure Pass ]
crbug.com/518989 [ Mac ] imported/csswg-test/css-writing-modes-3/writing-mode-vertical-rl-002.xht [ Failure Pass Timeout ]
crbug.com/518998 media/video-poster-after-loadedmetadata.html [ Failure Pass ]
crbug.com/673296 [ Android ] inspector-protocol/input/dispatchMouseEvent.html [ Pass Timeout ]
......@@ -1859,11 +1858,6 @@ crbug.com/669357 virtual/mojo-loading/http/tests/inspector/tracing/timeline-rece
crbug.com/669357 virtual/mojo-loading/http/tests/inspector/tracing/timeline-network-received-data.html [ Failure ]
crbug.com/669357 virtual/mojo-loading/http/tests/local/formdata/upload-events.html [ Failure ]
# TODO(yhirano): There is an entry for the base test, but this test is flakier
# than that. Fix this test so that we can move the entry to the base test
# section.
crbug.com/659917 virtual/mojo-loading/http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html [ Failure Pass ]
crbug.com/664873 http/tests/xmlhttprequest/small-chunks-response-text.html [ Failure Pass ]
crbug.com/664873 virtual/mojo-loading/http/tests/xmlhttprequest/small-chunks-response-text.html [ Failure Pass ]
......
third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch-expected.txt deleted 100644 → 0
View file @ 3eb04723
Test case for Bug 18655: [XHR] onProgress event needs to be dispatched according to what the specification states
This test verify that we "dispatch a progress event called progress about every 50ms or for every byte received, whichever is least frequent".
You should see a sequence of 5 PASSED.
PASSED
PASSED
PASSED
PASSED
PASSED
third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html deleted 100644 → 0
View file @ 3eb04723
<html>
<head>
<title> Test case for bug 18655 </title>
</head>
<body>
<p> Test case for Bug <a href="https://bugs.webkit.org/show_bug.cgi?id=18655">18655</a>: [XHR] onProgress event
needs to be dispatched according to what the specification states </p>
<p> This test verify that we "dispatch a progress event called progress about
every 50ms or for every byte received, whichever is least frequent".</p>
<p> You should see a sequence of 5 PASSED. </p>
<p id="console"></p>
<script type="text/javascript">
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.waitUntilDone();
}
function log(message)
{
document.getElementById("console").appendChild(document.createTextNode(message));
document.getElementById("console").appendChild(document.createElement("br"));
}
var testsCompleted = 0;
function test(iteration, delay, compare, testDescription)
{
var count = 0;
var sawReadyStateDONE = false;
function onProgress(e) {
++count;
if (sawReadyStateDONE)
log("FAILED: saw 'progress' event after readystate 'DONE' event for " + testDescription);
}
function onReadyState(e) {
if (this.readyState == 4) {
sawReadyStateDONE = true;
var passed = compare(count, iteration);
log(passed ? "PASSED" : "FAILED (count was " + count + ") for " + testDescription);
++testsCompleted;
if (testsCompleted == 5) {
if (window.testRunner)
testRunner.notifyDone();
}
}
}
var req = new XMLHttpRequest();
req.onprogress = onProgress;
req.onreadystatechange = onReadyState;
req.open("GET", "resources/download-with-delay.php?iteration=" + iteration + "&delay=" + delay, true);
req.send(null);
}
try {
// Number of chunks to send, delay between chunks
var strictTests = [ 2, 80,
1, 1000,
2, 50 ];
function compareStrict(count, iteration)
{
return count == iteration;
}
var i = 0;
while (strictTests.length) {
var iteration = strictTests.shift();
var delay = strictTests.shift();
test(iteration, delay, compareStrict, "strict test " + ++i);
}
// Number of chunks to send, delay between chunks
var throttledTests = [ 5, 20,
6, 30 ];
function compareThrottled(count, iteration)
{
return count < iteration;
}
i = 0;
while(throttledTests.length) {
var iteration = throttledTests.shift();
var delay = throttledTests.shift();
test(iteration, delay, compareThrottled, "throttled test " + ++i);
}
} catch(e) {
log("FAILED: exception raised: " + e.message);
}
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment