Commit 61cae9dc authored by Hirokazu Honda's avatar Hirokazu Honda Committed by Commit Bot

media/gpu/video_encode_accelerator_tests: Specify the proper bitrate in MultipleOutstandingEncodes

The bitrate is not specified in MultipleOutstandingEncodes case.
So the default bitrate is used. It causes a failure in higher
resolutions because of the bad stream quality. This fixed the
issue. This also removes the default argument value to the
bitrate argument in order to refrain this bug.

Bug: 1045825
Test: video_encode_accelerator_tests on atlas
Change-Id: I9c638db22175a7bc0573868fadc2057ec34bbdb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371903
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: default avatarDavid Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801324}
parent 779c4e49
......@@ -37,7 +37,7 @@ struct VideoEncoderClientConfig {
static constexpr uint32_t kDefaultBitrate = 200000;
VideoEncoderClientConfig(const Video* video,
VideoCodecProfile output_profile,
uint32_t bitrate = kDefaultBitrate);
uint32_t bitrate);
VideoEncoderClientConfig(const VideoEncoderClientConfig&);
// The output output profile to be used.
......
......@@ -252,8 +252,9 @@ TEST_F(VideoEncoderTest, DestroyBeforeInitialize) {
// Encode video from start to end. Multiple buffer encodes will be queued in the
// encoder, without waiting for the result of the previous encode requests.
TEST_F(VideoEncoderTest, FlushAtEndOfStream_MultipleOutstandingDecodes) {
VideoEncoderClientConfig config(g_env->Video(), g_env->Profile());
TEST_F(VideoEncoderTest, FlushAtEndOfStream_MultipleOutstandingEncodes) {
VideoEncoderClientConfig config(g_env->Video(), g_env->Profile(),
g_env->Bitrate());
config.max_outstanding_encode_requests = 4;
auto encoder = CreateVideoEncoder(g_env->Video(), config);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment