Re-adds the UkmTest.java file and re-adds two tests.
This partially reverts crrev.com/c/2247706 and crrev.com/c/2245049. A couple of the Android tests that were ported to chrome/browser/metrics/ukm_browsertest.cc are flaky. Temporarily re-adding this test file ensures we have coverage while we fix the tests. The tests being re-added are consentAddedButNoSyncCheck and singleSyncSignoutCheck. Also, note that mSyncTestRule.startMainActivityOnBlankPage(); is being removed from setUp() because this is done before setUp() here [1]. Calling startMainActivityOnBlankPage() twice, once via SyncTestRule and again via setUp(), results in a TimeoutException [2] the second time startMainActivityOnBlankPage() is called. A log is in [3]. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTestRule.java;l=358 [2] java.lang.RuntimeException: java.util.concurrent.TimeoutException: No Activity reached target state. [3] https://paste.googleplex.com/6459114528964608 Original change's description: > Remove a UKM test that should have been deleted. > > In the below comment, it was requested that the corresponding Android > test be removed. > https://chromium-review.googlesource.com/c/chromium/src/+/1869007/12/chrome/browser/metrics/ukm_browsertest.cc#b646 > > Bug: 1049736 > Change-Id: Iac3ff27fc4d8145bef53d45aecb54efeda5e55f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245049 > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779285} TBR=rkaplow@chromium.org,treib@chromium.org,caitlinfischer@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049736 Change-Id: I7dbc36f70ec7b9a567c7c0bb1594081c5e08dadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578057Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#835201}
Showing
Please register or sign in to comment