Commit 61e42847 authored by James Cook's avatar James Cook Committed by Commit Bot

Disable MultiProfileFileManagerBrowserTest on LSAN and MSAN

There are flaky failures in ash::tray::MultiProfileMediaTrayView
likely due to a race between media capture code's idea of the
number of users vs. ash::SessionController's idea of the number of
users.

Disable the test while that gets sorted out.

TBR=xiyuan@chromium.org

Tbr: xiyuan@chromium.org
Bug: 842442
Test: browser_tests
Change-Id: I8f80484190830aafb45ce4683be12206708d3ecc
Reviewed-on: https://chromium-review.googlesource.com/1059704Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558732}
parent e319550a
...@@ -533,22 +533,45 @@ class MultiProfileFileManagerBrowserTest : public FileManagerBrowserTestBase { ...@@ -533,22 +533,45 @@ class MultiProfileFileManagerBrowserTest : public FileManagerBrowserTestBase {
DISALLOW_COPY_AND_ASSIGN(MultiProfileFileManagerBrowserTest); DISALLOW_COPY_AND_ASSIGN(MultiProfileFileManagerBrowserTest);
}; };
IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, PRE_BasicDownloads) { // Flaky crashes in ash::tray::MultiProfileMediaTrayView.
// https://crbug.com/842442
#if defined(MEMORY_SANITIZER) || defined(ADDRESS_SANITIZER) || \
defined(LEAK_SANITIZER)
#define MAYBE_PRE_BasicDownloads DISABLED_PRE_BasicDownloads
#define MAYBE_BasicDownloads DISABLED_BasicDownloads
#else
#define MAYBE_PRE_BasicDownloads PRE_BasicDownloads
#define MAYBE_BasicDownloads BasicDownloads
#endif
IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest,
MAYBE_PRE_BasicDownloads) {
AddAllUsers(); AddAllUsers();
} }
IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, BasicDownloads) { IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest,
MAYBE_BasicDownloads) {
AddAllUsers(); AddAllUsers();
// Sanity check that normal operations work in multi-profile. // Sanity check that normal operations work in multi-profile.
set_test_case_name("keyboardCopyDownloads"); set_test_case_name("keyboardCopyDownloads");
StartTest(); StartTest();
} }
IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, PRE_BasicDrive) { // Flaky crashes in ash::tray::MultiProfileMediaTrayView.
// https://crbug.com/842442
#if defined(MEMORY_SANITIZER) || defined(ADDRESS_SANITIZER) || \
defined(LEAK_SANITIZER)
#define MAYBE_PRE_BasicDrive DISABLED_PRE_BasicDrive
#define MAYBE_BasicDrive DISABLED_BasicDrive
#else
#define MAYBE_PRE_BasicDrive PRE_BasicDrive
#define MAYBE_BasicDrive BasicDrive
#endif
IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest,
MAYBE_PRE_BasicDrive) {
AddAllUsers(); AddAllUsers();
} }
IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, BasicDrive) { IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) {
AddAllUsers(); AddAllUsers();
// Sanity check that normal operations work in multi-profile. // Sanity check that normal operations work in multi-profile.
set_test_case_name("keyboardCopyDrive"); set_test_case_name("keyboardCopyDrive");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment