Commit 61e450a2 authored by Finnur Thorarinsson's avatar Finnur Thorarinsson Committed by Commit Bot

Add unit test for RoundedIconGenerator.

Bug: 860467
Change-Id: I47903e2b2ce025d809025c57cd6ed85441c46a73
Reviewed-on: https://chromium-review.googlesource.com/1183668
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584828}
parent 605cc1f4
...@@ -4,14 +4,19 @@ ...@@ -4,14 +4,19 @@
package org.chromium.chrome.browser.widget; package org.chromium.chrome.browser.widget;
import android.content.Context;
import android.support.test.InstrumentationRegistry;
import android.support.test.filters.SmallTest; import android.support.test.filters.SmallTest;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Before;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.test.ChromeBrowserTestRule; import org.chromium.chrome.browser.test.ChromeBrowserTestRule;
import org.chromium.chrome.test.ChromeJUnit4ClassRunner; import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
...@@ -23,6 +28,13 @@ public class RoundedIconGeneratorTest { ...@@ -23,6 +28,13 @@ public class RoundedIconGeneratorTest {
@Rule @Rule
public final ChromeBrowserTestRule mBrowserTestRule = new ChromeBrowserTestRule(); public final ChromeBrowserTestRule mBrowserTestRule = new ChromeBrowserTestRule();
private Context mContext;
@Before
public void setUp() throws Exception {
mContext = InstrumentationRegistry.getTargetContext();
}
private String getIconTextForUrl(String url, boolean includePrivateRegistries) { private String getIconTextForUrl(String url, boolean includePrivateRegistries) {
return RoundedIconGenerator.getIconTextForUrl(url, includePrivateRegistries); return RoundedIconGenerator.getIconTextForUrl(url, includePrivateRegistries);
} }
...@@ -58,4 +70,27 @@ public class RoundedIconGeneratorTest { ...@@ -58,4 +70,27 @@ public class RoundedIconGeneratorTest {
getIconTextForUrl("file:///home/chrome/test.html", false)); getIconTextForUrl("file:///home/chrome/test.html", false));
Assert.assertEquals("data:image", getIconTextForUrl("data:image", false)); Assert.assertEquals("data:image", getIconTextForUrl("data:image", false));
} }
/**
* Verifies that asking for more letters than can be served does not crash.
*/
@Test
@SmallTest
@Feature({"Browser", "RoundedIconGenerator"})
public void testGenerateIconForText() {
final int iconSizeDp = 32;
final int iconCornerRadiusDp = 20;
final int iconTextSizeDp = 12;
int iconColor = ApiCompatibilityUtils.getColor(
mContext.getResources(), R.color.default_favicon_background_color);
RoundedIconGenerator generator = new RoundedIconGenerator(mContext.getResources(),
iconSizeDp, iconSizeDp, iconCornerRadiusDp, iconColor, iconTextSizeDp);
Assert.assertTrue(generator.generateIconForText("", 0) != null);
Assert.assertTrue(generator.generateIconForText("", 1) != null);
Assert.assertTrue(generator.generateIconForText("A", 0) != null);
Assert.assertTrue(generator.generateIconForText("A", 1) != null);
Assert.assertTrue(generator.generateIconForText("A", 2) != null);
}
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment