Commit 621015a9 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Remove baseline overrides of LayoutMenuList

They are unnecessary since crrev.com/735492.
This CL should have no behavior changes, however this updates a rendering
test for empty lines.

Bug: 1040828
Change-Id: I83c665eb2a136a98d5f9dbcc8b435964fb177c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024187Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735740}
parent 5ed91c4e
......@@ -75,23 +75,6 @@ class CORE_EXPORT LayoutMenuList final : public LayoutFlexibleBox {
bool HasLineIfEmpty() const override { return true; }
// Flexbox defines baselines differently than regular blocks.
// For backwards compatibility, menulists need to do the regular block
// behavior.
LayoutUnit BaselinePosition(FontBaseline baseline,
bool first_line,
LineDirectionMode direction,
LinePositionMode position) const override {
return LayoutBlock::BaselinePosition(baseline, first_line, direction,
position);
}
LayoutUnit FirstLineBoxBaseline() const override {
return LayoutBlock::FirstLineBoxBaseline();
}
LayoutUnit InlineBlockBaseline(LineDirectionMode direction) const override {
return LayoutBlock::InlineBlockBaseline(direction);
}
void CreateInnerBlock();
scoped_refptr<ComputedStyle> CreateInnerStyle();
void UpdateInnerStyle();
......
......@@ -38,11 +38,13 @@ select {
<!-- shadow -->
<select style="box-shadow: 4px 4px 10px rgba(255,0,0,0.5), inset 4px 4px 4px rgba(0,255,0,0.5);"><option>foo</option></select> <br>
<!-- font -->
Font-size and baseline:
<select style="font-size: 16px;"><option>foo</option></select>
<select style="font-size: 20px;"><option>foo</option></select>
<select style="font-size: 24px;"><option>foo</option></select>
<select style="-webkit-appearance:menulist-button; font-weight:bold"><option>September 2016</option></select>
<select></select>
<select style="font-size: 24px;"></select>
<br>
<!-- zoom -->
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment