Deprecate cache.addAll() with duplicate requests.

R=jsbell@chromium.org

Bug: 720919
Change-Id: I1fc7b1f5847bdc5795b256c11f86b6c59c181962
Reviewed-on: https://chromium-review.googlesource.com/1241333Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594539}

third_party/blink/renderer/core/frame/deprecation.cc

@@ -601,6 +601,11 @@ DeprecationInfo GetDeprecationInfo(WebFeature feature) {
                             "worker installation",
                             kM71, "5748516353736704")};
 
+    case WebFeature::kCacheStorageAddAllSuccessWithDuplicate:
+      return {"CacheStorageAddAllSuccessWithDuplicate", kM72,
+              WillBeRemoved("Cache.addAll() with duplicate requests", kM72,
+                            "5622587912617984")};
+
     // Features that aren't deprecated don't have a deprecation message.
     default:
       return {"NotDeprecated", kUnknown, ""};

third_party/blink/renderer/core/frame/deprecation.h

@@ -39,9 +39,6 @@ class CORE_EXPORT Deprecation {
   // Be considerate to developers' consoles: features should only send
   // deprecation warnings when we're actively interested in removing them from
   // the platform.
-  //
-  // For shared workers and service workers, the ExecutionContext* overload
-  // doesn't count the usage but only sends a console warning.
   static void CountDeprecation(const LocalFrame*, WebFeature);
   static void CountDeprecation(ExecutionContext*, WebFeature);
   static void CountDeprecation(const Document&, WebFeature);

third_party/blink/renderer/modules/cache_storage/cache.cc

@@ -26,7 +26,7 @@
 #include "third_party/blink/renderer/core/fetch/request.h"
 #include "third_party/blink/renderer/core/fetch/request_init.h"
 #include "third_party/blink/renderer/core/fetch/response.h"
-#include "third_party/blink/renderer/core/frame/use_counter.h"
+#include "third_party/blink/renderer/core/frame/deprecation.h"
 #include "third_party/blink/renderer/core/html/parser/text_resource_decoder.h"
 #include "third_party/blink/renderer/core/inspector/console_message.h"
 #include "third_party/blink/renderer/modules/cache_storage/cache_storage_error.h"
@@ -224,7 +224,7 @@ class Cache::BarrierCallbackForPut final
                   if (error->message.Contains(
                           blink::cache_storage::
                               kDuplicateOperationBaseMessage)) {
-                    UseCounter::Count(
+                    Deprecation::CountDeprecation(
                         context,
                         WebFeature::kCacheStorageAddAllSuccessWithDuplicate);
                   }