Adding a confirmation dialog for It2Me on Linux

This change adds a confirmation dialog for the It2Me Linux host.  This
dialog will be displayed when an incoming It2Me connection and will wait
up to 60 seconds for the user to accept/reject it.  If the user accepts
the connection then we will complete the conneciton process, otherwise
the incoming request will be rejected.

BUG=645540

Review-Url: https://codereview.chromium.org/2343443002
Cr-Commit-Position: refs/heads/master@{#418611}

build/config/linux/gtk2/BUILD.gn

@@ -28,6 +28,7 @@ group("gtk2") {
     "//chrome/browser/ui/libgtk2ui",
     "//gpu/gles2_conform_support:gles2_conform_test_windowless",
     "//remoting/host",
+    "//remoting/host/it2me:common",
     "//remoting/host/it2me:remote_assistance_host",
     "//remoting/host:remoting_me2me_host_static",
     "//remoting/test:it2me_standalone_host_main",

remoting/host/it2me/BUILD.gn

@@ -65,6 +65,8 @@ source_set("common") {
     # disabled.
     # See crbug.com/462689 for details.
     all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ]
+
+    deps += [ "//build/config/linux/gtk2" ]
   }
 }
 

remoting/host/it2me/it2me_confirmation_dialog_linux.cc

@@ -2,13 +2,151 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <gtk/gtk.h>
+
+#include <memory>
+#include <string>
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/callback_helpers.h"
+#include "base/i18n/message_formatter.h"
+#include "base/location.h"
+#include "base/logging.h"
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
+#include "base/timer/timer.h"
+#include "remoting/base/string_resources.h"
 #include "remoting/host/it2me/it2me_confirmation_dialog.h"
+#include "ui/base/glib/glib_signal.h"
+#include "ui/base/l10n/l10n_util.h"
 
 namespace remoting {
 
+namespace {
+
+// Time to wait before closing the dialog and cancelling the connection.
+constexpr base::TimeDelta kDialogTimeout = base::TimeDelta::FromMinutes(1);
+
+class It2MeConfirmationDialogLinux : public It2MeConfirmationDialog {
+ public:
+  It2MeConfirmationDialogLinux();
+  ~It2MeConfirmationDialogLinux() override;
+
+  // It2MeConfirmationDialog implementation.
+  void Show(const std::string& remote_user_email,
+            const ResultCallback& callback) override;
+
+ private:
+  // Creates a dialog window and makes it visible.
+  void CreateWindow(const std::string& remote_user_email);
+
+  // Destroys the dialog window (if created) and stop |dialog_timer_|.
+  void Hide();
+
+  // Handles user input from the dialog.
+  CHROMEG_CALLBACK_1(It2MeConfirmationDialogLinux, void, OnResponse, GtkDialog*,
+                     int);
+
+  GtkWidget* confirmation_window_ = nullptr;
+
+  ResultCallback result_callback_;
+
+  base::OneShotTimer dialog_timer_;
+
+  DISALLOW_COPY_AND_ASSIGN(It2MeConfirmationDialogLinux);
+};
+
+It2MeConfirmationDialogLinux::It2MeConfirmationDialogLinux() {}
+
+It2MeConfirmationDialogLinux::~It2MeConfirmationDialogLinux() {
+  Hide();
+}
+
+void It2MeConfirmationDialogLinux::Show(const std::string& remote_user_email,
+                                        const ResultCallback& callback) {
+  DCHECK(!remote_user_email.empty());
+  DCHECK(callback);
+  DCHECK(!result_callback_);
+
+  result_callback_ = callback;
+
+  CreateWindow(remote_user_email);
+
+  dialog_timer_.Start(FROM_HERE, kDialogTimeout,
+                      base::Bind(&It2MeConfirmationDialogLinux::OnResponse,
+                                 base::Unretained(this),
+                                 /*dialog=*/nullptr, GTK_RESPONSE_NONE));
+}
+
+void It2MeConfirmationDialogLinux::Hide() {
+  dialog_timer_.Stop();
+
+  if (confirmation_window_) {
+    gtk_widget_destroy(confirmation_window_);
+    confirmation_window_ = nullptr;
+  }
+}
+
+void It2MeConfirmationDialogLinux::CreateWindow(
+    const std::string& remote_user_email) {
+  DCHECK(!confirmation_window_);
+
+  confirmation_window_ = gtk_dialog_new_with_buttons(
+      l10n_util::GetStringUTF8(IDS_PRODUCT_NAME).c_str(),
+      /*parent=*/nullptr,
+      static_cast<GtkDialogFlags>(GTK_DIALOG_MODAL),
+      l10n_util::GetStringUTF8(IDS_SHARE_CONFIRM_DIALOG_DECLINE).c_str(),
+      GTK_RESPONSE_CANCEL,
+      l10n_util::GetStringUTF8(IDS_SHARE_CONFIRM_DIALOG_CONFIRM).c_str(),
+      GTK_RESPONSE_OK,
+      /*next_button=*/nullptr);
+
+  gtk_dialog_set_default_response(GTK_DIALOG(confirmation_window_),
+                                  GTK_RESPONSE_CANCEL);
+
+  gtk_window_set_resizable(GTK_WINDOW(confirmation_window_), false);
+
+  gtk_window_set_keep_above(GTK_WINDOW(confirmation_window_), true);
+
+  g_signal_connect(confirmation_window_, "response",
+                   G_CALLBACK(OnResponseThunk), this);
+
+  GtkWidget* content_area =
+      gtk_dialog_get_content_area(GTK_DIALOG(confirmation_window_));
+
+  base::string16 dialog_text =
+      base::i18n::MessageFormatter::FormatWithNumberedArgs(
+          l10n_util::GetStringUTF16(
+              IDS_SHARE_CONFIRM_DIALOG_MESSAGE_WITH_USERNAME),
+          remote_user_email);
+  GtkWidget* text_label = gtk_label_new(base::UTF16ToUTF8(dialog_text).c_str());
+  gtk_label_set_line_wrap(GTK_LABEL(text_label), true);
+  gtk_misc_set_padding(GTK_MISC(text_label), 12, 12);
+
+  gtk_container_add(GTK_CONTAINER(content_area), text_label);
+  gtk_widget_show_all(content_area);
+
+  gtk_window_set_urgency_hint(GTK_WINDOW(confirmation_window_), true);
+  gtk_window_present(GTK_WINDOW(confirmation_window_));
+}
+
+void It2MeConfirmationDialogLinux::OnResponse(GtkDialog* dialog,
+                                              int response_id) {
+  DCHECK(result_callback_);
+
+  Hide();
+  base::ResetAndReturn(&result_callback_).Run(
+      (response_id == GTK_RESPONSE_OK) ? Result::OK : Result::CANCEL);
+}
+
+}  // namespace
+
 std::unique_ptr<It2MeConfirmationDialog>
 It2MeConfirmationDialogFactory::Create() {
-  return nullptr;
+  return base::MakeUnique<It2MeConfirmationDialogLinux>();
 }
 
 }  // namespace remoting

remoting/host/it2me/it2me_confirmation_dialog_win.cc

@@ -5,6 +5,7 @@
 #include <windows.h>
 #include <commctrl.h>
 
+#include <cstdint>
 #include <memory>
 #include <string>
 
@@ -17,6 +18,7 @@
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
 #include "remoting/host/it2me/it2me_confirmation_dialog.h"
 #include "remoting/host/win/core_resource.h"
 
@@ -25,7 +27,7 @@ namespace remoting {
 namespace {
 
 // Time to wait before closing the dialog and cancelling the connection.
-const int kDialogTimeoutMs = 60 * 1000;
+constexpr base::TimeDelta kDialogTimeout = base::TimeDelta::FromMinutes(1);
 
 const HRESULT kTimeoutErrorCode = E_ABORT;
 
@@ -179,7 +181,7 @@ It2MeConfirmationDialogWin::TaskDialogCallbackProc(HWND hwnd,
                                                    LPARAM l_param,
                                                    LONG_PTR ref_data) {
   if (notification == TDN_TIMER) {
-    if (w_param >= kDialogTimeoutMs) {
+    if (static_cast<int64_t>(w_param) >= kDialogTimeout.InMilliseconds()) {
       // Close the dialog window if we have reached the timeout.
       return kTimeoutErrorCode;
     }