Commit 6257fe9e authored by Dominick Ng's avatar Dominick Ng Committed by Commit Bot

Enable shelf_context_menu_unittest.cc with BMO.

Call TestWebAppProvider::Start() in the tests to stop the App Service
waiting for web apps to be published.

BUG=1082887

Change-Id: Iaac9d8c2357dc74c12e30942a68a5d5a02d532ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215159Reviewed-by: default avatarEric Willigers <ericwilligers@chromium.org>
Reviewed-by: default avatarNancy Wang <nancylingwang@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772120}
parent 9e169edb
......@@ -37,6 +37,7 @@
#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
#include "chrome/browser/ui/ash/launcher/extension_shelf_context_menu.h"
#include "chrome/browser/ui/ash/launcher/internal_app_shelf_context_menu.h"
#include "chrome/browser/web_applications/test/test_web_app_provider.h"
#include "chrome/browser/web_applications/test/web_app_test.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/chrome_ash_test_base.h"
......@@ -92,6 +93,7 @@ class ShelfContextMenuTest
~ShelfContextMenuTest() override = default;
void SetUp() override {
web_app::TestWebAppProvider::Get(&profile_)->Start();
app_service_test_.SetUp(&profile_);
arc_test_.SetUp(&profile_);
session_manager_ = std::make_unique<session_manager::SessionManager>();
......@@ -662,10 +664,10 @@ TEST_P(ShelfContextMenuTest, CrostiniUnregisteredApps) {
EXPECT_FALSE(IsItemEnabledInMenu(menu.get(), ash::MENU_NEW_WINDOW));
}
// TODO(crbug.com/1082887): Test with BMO enabled.
INSTANTIATE_TEST_SUITE_P(All,
ShelfContextMenuTest,
::testing::Values(ProviderType::kBookmarkApps),
::testing::Values(ProviderType::kBookmarkApps,
ProviderType::kWebApps),
web_app::ProviderTypeParamToString);
} // namespace
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment